[DSC-2397] Fix lint

Author: atarix83

src/app/shared/form/builder/ds-dynamic-form-ui/models/dynamic-vocabulary.component.ts

@@ -21,7 +21,8 @@ import {
   distinctUntilChanged,
   filter,
   map,
-  take, tap,
+  take,
+  tap,
 } from 'rxjs/operators';
 
 import { Metadata } from '../../../../../core/shared/metadata.utils';
@@ -307,7 +308,7 @@ export abstract class DsDynamicVocabularyComponent extends DynamicFormControlCom
       return null;
     }
 
-    let returnValue = [];
+    const returnValue = [];
     if (value.indexOf('|||') === -1) {
       returnValue.push(this.generateFormField(value));
     } else if (value.indexOf('|||') !== -1 && this.otherInfoValue) {
@@ -317,7 +318,7 @@ export abstract class DsDynamicVocabularyComponent extends DynamicFormControlCom
       } else {
         const unformattedValue = this.otherInfoValuesUnformatted.find(otherInfoValue => otherInfoValue.includes(this.otherInfoValue || this.otherName));
         const authorityValue = hasValue(unformattedValue) ? unformattedValue.substring(unformattedValue.lastIndexOf('::') + 2) : null;
-        let otherInfo = {};
+        const otherInfo = {};
         let alternativeValue: string;
         otherInfo[key] = value;
         if (hasValue(this.otherName)) {
@@ -331,7 +332,7 @@ export abstract class DsDynamicVocabularyComponent extends DynamicFormControlCom
           null,
           null,
           null,
-          otherInfo
+          otherInfo,
         ));
       }
     }
@@ -346,7 +347,7 @@ export abstract class DsDynamicVocabularyComponent extends DynamicFormControlCom
         value.substring(0, value.lastIndexOf('::')),
         null,
         null,
-        value.substring(value.lastIndexOf('::') + 2)
+        value.substring(value.lastIndexOf('::') + 2),
       );
     }
   }

src/app/shared/form/builder/ds-dynamic-form-ui/models/onebox/dynamic-onebox.component.spec.ts

@@ -104,7 +104,7 @@ describe('DsDynamicOneboxComponent test suite', () => {
 
   let scheduler: TestScheduler;
   let testComp: TestComponent;
-  let oneboxComponent: DsDynamicOneboxComponent|any;
+  let oneboxComponent: DsDynamicOneboxComponent;
   let testFixture: ComponentFixture<TestComponent>;
   let debugElement: DebugElement;
   let oneboxCompFixture: ComponentFixture<DsDynamicOneboxComponent>;
@@ -571,65 +571,65 @@ describe('DsDynamicOneboxComponent test suite', () => {
       });
     });
 
-  describe('test metadata enrichment', () => {
-    beforeEach(() => {
-      oneboxCompFixture = TestBed.createComponent(DsDynamicOneboxComponent);
-      debugElement = oneboxCompFixture.debugElement;
-      oneboxComponent = oneboxCompFixture.componentInstance;
-      oneboxComponent.currentValue = new FormFieldMetadataValueObject('test', null, null, null, 'testDisplay');
-      oneboxComponent.model = new DynamicOneboxModel(ONEBOX_TEST_MODEL_CONFIG);
+    describe('test metadata enrichment', () => {
+      beforeEach(() => {
+        oneboxCompFixture = TestBed.createComponent(DsDynamicOneboxComponent);
+        debugElement = oneboxCompFixture.debugElement;
+        oneboxComponent = oneboxCompFixture.componentInstance;
+        oneboxComponent.currentValue = new FormFieldMetadataValueObject('test', null, null, null, 'testDisplay');
+        oneboxComponent.model = new DynamicOneboxModel(ONEBOX_TEST_MODEL_CONFIG);
 
-      spyOn(oneboxComponent, 'onSelectItem').and.returnValue(undefined);
-      spyOn(oneboxComponent, 'toggleOtherInfoSelection').and.returnValue(undefined);
-    });
+        spyOn(oneboxComponent, 'onSelectItem').and.returnValue(undefined);
+        spyOn(oneboxComponent, 'toggleOtherInfoSelection').and.returnValue(undefined);
+      });
 
 
-    it('should return null if value is empty', () => {
-      expect(oneboxComponent.getOtherInformationValue('', 'some-key')).toBeNull();
-    });
+      it('should return null if value is empty', () => {
+        expect(oneboxComponent.getOtherInformationValue('', 'some-key')).toBeNull();
+      });
 
-    it('should return null if key is "alternative-names"', () => {
-      expect(oneboxComponent.getOtherInformationValue('some-value', 'alternative-names')).toBeNull();
-    });
+      it('should return null if key is "alternative-names"', () => {
+        expect(oneboxComponent.getOtherInformationValue('some-value', 'alternative-names')).toBeNull();
+      });
 
-    it('should return single FormFieldMetadataValueObject if no "|||" in value', () => {
-      const result = oneboxComponent.getOtherInformationValue('value::authority', 'some-key');
-      expect(result.length).toBe(1);
-      expect(result[0]).toEqual(jasmine.any(FormFieldMetadataValueObject));
-      expect(result[0].value).toBe('value');
-      expect(result[0].authority).toBe('authority');
-    });
+      it('should return single FormFieldMetadataValueObject if no "|||" in value', () => {
+        const result = oneboxComponent.getOtherInformationValue('value::authority', 'some-key');
+        expect(result.length).toBe(1);
+        expect(result[0]).toEqual(jasmine.any(FormFieldMetadataValueObject));
+        expect(result[0].value).toBe('value');
+        expect(result[0].authority).toBe('authority');
+      });
 
-    it('should handle multiple values with multiValueOnGenerator true', () => {
-      oneboxComponent.multiValueOnGenerator = true;
-      oneboxComponent.otherInfoValue = 'someValue';
-      const result = oneboxComponent.getOtherInformationValue('val1::auth1|||val2::auth2', 'some-key');
-      expect(result.length).toBe(2);
-      expect(result[0].value).toBe('val1');
-      expect(result[0].authority).toBe('auth1');
-      expect(result[1].value).toBe('val2');
-      expect(result[1].authority).toBe('auth2');
-    });
+      it('should handle multiple values with multiValueOnGenerator true', () => {
+        oneboxComponent.multiValueOnGenerator = true;
+        (oneboxComponent as any).otherInfoValue = 'someValue';
+        const result = oneboxComponent.getOtherInformationValue('val1::auth1|||val2::auth2', 'some-key');
+        expect(result.length).toBe(2);
+        expect(result[0].value).toBe('val1');
+        expect(result[0].authority).toBe('auth1');
+        expect(result[1].value).toBe('val2');
+        expect(result[1].authority).toBe('auth2');
+      });
 
-    it('should handle multiple values with multiValueOnGenerator false', () => {
-      oneboxComponent.multiValueOnGenerator = false;
-      oneboxComponent.otherInfoValue = 'val1';
-      oneboxComponent.otherInfoValuesUnformatted = ['val1::auth1'];
-      const result = oneboxComponent.getOtherInformationValue('val1::auth1|||val2::auth2', 'data-key');
-      expect(result.length).toBe(1);
-      expect(result[0].value).toBe('val1');
-      expect(result[0].authority).toBe('auth1');
-      expect(result[0].otherInformation['data-key']).toBe('val1::auth1|||val2::auth2');
-    });
+      it('should handle multiple values with multiValueOnGenerator false', () => {
+        oneboxComponent.multiValueOnGenerator = false;
+        (oneboxComponent as any).otherInfoValue = 'val1';
+        oneboxComponent.otherInfoValuesUnformatted = ['val1::auth1'];
+        const result = oneboxComponent.getOtherInformationValue('val1::auth1|||val2::auth2', 'data-key');
+        expect(result.length).toBe(1);
+        expect(result[0].value).toBe('val1');
+        expect(result[0].authority).toBe('auth1');
+        expect(result[0].otherInformation['data-key']).toBe('val1::auth1|||val2::auth2');
+      });
 
-    it('should handle value without "::"', () => {
-      const result = oneboxComponent.getOtherInformationValue('simpleValue', 'some-key');
-      expect(result.length).toBe(1);
-      expect(result[0].value).toBe('simpleValue');
-      expect(result[0].authority).toBeNull();
-    });
+      it('should handle value without "::"', () => {
+        const result = oneboxComponent.getOtherInformationValue('simpleValue', 'some-key');
+        expect(result.length).toBe(1);
+        expect(result[0].value).toBe('simpleValue');
+        expect(result[0].authority).toBeNull();
+      });
 
-  });
+    });
   });
 });