[DSC-2887] fix: test and lint

Author: FrancescoMauto

src/app/app.metareducers.spec.ts

@@ -1,4 +1,3 @@
-import { AppState } from './app.reducer';
 import { universalMetaReducer } from './app.metareducers';
 import { StoreActionTypes } from './store.actions';
 
@@ -13,13 +12,14 @@ describe('universalMetaReducer', () => {
 
   describe('REHYDRATE', () => {
     it('should merge payload into state', () => {
-      const state = { core: { existing: true } };
+      const state = { otherProp: 'keep-me' };
       const payload = { core: { route: { queryParams: { f: ['x'] }, params: {} } } };
       const result = universalMetaReducer(mockReducer)(state, {
         type: StoreActionTypes.REHYDRATE,
         payload,
       });
-      expect(result.core.existing).toBe(true);
+      expect(result.otherProp).toBe('keep-me');
+      expect(result.core.route).toEqual({ queryParams: {}, params: {} });
     });
 
     it('should reset core.route to empty after rehydration', () => {
@@ -39,12 +39,12 @@ describe('universalMetaReducer', () => {
         type: StoreActionTypes.REHYDRATE,
         payload,
       });
-      expect(result).toEqual(payload);
+      expect(result.core.route).toEqual({ queryParams: {}, params: {} });
     });
 
     it('should preserve other core properties when resetting route', () => {
-      const state = { core: { route: {}, otherProp: 'keep-me' } };
-      const payload = { core: { route: { queryParams: { x: '1' }, params: {} } } };
+      const state = { core: { route: {} } };
+      const payload = { core: { route: { queryParams: { x: '1' }, params: {} }, otherProp: 'keep-me' } };
       const result = universalMetaReducer(mockReducer)(state, {
         type: StoreActionTypes.REHYDRATE,
         payload,
@@ -61,4 +61,4 @@ describe('universalMetaReducer', () => {
       expect(result).toEqual(state);
     });
   });
-});
+});

src/app/app.metareducers.ts

@@ -21,7 +21,7 @@ export function universalMetaReducer(reducer) {
         state = Object.assign({}, state, action.payload);
         if (state.core) {
           state.core = Object.assign({}, state.core, {
-            route: { queryParams: {}, params: {} }
+            route: { queryParams: {}, params: {} },
           });
         }
         break;

src/app/core/services/route.reducer.spec.ts

@@ -9,7 +9,10 @@ import {
   SetQueryParameterAction,
   SetQueryParametersAction,
 } from './route.actions';
-import { routeReducer, RouteState } from './route.reducer';
+import {
+  routeReducer,
+  RouteState,
+} from './route.reducer';
 
 describe('routeReducer', () => {
   const initialState: RouteState = {

src/app/item-page/cris-item-page-tab.resolver.ts

@@ -55,19 +55,19 @@ export const crisItemPageTabResolver: ResolveFn<RemoteData<PaginatedList<CrisLay
         ).pipe(
           getFirstCompletedRemoteData(),
           map((tabsRD: RemoteData<PaginatedList<CrisLayoutTab>>) => {
-              if (tabsRD.hasSucceeded && tabsRD?.payload?.page?.length > 0) {
-                // By splitting the url with uuid we can understand if the item is primary item page or a tab
-                const urlWithoutQuery = state.url.split('?')[0];
-                const urlSplit = urlWithoutQuery.split(route.params.id);
-                const tabArguments = urlSplit[1]?.split('/');
-                const givenTab = tabArguments?.[1];
-                const itemPageRoute = getItemPageRoute(itemRD.payload);
+            if (tabsRD.hasSucceeded && tabsRD?.payload?.page?.length > 0) {
+              // By splitting the url with uuid we can understand if the item is primary item page or a tab
+              const urlWithoutQuery = state.url.split('?')[0];
+              const urlSplit = urlWithoutQuery.split(route.params.id);
+              const tabArguments = urlSplit[1]?.split('/');
+              const givenTab = tabArguments?.[1];
+              const itemPageRoute = getItemPageRoute(itemRD.payload);
 
-                const isValidTab = !givenTab || tabsRD.payload.page.some((tab) => {
-                  const shortnameSplit = tab.shortname.split('::');
-                  const shortname = shortnameSplit[shortnameSplit.length - 1];
-                  return shortname === givenTab;
-                });
+              const isValidTab = !givenTab || tabsRD.payload.page.some((tab) => {
+                const shortnameSplit = tab.shortname.split('::');
+                const shortname = shortnameSplit[shortnameSplit.length - 1];
+                return shortname === givenTab;
+              });
 
               const mainTab = tabsRD.payload.page.length === 1
                 ? tabsRD.payload.page[0]