[DSC-2812] fix to show other workspace configuration

(cherry picked from commit 5622416)

Author: AdamF42

src/app/my-dspace-page/my-dspace-configuration.service.spec.ts

@@ -208,6 +208,7 @@ describe('MyDSpaceConfigurationService', () => {
         b: [
           MyDSpaceConfigurationValueType.SupervisedItems,
           MyDSpaceConfigurationValueType.Workflow,
+          MyDSpaceConfigurationValueType.OtherWorkspace,
         ],
       }));
     });
@@ -223,6 +224,7 @@ describe('MyDSpaceConfigurationService', () => {
         b: [
           MyDSpaceConfigurationValueType.SupervisedItems,
           MyDSpaceConfigurationValueType.Workflow,
+          MyDSpaceConfigurationValueType.OtherWorkspace,
         ],
       }));
     });
@@ -237,9 +239,9 @@ describe('MyDSpaceConfigurationService', () => {
       expect(list$).toBeObservable(cold('(b|)', {
         b: [
           MyDSpaceConfigurationValueType.Workspace,
-          MyDSpaceConfigurationValueType.OtherWorkspace,
           MyDSpaceConfigurationValueType.SupervisedItems,
           MyDSpaceConfigurationValueType.Workflow,
+          MyDSpaceConfigurationValueType.OtherWorkspace,
         ],
       }));
     });

src/app/my-dspace-page/my-dspace-configuration.service.ts

@@ -125,12 +125,12 @@ export class MyDSpaceConfigurationService extends SearchConfigurationService {
         const availableConf: MyDSpaceConfigurationValueType[] = [];
         if (isSubmitter) {
           availableConf.push(MyDSpaceConfigurationValueType.Workspace);
-          availableConf.push(MyDSpaceConfigurationValueType.OtherWorkspace);
         }
         if (isController || isAdmin) {
           availableConf.push(MyDSpaceConfigurationValueType.SupervisedItems);
           availableConf.push(MyDSpaceConfigurationValueType.Workflow);
         }
+        availableConf.push(MyDSpaceConfigurationValueType.OtherWorkspace);
         return availableConf;
       }));
   }