Merge remote-tracking branch 'gitHub/main' into task/main/DURACOM-456

Author: FrancescoMolinaro

.github/dependabot.yml

@@ -107,12 +107,27 @@ updates:
     # some classes of supply chain attacks
     cooldown:
       default-days: 7
+    groups:
+      # Group together all GitHub official actions into a single PR
+      github-actions:
+        applies-to: version-updates
+        patterns:
+        - "actions/*"
+        - "github/*"
+    ignore:
+      # For official GitHub actions, ignore minor & patch releases because we reference these actions
+      # via a major version tag which automatically uses the latest minor/patch version (e.g. "actions/checkout@v6")
+      - dependency-name: "actions/*"
+        update-types: [ "version-update:semver-minor", "version-update:semver-patch"]
+      - dependency-name: "github/*"
+        update-types: [ "version-update:semver-minor", "version-update:semver-patch"]
   #####################
-  ## dspace-9_x branch
+  ## dspace-10_x branch
   #####################
   - package-ecosystem: "npm"
     directory: "/"
-    target-branch: dspace-9_x
+    target-branch: dspace-10_x
+    # Monthly dependency updates (NOTE: "schedule" doesn't apply to security updates)
     schedule:
       interval: "monthly"
       time: "05:00"
@@ -124,7 +139,7 @@ updates:
     open-pull-requests-limit: 10
     # Group together Angular package upgrades
     groups:
-      # Group together all patch version updates for Angular in a single PR
+      # Group together all minor/patch version updates for Angular in a single PR
       angular:
         applies-to: version-updates
         patterns:
@@ -138,7 +153,6 @@ updates:
         applies-to: version-updates
         patterns:
         - "@ngrx*"
-        - "@ngtools/webpack"
         update-types:
         - "minor"
         - "patch"
@@ -198,10 +212,10 @@ updates:
       # Ignore all major version updates for all dependencies. We'll only automate minor/patch updates.
       - dependency-name: "*"
         update-types: ["version-update:semver-major"]
-  # Also automatically update all our GitHub actions on the dspace-9_x branch
+  # Also automatically update all our GitHub actions on the dspace-10_x branch
   - package-ecosystem: "github-actions"
     directory: "/"
-    target-branch: dspace-9_x
+    target-branch: dspace-10_x
     # Monthly dependency updates
     schedule:
       interval: "monthly"
@@ -210,12 +224,26 @@ updates:
     # some classes of supply chain attacks
     cooldown:
       default-days: 7
+    groups:
+      # Group together all GitHub official actions into a single PR
+      github-actions:
+        applies-to: version-updates
+        patterns:
+        - "actions/*"
+        - "github/*"
+    ignore:
+      # For official GitHub actions, ignore minor & patch releases because we reference these actions
+      # via a major version tag which automatically uses the latest minor/patch version (e.g. "actions/checkout@v6")
+      - dependency-name: "actions/*"
+        update-types: [ "version-update:semver-minor", "version-update:semver-patch"]
+      - dependency-name: "github/*"
+        update-types: [ "version-update:semver-minor", "version-update:semver-patch"]
   #####################
-  ## dspace-8_x branch
+  ## dspace-9_x branch
   #####################
   - package-ecosystem: "npm"
     directory: "/"
-    target-branch: dspace-8_x
+    target-branch: dspace-9_x
     schedule:
       interval: "monthly"
       time: "05:00"
@@ -241,6 +269,7 @@ updates:
         applies-to: version-updates
         patterns:
         - "@ngrx*"
+        - "@ngtools/webpack"
         update-types:
         - "minor"
         - "patch"
@@ -300,10 +329,10 @@ updates:
       # Ignore all major version updates for all dependencies. We'll only automate minor/patch updates.
       - dependency-name: "*"
         update-types: ["version-update:semver-major"]
-  # Also automatically update all our GitHub actions on the dspace-8_x branch
+  # Also automatically update all our GitHub actions on the dspace-9_x branch
   - package-ecosystem: "github-actions"
     directory: "/"
-    target-branch: dspace-8_x
+    target-branch: dspace-9_x
     # Monthly dependency updates
     schedule:
       interval: "monthly"
@@ -312,12 +341,26 @@ updates:
     # some classes of supply chain attacks
     cooldown:
       default-days: 7
+    groups:
+      # Group together all GitHub official actions into a single PR
+      github-actions:
+        applies-to: version-updates
+        patterns:
+        - "actions/*"
+        - "github/*"
+    ignore:
+      # For official GitHub actions, ignore minor & patch releases because we reference these actions
+      # via a major version tag which automatically uses the latest minor/patch version (e.g. "actions/checkout@v6")
+      - dependency-name: "actions/*"
+        update-types: [ "version-update:semver-minor", "version-update:semver-patch"]
+      - dependency-name: "github/*"
+        update-types: [ "version-update:semver-minor", "version-update:semver-patch"]
   #####################
-  ## dspace-7_x branch
+  ## dspace-8_x branch
   #####################
   - package-ecosystem: "npm"
     directory: "/"
-    target-branch: dspace-7_x
+    target-branch: dspace-8_x
     schedule:
       interval: "monthly"
       time: "05:00"
@@ -329,7 +372,7 @@ updates:
     open-pull-requests-limit: 10
     # Group together Angular package upgrades
     groups:
-      # Group together all minor/patch version updates for Angular in a single PR
+      # Group together all patch version updates for Angular in a single PR
       angular:
         applies-to: version-updates
         patterns:
@@ -384,10 +427,18 @@ updates:
         update-types:
         - "minor"
         - "patch"
+      # Group together any webpack related version updates
+      webpack:
+        applies-to: version-updates
+        patterns:
+        - "webpack*"
+        update-types:
+        - "minor"
+        - "patch"
     ignore:
-      # 7.x Cannot update Webpack past v5.76.1 as later versions not supported by Angular 15
-      # See also https://github.com/DSpace/dspace-angular/pull/3283#issuecomment-2372488489
-      - dependency-name: "webpack"
+      # 8.x cannot update sass to v1.100.0 or later as those versions do not support Node v18
+      - dependency-name: "sass"
+        versions: [">=1.100.0"]
       # Restrict zone.js updates to patch level to avoid dependency conflicts with @angular/core
       - dependency-name: "zone.js"
         update-types: ["version-update:semver-major", "version-update:semver-minor"]
@@ -397,10 +448,10 @@ updates:
       # Ignore all major version updates for all dependencies. We'll only automate minor/patch updates.
       - dependency-name: "*"
         update-types: ["version-update:semver-major"]
-  # Also automatically update all our GitHub actions on the dspace-7_x branch
+  # Also automatically update all our GitHub actions on the dspace-8_x branch
   - package-ecosystem: "github-actions"
     directory: "/"
-    target-branch: dspace-7_x
+    target-branch: dspace-8_x
     # Monthly dependency updates
     schedule:
       interval: "monthly"
@@ -409,3 +460,17 @@ updates:
     # some classes of supply chain attacks
     cooldown:
       default-days: 7
+    groups:
+      # Group together all GitHub official actions into a single PR
+      github-actions:
+        applies-to: version-updates
+        patterns:
+        - "actions/*"
+        - "github/*"
+    ignore:
+      # For official GitHub actions, ignore minor & patch releases because we reference these actions
+      # via a major version tag which automatically uses the latest minor/patch version (e.g. "actions/checkout@v6")
+      - dependency-name: "actions/*"
+        update-types: [ "version-update:semver-minor", "version-update:semver-patch"]
+      - dependency-name: "github/*"
+        update-types: [ "version-update:semver-minor", "version-update:semver-patch"]

.github/workflows/build.yml

@@ -40,8 +40,11 @@ jobs:
       # Project name to use when running "docker compose" prior to e2e tests
       COMPOSE_PROJECT_NAME: 'ci'
       # Docker Registry to use for Docker compose scripts below.
-      # We use GitHub's Container Registry to avoid aggressive rate limits at DockerHub.
-      DOCKER_REGISTRY: ghcr.io
+      # On the upstream dspace/dspace-angular repository we use GitHub's Container Registry
+      # (ghcr.io) to avoid aggressive rate limits at DockerHub. Forks cannot authenticate
+      # against ghcr.io/dspace/* with their own GITHUB_TOKEN (and the images there require
+      # auth), so on forks we fall back to docker.io where the same images are public.
+      DOCKER_REGISTRY: ${{ github.repository == 'dspace/dspace-angular' && 'ghcr.io' || 'docker.io' }}
     strategy:
       # Create a matrix of Node versions to test against (in parallel)
       matrix:
@@ -121,9 +124,14 @@ jobs:
           path: 'coverage/dspace-angular/lcov.info'
           retention-days: 14
 
-      # Login to our Docker registry, so that we can access private Docker images using "docker compose" below.
+      # Login to our Docker registry, so that we can access Docker images using "docker compose" below.
+      # This login is required on the upstream repository because DOCKER_REGISTRY is set to ghcr.io
+      # and pulling ghcr.io/dspace/* requires authentication. On forks, DOCKER_REGISTRY falls back to
+      # docker.io (see env block above) where the same images are publicly pullable without a login,
+      # and forks cannot authenticate against ghcr.io/dspace/* with their own GITHUB_TOKEN anyway.
       - name: Login to ${{ env.DOCKER_REGISTRY }}
         uses: docker/login-action@v4
+        if: github.repository == 'dspace/dspace-angular'
         with:
           registry: ${{ env.DOCKER_REGISTRY }}
           username: ${{ github.repository_owner }}
@@ -141,7 +149,7 @@ jobs:
       # https://github.com/cypress-io/github-action
       # (NOTE: to run these e2e tests locally, just use 'ng e2e')
       - name: Run e2e tests (integration tests)
-        uses: cypress-io/github-action@v7.1.9
+        uses: cypress-io/github-action@v7.4.0
         with:
           # Run tests in Chrome, headless mode (default)
           browser: chrome
@@ -314,6 +322,9 @@ jobs:
   codecov:
     # Must run after 'tests' job above
     needs: tests
+    # Only run on the upstream repository: forks do not have the CODECOV_TOKEN secret,
+    # and Codecov refuses to create a commit on a protected branch without a token.
+    if: github.repository == 'dspace/dspace-angular'
     runs-on: ubuntu-latest
     steps:
       - name: Checkout

.github/workflows/issue_opened.yml

@@ -16,7 +16,7 @@ jobs:
       # Only add to project board if issue is flagged as "needs triage" or has no labels
       # NOTE: By default we flag new issues as "needs triage" in our issue template
       if: (contains(github.event.issue.labels.*.name, 'needs triage') || join(github.event.issue.labels.*.name) == '')
-      uses: actions/add-to-project@v1.0.2
+      uses: actions/add-to-project@v2
       # Note, the authentication token below is an ORG level Secret. 
       # It must be created/recreated manually via a personal access token with admin:org, project, public_repo permissions
       # See: https://docs.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token#permissions-for-the-github_token

.github/workflows/pull_request_opened.yml

@@ -21,4 +21,4 @@ jobs:
     # Assign the PR to whomever created it. This is useful for visualizing assignments on project boards
     # See https://github.com/toshimaru/auto-author-assign
     - name: Assign PR to creator
-      uses: toshimaru/auto-author-assign@v3.0.1
+      uses: toshimaru/auto-author-assign@v3.0.2

config/config.example.yml

@@ -798,7 +798,7 @@ addToAnyPlugin:
   # 3. You will get a HTML e.g. <a class="a2a_button_facebook"></a> where "facebook" is part you want to include in list
   buttons:
     - facebook
-    - twitter
+    - x
     - linkedin
     - email
     - copy_link