Merge pull request DSpace#5002 from pzlakowski/fix/eperson-create-form-hangs-app

fix: fixes eperson create submission would hang application

Author: tdonohue

src/app/access-control/epeople-registry/epeople-registry.component.spec.ts

@@ -165,7 +165,7 @@ describe('EPeopleRegistryComponent', () => {
         { provide: AuthorizationDataService, useValue: authorizationService },
         { provide: FormBuilderService, useValue: builderService },
         { provide: Router, useValue: new RouterMock() },
-        { provide: RequestService, useValue: jasmine.createSpyObj('requestService', ['removeByHrefSubstring']) },
+        { provide: RequestService, useValue: jasmine.createSpyObj('requestService', ['setStaleByHrefSubstring']) },
         { provide: PaginationService, useValue: paginationService },
       ],
       schemas: [NO_ERRORS_SCHEMA],

src/app/core/eperson/eperson-data.service.spec.ts

@@ -1,8 +1,6 @@
 import { CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
 import {
-  fakeAsync,
   TestBed,
-  tick,
   waitForAsync,
 } from '@angular/core/testing';
 import { Store } from '@ngrx/store';
@@ -311,12 +309,12 @@ describe('EPersonDataService', () => {
         return of(`${restEndpointURL}/${linkPath}`);
       });
     });
-    it('should remove the eperson hrefs in the request service', fakeAsync(() => {
-      service.clearEPersonRequests();
-      tick();
-
-      expect(requestService.removeByHrefSubstring).toHaveBeenCalledWith(epersonsEndpoint);
-    }));
+    it('should remove the eperson hrefs in the request service', (done) => {
+      service.clearEPersonRequests().subscribe(() => {
+        expect(requestService.setStaleByHrefSubstring).toHaveBeenCalledWith(epersonsEndpoint);
+        done();
+      });
+    });
   });
 
   describe('deleteEPerson', () => {

src/app/core/eperson/eperson-data.service.ts

@@ -10,6 +10,7 @@ import {
   find,
   map,
   take,
+  tap,
 } from 'rxjs/operators';
 
 import { RemoteDataBuildService } from '../cache/builders/remote-data-build.service';
@@ -277,10 +278,10 @@ export class EPersonDataService extends IdentifiableDataService<EPerson> impleme
   /**
    * Method that clears a cached EPerson request
    */
-  public clearEPersonRequests(): void {
-    this.getBrowseEndpoint().pipe(take(1)).subscribe((link: string) => {
-      this.requestService.removeByHrefSubstring(link);
-    });
+  public clearEPersonRequests(): Observable<string> {
+    return this.getBrowseEndpoint().pipe(
+      tap((href: string) => this.requestService.setStaleByHrefSubstring(href)),
+    );
   }
 
   /**