[CST-2709] fix tests

Author: Andrea Barbasso

src/app/shared/menu/providers/admin-community-list.menu.spec.ts

@@ -11,6 +11,10 @@ import { TestBed } from '@angular/core/testing';
 import { MenuItemType } from '../menu-item-type.model';
 import { PartialMenuSection } from '../menu-provider.model';
 import { AdminCommunityListMenuProvider } from './admin-community-list.menu';
+import { APP_CONFIG } from '../../../../config/app-config.interface';
+import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
+import { of } from 'rxjs';
+import { AuthorizationDataServiceStub } from '../../testing/authorization-service.stub';
 
 describe('AdminCommunityListMenuProvider', () => {
   const expectedSections: PartialMenuSection[] = [
@@ -21,17 +25,23 @@ describe('AdminCommunityListMenuProvider', () => {
         text: `menu.section.communities_and_collections`,
         link: `/community-list`,
       },
-      icon: 'diagram-project',
+      icon: 'users',
     },
   ];
 
   let provider: AdminCommunityListMenuProvider;
+  let authorizationServiceStub = new AuthorizationDataServiceStub();
 
   beforeEach(() => {
+    spyOn(authorizationServiceStub, 'isAuthorized').and.returnValue(
+      of(true),
+    );
+
     TestBed.configureTestingModule({
       providers: [
         AdminCommunityListMenuProvider,
-      ],
+        { provide: APP_CONFIG, useValue: { layout: { navbar: { showCommunityCollection: false } } } },
+        { provide: AuthorizationDataService, useValue: authorizationServiceStub }, ],
     });
     provider = TestBed.inject(AdminCommunityListMenuProvider);
   });

src/app/shared/menu/providers/community-list.menu.spec.ts

@@ -11,6 +11,7 @@ import { TestBed } from '@angular/core/testing';
 import { MenuItemType } from '../menu-item-type.model';
 import { PartialMenuSection } from '../menu-provider.model';
 import { CommunityListMenuProvider } from './community-list.menu';
+import { APP_CONFIG } from '../../../../config/app-config.interface';
 
 describe('CommunityListMenuProvider', () => {
   const expectedSections: PartialMenuSection[] = [
@@ -31,6 +32,7 @@ describe('CommunityListMenuProvider', () => {
     TestBed.configureTestingModule({
       providers: [
         CommunityListMenuProvider,
+        { provide: APP_CONFIG, useValue: { layout: { navbar: { showCommunityCollection: true } } } },
       ],
     });
     provider = TestBed.inject(CommunityListMenuProvider);

src/app/shared/menu/providers/statistics.menu.spec.ts

@@ -3,74 +3,12 @@ import { TranslateModule } from '@ngx-translate/core';
 import { of } from 'rxjs';
 
 import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
-import { Item } from '../../../core/shared/item.model';
-import { ITEM } from '../../../core/shared/item.resource-type';
-import { createSuccessfulRemoteDataObject } from '../../remote-data.utils';
-import { MenuItemType } from '../menu-item-type.model';
-import { PartialMenuSection } from '../menu-provider.model';
 import { StatisticsMenuProvider } from './statistics.menu';
+import { ActivatedRoute } from '@angular/router';
+import { ActivatedRouteStub } from '../../testing/active-router.stub';
 
 describe('StatisticsMenuProvider', () => {
-
-  const expectedSectionsNoDSO: PartialMenuSection[] = [
-    {
-      visible: true,
-      model: {
-        type: MenuItemType.LINK,
-        text: 'menu.section.statistics',
-        link: `statistics`,
-      },
-      icon: 'chart-line',
-    },
-  ];
-
-  const expectedSectionsForItem: PartialMenuSection[] = [
-    {
-      visible: true,
-      model: {
-        type: MenuItemType.LINK,
-        text: 'menu.section.statistics',
-        link: `statistics/items/test-item-uuid`,
-      },
-      icon: 'chart-line',
-    },
-  ];
-
-  const expectedSectionsForItemInvisible: PartialMenuSection[] = [
-    {
-      visible: false,
-      model: {
-        type: MenuItemType.LINK,
-        text: 'menu.section.statistics',
-        link: `statistics/items/test-item-uuid`,
-      },
-      icon: 'chart-line',
-    },
-  ];
-
   let provider: StatisticsMenuProvider;
-
-  const item: Item = Object.assign(new Item(), {
-    uuid: 'test-item-uuid',
-    type: ITEM.value,
-    _links: { self: { href: 'self-link' } },
-    metadata: {
-      'dc.title': [{
-        'value': 'Untyped Item',
-      }],
-    },
-  });
-
-  const item2: Item = Object.assign(new Item(), {
-    uuid: 'test-item2-uuid',
-    type: ITEM.value,
-    _links: { self: { href: 'self-link' } },
-    metadata: {
-      'dc.title': [{
-        'value': 'Untyped Item 2',
-      }],
-    },
-  });
   let authorizationService: AuthorizationDataService;
 
   beforeEach(() => {
@@ -83,6 +21,7 @@ describe('StatisticsMenuProvider', () => {
       providers: [
         StatisticsMenuProvider,
         { provide: AuthorizationDataService, useValue: authorizationService },
+        { provide: ActivatedRoute, useValue: new ActivatedRouteStub({}, { }) },
       ],
     });
     provider = TestBed.inject(StatisticsMenuProvider);
@@ -93,62 +32,21 @@ describe('StatisticsMenuProvider', () => {
   });
 
   describe('getSectionsForContext', () => {
-    it('should return the general statistics link when no DSO is provided', (done) => {
+    it('should return menu entries when at least one authorization is granted', (done) => {
       provider.getSectionsForContext(undefined).subscribe((sections) => {
-        expect(sections).toEqual(expectedSectionsNoDSO);
-        done();
-      });
-    });
-    it('should return a statistics link to the DSO when a DSO is provided', (done) => {
-      provider.getSectionsForContext(item).subscribe((sections) => {
-        expect(sections).toEqual(expectedSectionsForItem);
-        done();
-      });
-    });
-    it('should not return anything if not authorized to view statistics', (done) => {
-      (TestBed.inject(AuthorizationDataService) as any).isAuthorized.and.returnValue(of(false));
-      provider.getSectionsForContext(item).subscribe((sections) => {
-        expect(sections).toEqual(expectedSectionsForItemInvisible);
-        done();
-      });
-    });
-  });
-
-  describe('getRouteContext', () => {
-    it('should get the dso from the route', (done) => {
-      const route = { data: { dso: createSuccessfulRemoteDataObject(item) } } as any;
-
-      provider.getRouteContext(route, undefined).subscribe((dso) => {
-        expect(dso).toEqual(item);
+        expect(Array.isArray(sections)).toBeTrue();
+        expect(sections.length).toBeGreaterThan(0);
+        expect(sections.some((s) => s.id === 'statistics')).toBeTrue();
         done();
       });
     });
-    it('should get the dso from first parent route with a dso when the route itself has none', (done) => {
-      const route = {
-        data: {},
-        parent: {
-          data: {},
-          parent: {
-            data: { dso: createSuccessfulRemoteDataObject(item) },
-            parent: { data: { dso: createSuccessfulRemoteDataObject(item2) } },
-          },
-        },
-      } as any;
 
-      provider.getRouteContext(route, undefined).subscribe((dso) => {
-        expect(dso).toEqual(item);
-        expect(dso).not.toEqual(item2);
-        done();
-      });
-    });
-    it('should return undefined when no dso is found in the route', (done) => {
-      const route = { data: {}, parent: { data: {}, parent: { data: {}, parent: { data: {} } } } } as any;
-
-      provider.getRouteContext(route, undefined).subscribe((dso) => {
-        expect(dso).toBeUndefined();
+    it('should return an empty array when no authorizations are granted', (done) => {
+      (TestBed.inject(AuthorizationDataService) as any).isAuthorized.and.returnValue(of(false));
+      provider.getSectionsForContext(undefined).subscribe((sections) => {
+        expect(sections).toEqual([]);
         done();
       });
     });
   });
-
 });

src/app/shared/menu/providers/statistics.menu.ts

@@ -52,7 +52,7 @@ export class StatisticsMenuProvider extends DSpaceObjectPageMenuProvider {
    *  Get activated route of the deepest activated route
    */
   getActivatedRoute(route) {
-    if (route.children.length > 0) {
+    if (route.children?.length > 0) {
       return this.getActivatedRoute(route.firstChild);
     } else {
       return route;
@@ -172,36 +172,6 @@ export class StatisticsMenuProvider extends DSpaceObjectPageMenuProvider {
     }));
   }
 
-  public getSectionsForContext2(dso: DSpaceObject): Observable<PartialMenuSection[]> {
-    return combineLatest([
-      this.authorizationService.isAuthorized(FeatureID.CanViewUsageStatistics, dso?._links.self.href),
-    ]).pipe(
-      map(([authorized]) => {
-        let link = `statistics`;
-
-        let dsoRoute;
-        if (hasValue(dso)) {
-          dsoRoute = getDSORoute(dso);
-          if (hasValue(dsoRoute)) {
-            link = `statistics${dsoRoute}`;
-          }
-        }
-
-        return [
-          {
-            visible: authorized,
-            model: {
-              type: MenuItemType.LINK,
-              text: 'menu.section.statistics',
-              link,
-            },
-            icon: 'chart-line',
-          },
-        ];
-      }),
-    );
-  }
-
   protected isApplicable(dso: DSpaceObject): boolean {
     return true;
   }