[DSC-2635] fix tests

Author: Andrea Barbasso

src/app/core/auth/auth.effects.spec.ts

@@ -198,6 +198,7 @@ describe('AuthEffects', () => {
         const expected = cold('--b-', { b: new AuthenticatedErrorAction(new Error('Message Error test')) });
 
         expect(authEffects.authenticated$).toBeObservable(expected);
+        done();
       });
     });
 

src/app/core/breadcrumbs/dso-name.service.spec.ts

@@ -192,9 +192,9 @@ describe(`DSONameService`, () => {
     it(`should return 'person.familyName, person.givenName'`, () => {
       const result = (service as any).factories.Person(mockPersonWithTitle);
       expect(result).toBe('User Test');
-      expect(mockPersonWithTitle.firstMetadataValue).toHaveBeenCalledWith('person.familyName');
-      expect(mockPersonWithTitle.firstMetadataValue).toHaveBeenCalledWith('person.givenName');
-      expect(mockPersonWithTitle.firstMetadataValue).toHaveBeenCalledWith('dc.title');
+      expect(mockPersonWithTitle.firstMetadataValue).toHaveBeenCalledWith('person.familyName', undefined, undefined);
+      expect(mockPersonWithTitle.firstMetadataValue).toHaveBeenCalledWith('person.givenName', undefined, undefined);
+      expect(mockPersonWithTitle.firstMetadataValue).toHaveBeenCalledWith('dc.title', undefined, undefined);
     });
   });
 

src/app/core/metadata/head-tag.service.spec.ts

@@ -172,7 +172,7 @@ describe('HeadTagService', () => {
         },
       });
       tick();
-      expect(meta.addTag).toHaveBeenCalledWith({
+      expect(meta.updateTag).toHaveBeenCalledWith({
         name: 'robots',
         content: 'noindex',
       });

src/app/core/shared/metadata.utils.spec.ts

@@ -54,7 +54,7 @@ const testMethod = (fn, resultKind, mapOrMaps, keyOrKeys, hitHighlights, expecte
   const keys = keyOrKeys instanceof Array ? keyOrKeys : [keyOrKeys];
   describe('and key' + (keys.length === 1 ? (' ' + keys[0]) : ('s ' + JSON.stringify(keys)))
     + ' with ' + (isUndefined(filter) ? 'no filter' : 'filter ' + JSON.stringify(filter)), () => {
-    const result = fn(mapOrMaps, keys, hitHighlights, filter, limit);
+      const result = fn(mapOrMaps, keys, hitHighlights, filter, undefined, limit);
     let shouldReturn;
     if (resultKind === 'boolean') {
       shouldReturn = expected;
@@ -306,7 +306,7 @@ describe('Metadata', () => {
 
   describe('all method with limit', () => {
     const testAllWithLimit = (mapOrMaps, keyOrKeys, expected, limit) =>
-      testMethod(Metadata.all, 'value', mapOrMaps, keyOrKeys, expected, undefined, limit);
+      testMethod(Metadata.all, 'value', mapOrMaps, keyOrKeys, undefined, expected, undefined, limit);
 
     describe('with multiMap and limit', () => {
       testAllWithLimit(multiMap, 'dc.title', [dcTitle1], 1);

src/app/core/shared/metadata.utils.ts

@@ -87,6 +87,9 @@ export class Metadata {
             } else {
               matches.push(candidate as MetadataValue);
             }
+            if (hasValue(limit) && matches.length >= limit) {
+              return matches;
+            }
           }
           }
         }

src/app/cris-layout/cris-layout-matrix/cris-layout-box-container/boxes/metadata/rendering-types/date/date.component.spec.ts

@@ -9,6 +9,7 @@ import {
   TranslateLoader,
   TranslateModule,
 } from '@ngx-translate/core';
+import { of } from 'rxjs';
 
 import { LayoutField } from '../../../../../../../core/layout/models/box.model';
 import { LocaleService } from '../../../../../../../core/locale/locale.service';
@@ -43,7 +44,7 @@ describe('DateComponent', () => {
   );
 
   const localeServiceMock = Object.assign({
-    getCurrentLanguageCode: () => 'en',
+    getCurrentLanguageCode: () => of('en'),
   });
 
   const mockField: LayoutField = {

src/app/cris-layout/pipes/ds-date.pipe.spec.ts

@@ -1,3 +1,5 @@
+import { of } from 'rxjs';
+
 import { DsDatePipe } from './ds-date.pipe';
 
 describe('DsDatePipe', () => {
@@ -8,7 +10,7 @@ describe('DsDatePipe', () => {
   });
 
   const localeServiceInstance = Object.assign({
-    getCurrentLanguageCode: () => 'en',
+    getCurrentLanguageCode: () => of('en'),
   });
 
   const date = '2020-08-24';

src/app/footer/footer.component.spec.ts

@@ -44,8 +44,8 @@ const siteService = jasmine.createSpyObj('siteService', {
   find: of(site),
 });
 const localeServiceStub = {
-  getCurrentLanguageCode(): string {
-    return 'en';
+  getCurrentLanguageCode() {
+    return of('en');
   },
 };
 

src/app/info/cms-info/cms-info.component.spec.ts

@@ -1,6 +1,8 @@
 import {
   ComponentFixture,
+  fakeAsync,
   TestBed,
+  tick,
 } from '@angular/core/testing';
 import { ActivatedRoute } from '@angular/router';
 import { Store } from '@ngrx/store';
@@ -54,8 +56,10 @@ describe('CmsInfoComponent', () => {
     redirectUrl = 'redirect/url';
     token = new AuthTokenInfo('eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9');
     authService = jasmine.createSpyObj('authService', {
-      isAuthenticated: observableOf(true),
+      isAuthenticated: observableOf(false),
+      isAuthenticationLoaded: observableOf(true),
       getToken: token,
+      getAuthenticatedUserFromStore: observableOf({}),
     });
     store = jasmine.createSpyObj('store', ['dispatch']);
     activatedRouteStub = {
@@ -95,20 +99,22 @@ describe('CmsInfoComponent', () => {
     expect(component).toBeTruthy();
   });
 
-  it('should set headLabel$ when data is successfully retrieved', () => {
+  it('should set headLabel$ when data is successfully retrieved', fakeAsync(() => {
     const headLabelSpy = spyOn(component.headLabel$, 'next');
 
     component.ngOnInit();
+    tick();
 
     expect(headLabelSpy).toHaveBeenCalledOnceWith('info.testQualifier.head');
-  });
+  }));
 
-  it('should log a warning to console if metadata content is missing', () => {
+  it('should log a warning to console if metadata content is missing', fakeAsync(() => {
     spyOn(console, 'warn');
     site.metadata['cris.cms.testQualifier'] = undefined;
 
     component.ngOnInit();
+    tick();
 
     expect(console.warn).toHaveBeenCalledWith('Metadata cris.cms.testQualifier has no content');
-  });
+  }));
 });

src/app/shared/explore/section-component/text-section/text-section.component.spec.ts

@@ -5,6 +5,8 @@ import {
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 
+import { of } from 'rxjs';
+
 import { LocaleService } from '../../../../core/locale/locale.service';
 import { SearchService } from '../../../../core/shared/search/search.service';
 import { Site } from '../../../../core/shared/site.model';
@@ -16,8 +18,8 @@ describe('TextSectionComponent', () => {
   let fixture: ComponentFixture<TextSectionComponent>;
 
   const localeServiceStub = {
-    getCurrentLanguageCode(): string {
-      return 'en';
+    getCurrentLanguageCode() {
+      return of('en');
     },
   };