[DSC-1504] Check 'audit.enabled' in CRIS context menu

Refs: DURACOM-317, DSC-1504

Author: kshepherd

src/app/shared/context-menu/audit-item/audit-item-menu.component.html

@@ -1,4 +1,4 @@
-@if ((isAuthorized$ | async)) {
+@if (showMenuItem$ | async) {
   <button class="dropdown-item"
     [innerHTML]="'context-menu.actions.audit-item.btn' | translate"
     [routerLink]="link">

src/app/shared/context-menu/audit-item/audit-item-menu.component.spec.ts

@@ -13,11 +13,14 @@ import { getTestScheduler } from 'jasmine-marbles';
 import { of } from 'rxjs';
 import { TestScheduler } from 'rxjs/testing';
 
+import { ConfigurationDataService } from '../../../core/data/configuration-data.service';
 import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
+import { ConfigurationProperty } from '../../../core/shared/configuration-property.model';
 import { DSpaceObject } from '../../../core/shared/dspace-object.model';
 import { DSpaceObjectType } from '../../../core/shared/dspace-object-type.model';
 import { Item } from '../../../core/shared/item.model';
 import { TranslateLoaderMock } from '../../mocks/translate-loader.mock';
+import { createSuccessfulRemoteDataObject$ } from '../../remote-data.utils';
 import { AuditItemMenuComponent } from './audit-item-menu.component';
 
 describe('AuditItemMenuComponent', () => {
@@ -31,6 +34,15 @@ describe('AuditItemMenuComponent', () => {
     isAuthorized: jasmine.createSpy('isAuthorized'),
   });
 
+  const configurationDataService = jasmine.createSpyObj('configurationDataService', {
+    findByPropertyName: createSuccessfulRemoteDataObject$(Object.assign(new ConfigurationProperty(), {
+      name: 'audit.enabled',
+      values: [
+        'true',
+      ],
+    })),
+  });
+
   beforeEach(waitForAsync(() => {
     dso = Object.assign(new Item(), {
       id: 'test-item',
@@ -54,6 +66,7 @@ describe('AuditItemMenuComponent', () => {
         { provide: 'contextMenuObjectProvider', useValue: dso },
         { provide: 'contextMenuObjectTypeProvider', useValue: DSpaceObjectType.ITEM },
         { provide: AuthorizationDataService, useValue: authorizationDataServiceStub },
+        { provide: ConfigurationDataService, useValue: configurationDataService },
       ],
     }).compileComponents();
   }));

src/app/shared/context-menu/audit-item/audit-item-menu.component.ts

@@ -7,16 +7,23 @@ import {
 import { RouterLink } from '@angular/router';
 import { TranslateModule } from '@ngx-translate/core';
 import {
-  BehaviorSubject,
   combineLatest,
+  Observable,
 } from 'rxjs';
-import { take } from 'rxjs/operators';
+import {
+  map,
+  startWith,
+} from 'rxjs/operators';
 
 import { getDSORoute } from '../../../app-routing-paths';
+import { ConfigurationDataService } from '../../../core/data/configuration-data.service';
 import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
 import { FeatureID } from '../../../core/data/feature-authorization/feature-id';
+import { RemoteData } from '../../../core/data/remote-data';
+import { ConfigurationProperty } from '../../../core/shared/configuration-property.model';
 import { DSpaceObject } from '../../../core/shared/dspace-object.model';
 import { DSpaceObjectType } from '../../../core/shared/dspace-object-type.model';
+import { getFirstCompletedRemoteData } from '../../../core/shared/operators';
 import { URLCombiner } from '../../../core/url-combiner/url-combiner';
 import { ContextMenuEntryComponent } from '../context-menu-entry.component';
 import { ContextMenuEntryType } from '../context-menu-entry-type';
@@ -35,31 +42,46 @@ import { ContextMenuEntryType } from '../context-menu-entry-type';
 })
 export class AuditItemMenuComponent extends ContextMenuEntryComponent implements OnInit {
 
-  public isAuthorized$: BehaviorSubject<boolean> =  new BehaviorSubject<boolean>(false);
+  public showMenuItem$: Observable<boolean>;
 
   constructor(
     @Inject('contextMenuObjectProvider') protected injectedContextMenuObject: DSpaceObject,
     @Inject('contextMenuObjectTypeProvider') protected injectedContextMenuObjectType: DSpaceObjectType,
     private authorizationService: AuthorizationDataService,
+    private configurationDataService: ConfigurationDataService,
   ) {
     super(injectedContextMenuObject, injectedContextMenuObjectType, ContextMenuEntryType.Audit);
   }
 
   ngOnInit(): void {
-    combineLatest(
+
+    const isEnabled$ = this.configurationDataService.findByPropertyName('audit.enabled').pipe(
+      getFirstCompletedRemoteData(),
+      map((response: RemoteData<ConfigurationProperty>) => this.isPropertyEnabled(response)),
+    );
+
+    const isAuthorized$ = combineLatest(
       [
         this.authorizationService.isAuthorized(FeatureID.AdministratorOf),
         this.authorizationService.isAuthorized(FeatureID.IsCollectionAdmin),
         this.authorizationService.isAuthorized(FeatureID.IsCommunityAdmin),
       ],
     ).pipe(
-      take(1),
-    ).subscribe(([isAdmin, isCollectionAdmin, isCommunityAdmin]) => {
-      this.isAuthorized$.next(isAdmin || isCommunityAdmin || isCollectionAdmin);
-    });
+      map(([isAdmin, isCollectionAdmin, isCommunityAdmin]) => isAdmin || isCollectionAdmin || isCommunityAdmin),
+    );
+
+    this.showMenuItem$ = combineLatest([isEnabled$, isAuthorized$]).pipe(
+      map(([isEnabled, isAuthorized]) => isAuthorized && isEnabled),
+      startWith(false),
+    );
   }
 
   get link() {
     return new URLCombiner(getDSORoute(this.contextMenuObject), 'auditlogs').toString();
   }
+
+  private isPropertyEnabled(property:  RemoteData<ConfigurationProperty>): boolean {
+    return property.hasSucceeded ? (property.payload.values.length > 0 && property.payload.values[0] === 'true') : false;
+  }
+
 }