[CST-2709] fix lint

Author: Andrea Barbasso

src/app/app.menus.ts

@@ -9,6 +9,7 @@ import { buildMenuStructure } from './shared/menu/menu.structure';
 import { MenuID } from './shared/menu/menu-id.model';
 import { MenuRoute } from './shared/menu/menu-route.model';
 import { AccessControlMenuProvider } from './shared/menu/providers/access-control.menu';
+import { AdminCommunityListMenuProvider } from './shared/menu/providers/admin-community-list.menu';
 import { AdminSearchMenuProvider } from './shared/menu/providers/admin-search.menu';
 import { CoarNotifyMenuProvider } from './shared/menu/providers/coar-notify.menu';
 import { SubscribeMenuProvider } from './shared/menu/providers/comcol-subscribe.menu';
@@ -35,7 +36,6 @@ import { SystemWideAlertMenuProvider } from './shared/menu/providers/system-wide
 import { UserAgreementMenuProvider } from './shared/menu/providers/user-agreement.menu';
 import { WithdrawnReinstateItemMenuProvider } from './shared/menu/providers/withdrawn-reinstate-item.menu';
 import { WorkflowMenuProvider } from './shared/menu/providers/workflow.menu';
-import { AdminCommunityListMenuProvider } from './shared/menu/providers/admin-community-list.menu';
 
 /**
  * Represents and builds the menu structure for the three available menus (public navbar, admin sidebar and the dso edit

src/app/shared/menu/providers/admin-community-list.menu.spec.ts

@@ -7,14 +7,14 @@
  */
 
 import { TestBed } from '@angular/core/testing';
+import { of } from 'rxjs';
 
-import { MenuItemType } from '../menu-item-type.model';
-import { PartialMenuSection } from '../menu-provider.model';
-import { AdminCommunityListMenuProvider } from './admin-community-list.menu';
 import { APP_CONFIG } from '../../../../config/app-config.interface';
 import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
-import { of } from 'rxjs';
 import { AuthorizationDataServiceStub } from '../../testing/authorization-service.stub';
+import { MenuItemType } from '../menu-item-type.model';
+import { PartialMenuSection } from '../menu-provider.model';
+import { AdminCommunityListMenuProvider } from './admin-community-list.menu';
 
 describe('AdminCommunityListMenuProvider', () => {
   const expectedSections: PartialMenuSection[] = [
@@ -41,7 +41,7 @@ describe('AdminCommunityListMenuProvider', () => {
       providers: [
         AdminCommunityListMenuProvider,
         { provide: APP_CONFIG, useValue: { layout: { navbar: { showCommunityCollection: false } } } },
-        { provide: AuthorizationDataService, useValue: authorizationServiceStub }, ],
+        { provide: AuthorizationDataService, useValue: authorizationServiceStub } ],
     });
     provider = TestBed.inject(AdminCommunityListMenuProvider);
   });

src/app/shared/menu/providers/admin-community-list.menu.ts

@@ -6,21 +6,24 @@
  * http://www.dspace.org/license/
  */
 
-import { inject, Injectable } from '@angular/core';
+import {
+  inject,
+  Injectable,
+} from '@angular/core';
 import {
   map,
   Observable,
   of,
 } from 'rxjs';
 
+import { APP_CONFIG } from '../../../../config/app-config.interface';
+import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
+import { FeatureID } from '../../../core/data/feature-authorization/feature-id';
 import { MenuItemType } from '../menu-item-type.model';
 import {
   AbstractMenuProvider,
   PartialMenuSection,
 } from '../menu-provider.model';
-import { APP_CONFIG } from '../../../../config/app-config.interface';
-import { FeatureID } from '../../../core/data/feature-authorization/feature-id';
-import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
 
 /**
  * Menu provider to create the "Communities & Collections" menu section in the admin navbar

src/app/shared/menu/providers/community-list.menu.spec.ts

@@ -8,10 +8,10 @@
 
 import { TestBed } from '@angular/core/testing';
 
+import { APP_CONFIG } from '../../../../config/app-config.interface';
 import { MenuItemType } from '../menu-item-type.model';
 import { PartialMenuSection } from '../menu-provider.model';
 import { CommunityListMenuProvider } from './community-list.menu';
-import { APP_CONFIG } from '../../../../config/app-config.interface';
 
 describe('CommunityListMenuProvider', () => {
   const expectedSections: PartialMenuSection[] = [

src/app/shared/menu/providers/community-list.menu.ts

@@ -6,18 +6,21 @@
  * http://www.dspace.org/license/
  */
 
-import { inject, Injectable } from '@angular/core';
+import {
+  inject,
+  Injectable,
+} from '@angular/core';
 import {
   Observable,
   of,
 } from 'rxjs';
 
+import { APP_CONFIG } from '../../../../config/app-config.interface';
 import { MenuItemType } from '../menu-item-type.model';
 import {
   AbstractMenuProvider,
   PartialMenuSection,
 } from '../menu-provider.model';
-import { APP_CONFIG } from '../../../../config/app-config.interface';
 
 /**
  * Menu provider to create the "Communities & Collections" menu section in the public navbar

src/app/shared/menu/providers/statistics.menu.spec.ts

@@ -1,11 +1,11 @@
 import { TestBed } from '@angular/core/testing';
+import { ActivatedRoute } from '@angular/router';
 import { TranslateModule } from '@ngx-translate/core';
 import { of } from 'rxjs';
 
 import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
-import { StatisticsMenuProvider } from './statistics.menu';
-import { ActivatedRoute } from '@angular/router';
 import { ActivatedRouteStub } from '../../testing/active-router.stub';
+import { StatisticsMenuProvider } from './statistics.menu';
 
 describe('StatisticsMenuProvider', () => {
   let provider: StatisticsMenuProvider;

src/app/shared/menu/providers/statistics.menu.ts

@@ -7,22 +7,23 @@
  */
 
 import { Injectable } from '@angular/core';
+import { ActivatedRoute } from '@angular/router';
 import {
   combineLatest,
   map,
   Observable,
 } from 'rxjs';
+import {
+  switchMap,
+  take,
+} from 'rxjs/operators';
 
-import { getDSORoute } from '../../../app-routing-paths';
 import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
 import { FeatureID } from '../../../core/data/feature-authorization/feature-id';
 import { DSpaceObject } from '../../../core/shared/dspace-object.model';
-import { hasValue } from '../../empty.util';
 import { MenuItemType } from '../menu-item-type.model';
 import { PartialMenuSection } from '../menu-provider.model';
 import { DSpaceObjectPageMenuProvider } from './helper-providers/dso.menu';
-import { switchMap, take } from 'rxjs/operators';
-import { ActivatedRoute } from '@angular/router';
 
 /**
  * Menu provider to create the "Statistics" menu section in the public navbar. The menu depends on the page it is on.
@@ -35,7 +36,7 @@ export class StatisticsMenuProvider extends DSpaceObjectPageMenuProvider {
 
   constructor(
     protected authorizationService: AuthorizationDataService,
-    protected route: ActivatedRoute
+    protected route: ActivatedRoute,
   ) {
     super();
   }
@@ -109,67 +110,67 @@ export class StatisticsMenuProvider extends DSpaceObjectPageMenuProvider {
       canViewWorkflow: this.getAuthorizedWorkflowStatistics(),
     }).pipe(
       take(1),
-      map(({canViewUsage, canViewLogin, canViewWorkflow}) => {
-      const menuList = [];
-      if (canViewUsage || canViewLogin || canViewWorkflow) {
-        if (canViewUsage) {
-          menuList.push({
-            id: 'statistics_site',
-            parentID: 'statistics',
-            active: false,
-            visible: true,
-            model: {
-              type: MenuItemType.LINK,
-              text: 'menu.section.statistics.site',
-              link: '/statistics',
-            },
-          });
-        }
+      map(({ canViewUsage, canViewLogin, canViewWorkflow }) => {
+        const menuList = [];
+        if (canViewUsage || canViewLogin || canViewWorkflow) {
+          if (canViewUsage) {
+            menuList.push({
+              id: 'statistics_site',
+              parentID: 'statistics',
+              active: false,
+              visible: true,
+              model: {
+                type: MenuItemType.LINK,
+                text: 'menu.section.statistics.site',
+                link: '/statistics',
+              },
+            });
+          }
 
-        if (canViewLogin) {
-          menuList.push({
-            id: 'statistics_login',
-            parentID: 'statistics',
-            active: false,
-            visible: true,
-            model: {
-              type: MenuItemType.LINK,
-              text: 'menu.section.statistics.login',
-              link: '/statistics/login',
-            },
-          });
-        }
+          if (canViewLogin) {
+            menuList.push({
+              id: 'statistics_login',
+              parentID: 'statistics',
+              active: false,
+              visible: true,
+              model: {
+                type: MenuItemType.LINK,
+                text: 'menu.section.statistics.login',
+                link: '/statistics/login',
+              },
+            });
+          }
 
-        if (canViewWorkflow) {
-          menuList.push({
-            id: 'statistics_workflow',
-            parentID: 'statistics',
-            active: false,
-            visible: true,
-            model: {
-              type: MenuItemType.LINK,
-              text: 'menu.section.statistics.workflow',
-              link: '/statistics/workflow',
-            },
-          });
-        }
+          if (canViewWorkflow) {
+            menuList.push({
+              id: 'statistics_workflow',
+              parentID: 'statistics',
+              active: false,
+              visible: true,
+              model: {
+                type: MenuItemType.LINK,
+                text: 'menu.section.statistics.workflow',
+                link: '/statistics/workflow',
+              },
+            });
+          }
 
-        // the parent menu should be added after the children
-        menuList.push(
-          {
-            id: 'statistics',
-            active: false,
-            visible: true,
-            index: 1,
-            model: {
-              type: MenuItemType.TEXT,
-              text: 'menu.section.statistics',
+          // the parent menu should be added after the children
+          menuList.push(
+            {
+              id: 'statistics',
+              active: false,
+              visible: true,
+              index: 1,
+              model: {
+                type: MenuItemType.TEXT,
+                text: 'menu.section.statistics',
+              },
             },
-          },
-        );
-      }
-      return menuList;
-    }));
+          );
+        }
+        return menuList;
+      }));
   }
 
   protected isApplicable(dso: DSpaceObject): boolean {