Merged in task/dspace-cris-2024_02_x/DSC-1857 (pull request DSpace#4725)

[DSC-1857] replace script find one with new auth feature

Approved-by: Andrea Barbasso

Author: FrancescoMolinaro

src/app/core/data/feature-authorization/feature-id.ts

@@ -42,4 +42,6 @@ export enum FeatureID {
   ShowClaimItem = 'showClaimItem',
   CanCorrectItem = 'canCorrectItem',
   CanViewInWorkflowSinceStatistics = 'canViewInWorkflowSinceStatistics',
+  CanExportMetadata = 'canExportMetadata',
+  CanImportMetadata = 'canImportMetadata',
 }

src/app/menu-resolver.service.ts

@@ -31,11 +31,6 @@ import { ConfigurationDataService } from './core/data/configuration-data.service
 import { AuthorizationDataService } from './core/data/feature-authorization/authorization-data.service';
 import { FeatureID } from './core/data/feature-authorization/feature-id';
 import { PaginatedList } from './core/data/paginated-list.model';
-import {
-  METADATA_EXPORT_SCRIPT_NAME,
-  METADATA_IMPORT_SCRIPT_NAME,
-  ScriptDataService,
-} from './core/data/processes/script-data.service';
 import { RemoteData } from './core/data/remote-data';
 import { Section } from './core/layout/models/section.model';
 import { SectionDataService } from './core/layout/section-data.service';
@@ -77,7 +72,6 @@ export class MenuResolverService  {
     protected menuService: MenuService,
     protected authorizationService: AuthorizationDataService,
     protected modalService: NgbModal,
-    protected scriptDataService: ScriptDataService,
     protected configurationDataService: ConfigurationDataService,
     protected authService: AuthService,
     protected sectionDataService: SectionDataService,
@@ -650,17 +644,8 @@ export class MenuResolverService  {
     ];
     menuList.forEach((menuSection) => this.menuService.addSection(MenuID.ADMIN, menuSection));
 
-    observableCombineLatest([
-      this.authorizationService.isAuthorized(FeatureID.AdministratorOf),
-      this.authorizationService.isAuthorized(FeatureID.IsCommunityAdmin),
-      this.authorizationService.isAuthorized(FeatureID.IsCollectionAdmin),
-    ]).pipe(
-      filter(([isAdmin, isCommunityAdmin, isCollectionAdmin]) =>
-        isAdmin || isCollectionAdmin || isCommunityAdmin,
-      ),
-      take(1),
-      switchMap(() => this.scriptDataService.scriptWithNameExistsAndCanExecute(METADATA_EXPORT_SCRIPT_NAME)),
-      filter((metadataExportScriptExists: boolean) => metadataExportScriptExists),
+    this.authorizationService.isAuthorized(FeatureID.CanExportMetadata).pipe(
+      filter((canExport) => canExport),
       take(1),
     ).subscribe(() => {
       // Hides the export menu for unauthorised people
@@ -783,17 +768,8 @@ export class MenuResolverService  {
     const menuList = [];
     menuList.forEach((menuSection) => this.menuService.addSection(MenuID.ADMIN, menuSection));
 
-    observableCombineLatest([
-      this.authorizationService.isAuthorized(FeatureID.AdministratorOf),
-      this.authorizationService.isAuthorized(FeatureID.IsCommunityAdmin),
-      this.authorizationService.isAuthorized(FeatureID.IsCollectionAdmin),
-    ]).pipe(
-      filter(([isAdmin, isCommunityAdmin, isCollectionAdmin]) =>
-        isAdmin || isCollectionAdmin || isCommunityAdmin,
-      ),
-      take(1),
-      switchMap(() => this.scriptDataService.scriptWithNameExistsAndCanExecute(METADATA_IMPORT_SCRIPT_NAME)),
-      filter((metadataImportScriptExists: boolean) => metadataImportScriptExists),
+    this.authorizationService.isAuthorized(FeatureID.CanImportMetadata).pipe(
+      filter((canImport) => canImport),
       take(1),
     ).subscribe(() => {
       // Hides the import menu for unauthorised people

src/app/menu.resolver.spec.ts

@@ -17,7 +17,6 @@ import { AdminSidebarComponent } from './admin/admin-sidebar/admin-sidebar.compo
 import { ConfigurationDataService } from './core/data/configuration-data.service';
 import { AuthorizationDataService } from './core/data/feature-authorization/authorization-data.service';
 import { FeatureID } from './core/data/feature-authorization/feature-id';
-import { ScriptDataService } from './core/data/processes/script-data.service';
 import { SectionDataService } from './core/layout/section-data.service';
 import { MenuService } from './shared/menu/menu.service';
 import { MenuID } from './shared/menu/menu-id.model';
@@ -76,7 +75,6 @@ describe('menuResolver', () => {
   let menuService;
   let sectionsService;
   let authorizationService;
-  let scriptService;
   let mockNgbModal;
   let configurationDataService;
 
@@ -91,9 +89,7 @@ describe('menuResolver', () => {
     authorizationService = jasmine.createSpyObj('authorizationService', {
       isAuthorized: observableOf(true),
     });
-    scriptService = jasmine.createSpyObj('scriptService', {
-      scriptWithNameExistsAndCanExecute: observableOf(true),
-    });
+
     mockNgbModal = {
       open: jasmine.createSpy('open').and.returnValue(
         { componentInstance: {}, closed: observableOf({}) } as NgbModalRef,
@@ -109,7 +105,6 @@ describe('menuResolver', () => {
         { provide: MenuService, useValue: menuService },
         { provide: SectionDataService, useValue: sectionsService },
         { provide: AuthorizationDataService, useValue: authorizationService },
-        { provide: ScriptDataService, useValue: scriptService },
         { provide: ConfigurationDataService, useValue: configurationDataService },
         { provide: NgbModal, useValue: mockNgbModal },
         { provide: AuthService, useValue: AuthServiceStub },
@@ -419,7 +414,7 @@ describe('menuResolver', () => {
     describe('for site admin', () => {
       beforeEach(() => {
         authorizationService.isAuthorized = createSpy('isAuthorized').and.callFake((featureID: FeatureID) => {
-          return observableOf(featureID === FeatureID.AdministratorOf);
+          return observableOf(featureID === FeatureID.AdministratorOf || featureID === FeatureID.CanExportMetadata || featureID === FeatureID.CanImportMetadata);
         });
       });
 

src/config/default-app-config.ts

@@ -177,6 +177,8 @@ export class DefaultAppConfig implements AppConfig {
     FeatureID.CanSubmit,
     FeatureID.CoarNotifyEnabled,
     FeatureID.CanSeeQA,
+    FeatureID.CanExportMetadata,
+    FeatureID.CanImportMetadata,
   ];
 
   discoveryAuthorizationFeaturesConfig: DiscoveryConfigurationFeaturesConfig = {