Geospatial maps: Test fixes

Including reverting a nice-to-have improvement
to 'hasNoContent' for field wrapper and non-text
content.

Author: kshepherd

src/app/browse-by/browse-by-geospatial-data/browse-by-geospatial-data.component.spec.ts

@@ -67,6 +67,7 @@ const mockPointValues = createSuccessfulRemoteDataObject$(buildPaginatedList(new
 const expectedSearchOptions: PaginatedSearchOptions = Object.assign({
   'configuration': environment.geospatialMapViewer.spatialFacetDiscoveryConfiguration,
   'scope': scope,
+  'facetLimit': 99999,
 });
 
 // Mock search config service returns mock search filter config on getConfig()

src/app/item-page/simple/field-components/specific-field/geospatial/geospatial-item-page-field.component.spec.ts

@@ -7,14 +7,20 @@ import {
   TestBed,
   waitForAsync,
 } from '@angular/core/testing';
+import { Store } from '@ngrx/store';
+import { MockStore } from '@ngrx/store/testing';
 import {
   TranslateLoader,
   TranslateModule,
 } from '@ngx-translate/core';
 
-import { APP_CONFIG } from '../../../../../../config/app-config.interface';
+import {
+  APP_CONFIG,
+  APP_DATA_SERVICES_MAP,
+} from '../../../../../../config/app-config.interface';
 import { environment } from '../../../../../../environments/environment';
 import { BrowseDefinitionDataService } from '../../../../../core/browse/browse-definition-data.service';
+import { ITEM } from '../../../../../core/shared/item.resource-type';
 import { BrowseDefinitionDataServiceStub } from '../../../../../shared/testing/browse-definition-data-service.stub';
 import { TranslateLoaderMock } from '../../../../../shared/testing/translate-loader.mock';
 import { MetadataValuesComponent } from '../../../../field-components/metadata-values/metadata-values.component';
@@ -29,6 +35,9 @@ const mockField = 'dcterms.spatial';
 const mockLabel = 'Test location';
 const mockFields = [mockField];
 
+const mockDataServiceMap: any = new Map([
+  [ITEM.value, () => import('../../../../../shared/testing/test-data-service.mock').then(m => m.TestDataService)],
+]);
 describe('GeospatialItemPageFieldComponent', () => {
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
@@ -41,6 +50,8 @@ describe('GeospatialItemPageFieldComponent', () => {
       providers: [
         { provide: APP_CONFIG, useValue: environment },
         { provide: BrowseDefinitionDataService, useValue: BrowseDefinitionDataServiceStub },
+        { provide: Store, useValue: MockStore },
+        { provide: APP_DATA_SERVICES_MAP, useValue: mockDataServiceMap },
       ],
       schemas: [NO_ERRORS_SCHEMA],
     }).overrideComponent(GeospatialItemPageFieldComponent, {

src/app/shared/metadata-field-wrapper/metadata-field-wrapper.component.html

@@ -1,8 +1,8 @@
-<div class="simple-view-element" [class.d-none]="hideIfNoTextContent && hasNoContent">
+<div class="simple-view-element" [class.d-none]="hideIfNoTextContent && content.textContent.trim().length === 0">
   @if (label) {
     <h2 class="simple-view-element-header">{{ label }}</h2>
-    <div #content class="simple-view-element-body">
-      <ng-content></ng-content>
-    </div>
   }
+  <div #content class="simple-view-element-body">
+    <ng-content></ng-content>
+  </div>
 </div>

src/app/shared/metadata-field-wrapper/metadata-field-wrapper.component.ts

@@ -1,9 +1,7 @@
 
 import {
   Component,
-  ElementRef,
   Input,
-  ViewChild,
 } from '@angular/core';
 
 /**
@@ -23,12 +21,6 @@ export class MetadataFieldWrapperComponent {
    * The label (title) for the content
    */
   @Input() label: string;
-  @ViewChild('content', { static: true }) contentElementRef: ElementRef;
 
   @Input() hideIfNoTextContent = true;
-
-  get hasNoContent(): boolean{
-    return this.contentElementRef.nativeElement.textContent.trim().length === 0
-    && this.contentElementRef.nativeElement.querySelector('img') === null;
-  }
 }