[CST-2709] fix comcol menu

Author: Andrea Barbasso

src/app/app.menus.ts

@@ -35,6 +35,7 @@ import { SystemWideAlertMenuProvider } from './shared/menu/providers/system-wide
 import { UserAgreementMenuProvider } from './shared/menu/providers/user-agreement.menu';
 import { WithdrawnReinstateItemMenuProvider } from './shared/menu/providers/withdrawn-reinstate-item.menu';
 import { WorkflowMenuProvider } from './shared/menu/providers/workflow.menu';
+import { AdminCommunityListMenuProvider } from './shared/menu/providers/admin-community-list.menu';
 
 /**
  * Represents and builds the menu structure for the three available menus (public navbar, admin sidebar and the dso edit
@@ -59,6 +60,7 @@ export const MENUS = buildMenuStructure({
     StatisticsMenuProvider,
   ],
   [MenuID.ADMIN]: [
+    AdminCommunityListMenuProvider,
     NewMenuProvider,
     EditMenuProvider,
     ImportMenuProvider,

src/app/shared/menu/providers/admin-community-list.menu.spec.ts

@@ -0,0 +1,49 @@
+/**
+ * The contents of this file are subject to the license and copyright
+ * detailed in the LICENSE and NOTICE files at the root of the source
+ * tree and available online at
+ *
+ * http://www.dspace.org/license/
+ */
+
+import { TestBed } from '@angular/core/testing';
+
+import { MenuItemType } from '../menu-item-type.model';
+import { PartialMenuSection } from '../menu-provider.model';
+import { AdminCommunityListMenuProvider } from './admin-community-list.menu';
+
+describe('AdminCommunityListMenuProvider', () => {
+  const expectedSections: PartialMenuSection[] = [
+    {
+      visible: true,
+      model: {
+        type: MenuItemType.LINK,
+        text: `menu.section.communities_and_collections`,
+        link: `/community-list`,
+      },
+      icon: 'diagram-project',
+    },
+  ];
+
+  let provider: AdminCommunityListMenuProvider;
+
+  beforeEach(() => {
+    TestBed.configureTestingModule({
+      providers: [
+        AdminCommunityListMenuProvider,
+      ],
+    });
+    provider = TestBed.inject(AdminCommunityListMenuProvider);
+  });
+
+  it('should be created', () => {
+    expect(provider).toBeTruthy();
+  });
+
+  it('getSections should return expected menu sections', (done) => {
+    provider.getSections().subscribe((sections) => {
+      expect(sections).toEqual(expectedSections);
+      done();
+    });
+  });
+});

src/app/shared/menu/providers/admin-community-list.menu.ts

@@ -0,0 +1,52 @@
+/**
+ * The contents of this file are subject to the license and copyright
+ * detailed in the LICENSE and NOTICE files at the root of the source
+ * tree and available online at
+ *
+ * http://www.dspace.org/license/
+ */
+
+import { inject, Injectable } from '@angular/core';
+import {
+  map,
+  Observable,
+  of,
+} from 'rxjs';
+
+import { MenuItemType } from '../menu-item-type.model';
+import {
+  AbstractMenuProvider,
+  PartialMenuSection,
+} from '../menu-provider.model';
+import { APP_CONFIG } from '../../../../config/app-config.interface';
+import { FeatureID } from '../../../core/data/feature-authorization/feature-id';
+import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
+
+/**
+ * Menu provider to create the "Communities & Collections" menu section in the admin navbar
+ */
+@Injectable()
+export class AdminCommunityListMenuProvider extends AbstractMenuProvider {
+
+  protected appConfig = inject(APP_CONFIG);
+  protected authorizationService = inject(AuthorizationDataService);
+
+  public getSections(): Observable<PartialMenuSection[]> {
+    if (this.appConfig.layout.navbar.showCommunityCollection) {
+      return of([]);
+    }
+    return this.authorizationService.isAuthorized(FeatureID.IsComColAdmin).pipe(
+      map(isComColAdmin => {
+        return [{
+          visible: isComColAdmin,
+          model: {
+            type: MenuItemType.LINK,
+            text: `menu.section.communities_and_collections`,
+            link: `/community-list`,
+          },
+          icon: 'users',
+        },
+        ] as PartialMenuSection[];
+      }));
+  }
+}

src/app/shared/menu/providers/community-list.menu.ts

@@ -6,7 +6,7 @@
  * http://www.dspace.org/license/
  */
 
-import { Injectable } from '@angular/core';
+import { inject, Injectable } from '@angular/core';
 import {
   Observable,
   of,
@@ -17,13 +17,20 @@ import {
   AbstractMenuProvider,
   PartialMenuSection,
 } from '../menu-provider.model';
+import { APP_CONFIG } from '../../../../config/app-config.interface';
 
 /**
  * Menu provider to create the "Communities & Collections" menu section in the public navbar
  */
 @Injectable()
 export class CommunityListMenuProvider extends AbstractMenuProvider {
+
+  protected appConfig = inject(APP_CONFIG);
   public getSections(): Observable<PartialMenuSection[]> {
+    if (!this.appConfig.layout.navbar.showCommunityCollection) {
+      return of([]);
+    }
+
     return of([
       {
         visible: true,