Skip to content

Commit 7afe49d

Browse files
117287: Fixed various layout issues
- The unthemed home news didn't stick to the header like the dspace theme - Impersonate user button has additional margin - Submission form loading icon is not translatable - Create resource policy page doesn't have the correct heading (cherry picked from commit 56e45a9)
1 parent c89ad9f commit 7afe49d

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

src/app/shared/resource-policies/create/resource-policy-create.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="container">
2-
<h4 class="mb-3">{{'resource-policies.create.page.heading' | translate}} {{targetResourceName}}</h4>
2+
<h1 class="mb-3">{{'resource-policies.create.page.heading' | translate}} {{targetResourceName}}</h1>
33

44
<ds-resource-policy-form [isProcessing]="isProcessing()"
55
(reset)="redirectToAuthorizationsPage()"

src/app/submission/form/submission-form.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
</div>
2727

2828
<div class="submission-form-content">
29-
<ds-themed-loading *ngIf="(isLoading$ | async) === true" message="Loading..."></ds-themed-loading>
29+
<ds-themed-loading *ngIf="(isLoading$ | async) === true" [message]="'form.loading' | translate"></ds-themed-loading>
3030
<ng-container *ngFor="let object of (submissionSections | async)">
3131
<ds-submission-section-container [collectionId]="collectionId"
3232
[submissionId]="submissionId"

src/app/submission/form/submission-form.component.spec.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ChangeDetectorRef, Component, NO_ERRORS_SCHEMA, SimpleChange } from '@angular/core';
1+
import { ChangeDetectorRef, Component, SimpleChange } from '@angular/core';
22
import { ComponentFixture, inject, TestBed, waitForAsync } from '@angular/core/testing';
33

44
import { of as observableOf } from 'rxjs';
@@ -26,6 +26,7 @@ import { Item } from '../../core/shared/item.model';
2626
import { TestScheduler } from 'rxjs/testing';
2727
import { SectionsService } from '../sections/sections.service';
2828
import { VisibilityType } from '../sections/visibility-type';
29+
import { TranslateModule } from '@ngx-translate/core';
2930

3031
describe('SubmissionFormComponent', () => {
3132

@@ -47,7 +48,9 @@ describe('SubmissionFormComponent', () => {
4748

4849
beforeEach(waitForAsync(() => {
4950
TestBed.configureTestingModule({
50-
imports: [],
51+
imports: [
52+
TranslateModule.forRoot(),
53+
],
5154
declarations: [
5255
SubmissionFormComponent,
5356
TestComponent
@@ -60,7 +63,6 @@ describe('SubmissionFormComponent', () => {
6063
ChangeDetectorRef,
6164
SubmissionFormComponent
6265
],
63-
schemas: [NO_ERRORS_SCHEMA]
6466
}).compileComponents();
6567
}));
6668

0 commit comments

Comments
 (0)