fix: prevent button label flicker when opening subscription modal - 4195

Author: guillermo-escire

cypress/e2e/collection-statistics.cy.ts

@@ -4,8 +4,8 @@ import { testA11y } from 'cypress/support/utils';
 describe('Collection Statistics Page', () => {
   const COLLECTIONSTATISTICSPAGE = '/statistics/collections/'.concat(Cypress.env('DSPACE_TEST_COLLECTION'));
 
-  it.skip('should load if you click on "Statistics" from a Community page', () => {
-    cy.visit('/communities/'.concat(Cypress.env('DSPACE_TEST_COMMUNITY')));
+  it('should load if you click on "Statistics" from a Collection page', () => {
+    cy.visit('/collections/'.concat(Cypress.env('DSPACE_TEST_COLLECTION')));
     cy.get('ds-navbar ds-link-menu-item a[data-test="link-menu-item.menu.section.statistics"]').click();
     cy.location('pathname').should('eq', COLLECTIONSTATISTICSPAGE);
   });

cypress/e2e/community-statistics.cy.ts

@@ -4,7 +4,7 @@ import { testA11y } from 'cypress/support/utils';
 describe('Community Statistics Page', () => {
   const COMMUNITYSTATISTICSPAGE = '/statistics/communities/'.concat(Cypress.env('DSPACE_TEST_COMMUNITY'));
 
-  it.skip('should load if you click on "Statistics" from a Community page', () => {
+  it('should load if you click on "Statistics" from a Community page', () => {
     cy.visit('/communities/'.concat(Cypress.env('DSPACE_TEST_COMMUNITY')));
     cy.get('ds-navbar ds-link-menu-item a[data-test="link-menu-item.menu.section.statistics"]').click();
     cy.location('pathname').should('eq', COMMUNITYSTATISTICSPAGE);

src/app/shared/menu/providers/comcol-subscribe.menu.ts

@@ -35,7 +35,6 @@ import { DSpaceObjectPageMenuProvider } from './helper-providers/dso.menu';
  */
 @Injectable()
 export class SubscribeMenuProvider extends DSpaceObjectPageMenuProvider {
-
   private refresh$ = new Subject<void>();
 
   constructor(
@@ -50,7 +49,7 @@ export class SubscribeMenuProvider extends DSpaceObjectPageMenuProvider {
 
   public getSectionsForContext(dso: DSpaceObject): Observable<PartialMenuSection[]> {
     return this.refresh$.pipe(
-      startWith(undefined),
+      startWith(undefined), // Disparamos siempre al inicio
       switchMap(() =>
         combineLatest([
           this.authorizationService.isAuthorized(FeatureID.CanSubscribe, dso.self),
@@ -72,19 +71,13 @@ export class SubscribeMenuProvider extends DSpaceObjectPageMenuProvider {
                   type: MenuItemType.ONCLICK,
                   text: key,
                   function: () => {
-                    if (isSubscribed) {
-                      this.subscriptionService.deleteSubscription(subscription.id).subscribe(() => {
-                        this.refresh$.next();
-                      });
-                    } else {
-                      const modalRef = this.modalService.open(SubscriptionModalComponent);
-                      modalRef.componentInstance.dso = dso;
-                      modalRef.componentInstance.updated.subscribe(() => {
-                        this.refresh$.next();
-                      });
-                      modalRef.closed.subscribe(() => {
-                      });
-                    }
+                    const modalRef = this.modalService.open(SubscriptionModalComponent);
+                    modalRef.componentInstance.dso = dso;
+                    modalRef.componentInstance.updated.subscribe(() => {
+                      this.refresh$.next();
+                    });
+                    modalRef.closed.subscribe(() => {
+                    });
                   },
                 } as OnClickMenuItemModel,
                 icon: 'bell',