[DSC-1875] Improve test in order to avoid random failures

Author: atarix83

src/app/lucky-search/search/lucky-search.component.spec.ts

@@ -78,7 +78,7 @@ describe('LuckySearchComponent', () => {
     index: 'test',
     'value': 'test'
   };
-  const routerStub = new RouterMock();
+  let routerStub = new RouterMock();
 
   const bitstreamMetadata = {
     'dc.title': [{value: 'test.pdf'} as MetadataValue],
@@ -106,10 +106,8 @@ describe('LuckySearchComponent', () => {
       .compileComponents();
   });
 
-  beforeEach(() => {
-    fixture = TestBed.createComponent(LuckySearchComponent);
-    component = fixture.componentInstance;
-    fixture.detectChanges();
+  afterEach(() => {
+    routerStub = new RouterMock();
   });
 
   describe('should search items', () => {
@@ -284,6 +282,12 @@ describe('LuckySearchComponent', () => {
     });
   });
 
+  describe('', () => {
+    beforeEach(() => {
+      fixture = TestBed.createComponent(LuckySearchComponent);
+      component = fixture.componentInstance;
+    });
+
   it('should not redirect when no bitstreams are found', () => {
     const item = Object.assign(new Item(), {uuid: 'item-uuid-1', name: 'Test item 1'});
     const data = createSuccessfulRemoteDataObject(createPaginatedList([
@@ -298,6 +302,7 @@ describe('LuckySearchComponent', () => {
   });
 
   it('should update showEmptySearchSection$ when no results are found', () => {
+      fixture.detectChanges();
     const emptyResults = createSuccessfulRemoteDataObject(createPaginatedList([]));
 
     spyOn(component as any, 'getLuckySearchResults').and.returnValue(observableOf(emptyResults));
@@ -307,4 +312,6 @@ describe('LuckySearchComponent', () => {
 
     expect(component.showEmptySearchSection$.getValue()).toBe(true);
   });
+
+  });
 });