[DSC-2858] fix tests

Author: Andrea Barbasso

src/app/access-control/epeople-registry/eperson-form/eperson-form.component.spec.ts

@@ -323,7 +323,7 @@ describe('EPersonFormComponent', () => {
       beforeEach(() => {
         component.formGroup.controls.firstName.setValue('test');
         component.formGroup.controls.lastName.setValue('test');
-        component.formGroup.controls.email.setValue('TEST@test.com');
+        component.formGroup.controls.email.setValue('test@test.com');
         fixture.detectChanges();
       });
 
@@ -340,7 +340,7 @@ describe('EPersonFormComponent', () => {
       });
       it('email should not be valid because the email pattern', () => {
         expect(component.formGroup.controls.email.valid).toBeFalse();
-        expect(component.formGroup.controls.email.errors.email).toBeTruthy();
+        expect(component.formGroup.controls.email.errors.pattern).toBeTruthy();
       });
     });
 

src/app/core/auth/auth.effects.spec.ts

@@ -198,6 +198,7 @@ describe('AuthEffects', () => {
         const expected = cold('--b-', { b: new AuthenticatedErrorAction(new Error('Message Error test')) });
 
         expect(authEffects.authenticated$).toBeObservable(expected);
+        done();
       });
     });
 

src/app/cris-layout/cris-layout-matrix/cris-layout-box-container/boxes/metadata/rendering-types/attachment/attachment.component.spec.ts

@@ -33,6 +33,7 @@ import { createPaginatedList } from '../../../../../../../shared/testing/utils.t
 import { TruncatableComponent } from '../../../../../../../shared/truncatable/truncatable.component';
 import { TruncatablePartComponent } from '../../../../../../../shared/truncatable/truncatable-part/truncatable-part.component';
 import { FileSizePipe } from '../../../../../../../shared/utils/file-size-pipe';
+import { LocaleService } from '../../../../../../../core/locale/locale.service';
 import { FieldRenderingType } from '../field-rendering-type';
 import { AttachmentComponent } from './attachment.component';
 
@@ -171,6 +172,7 @@ describe('AttachmentComponent', () => {
         { provide: 'tabNameProvider', useValue: '' },
         { provide: BitstreamDataService, useValue: mockBitstreamDataService },
         { provide: AuthorizationDataService, useValue: mockAuthorizedService },
+        { provide: LocaleService, useValue: { getCurrentLanguageCode: () => of('en') } },
       ],
       schemas: [NO_ERRORS_SCHEMA],
     };

src/app/item-page/mirador-viewer/mirador-viewer.component.spec.ts

@@ -218,13 +218,13 @@ describe('MiradorViewerComponent in development mode', () => {
     });
 
     it('should not embed the viewer',  async () => {
-      await fixture.whenStable();
-      comp.iframeViewerUrl = of('testUrl');
-      viewerService.showEmbeddedViewer.and.returnValue(false);
-      comp.getURL = () => null;
+      fixture = TestBed.createComponent(MiradorViewerComponent);
+      comp = fixture.componentInstance;
+      comp.object = getItem(noMetadata);
       comp.searchable = false;
-      comp.ngOnInit();
+      comp.getURL = () => null;
       fixture.detectChanges();
+      await fixture.whenStable();
       const value = fixture.debugElement
         .nativeElement.querySelector('#mirador-viewer');
       expect(value).toBeNull();

src/app/lucky-search/search/lucky-search.component.spec.ts

@@ -51,6 +51,7 @@ import { createPaginatedList } from '../../shared/testing/utils.test';
 import { TruncatableComponent } from '../../shared/truncatable/truncatable.component';
 import { TruncatablePartComponent } from '../../shared/truncatable/truncatable-part/truncatable-part.component';
 import { FileSizePipe } from '../../shared/utils/file-size-pipe';
+import { LocaleService } from '../../core/locale/locale.service';
 import { LuckySearchService } from '../lucky-search.service';
 import { LuckySearchComponent } from './lucky-search.component';
 
@@ -133,6 +134,7 @@ describe('LuckySearchComponent', () => {
         { provide: PLATFORM_ID, useValue: 'browser' },
         { provide: NotificationsService, useValue: new NotificationsServiceStub() },
         { provide: APP_CONFIG, useValue: {} },
+        { provide: LocaleService, useValue: { getCurrentLanguageCode: () => of('en') } },
       ],
     }).overrideComponent(LuckySearchComponent, {
       remove: {

src/app/shared/form/builder/ds-dynamic-form-ui/models/relation-inline-group/dynamic-relation-inline-group.component.spec.ts

@@ -25,6 +25,7 @@ import {
   DynamicFormLayoutService,
   DynamicFormValidationService,
 } from '@ng-dynamic-forms/core';
+import { ScannedActionsSubject } from '@ngrx/store';
 import { provideMockStore } from '@ngrx/store/testing';
 import { TranslateModule } from '@ngx-translate/core';
 import { of } from 'rxjs';
@@ -195,6 +196,7 @@ describe('DsDynamicRelationInlineGroupComponent test suite', () => {
         { provide: SubmissionObjectDataService, useValue: {} },
         { provide: XSRFService, useValue: {} },
         { provide: LiveRegionService, useValue: {} },
+        { provide: ScannedActionsSubject, useValue: new ScannedActionsSubject() },
         { provide: APP_CONFIG, useValue: environment },
         { provide: APP_DATA_SERVICES_MAP, useValue: {} },
         { provide: DYNAMIC_FORM_CONTROL_MAP_FN, useValue: dsDynamicFormControlMapFn },

src/app/statistics-page/cris-statistics-page/cris-statistics-page.component.spec.ts

@@ -14,6 +14,13 @@ import {
   TranslateLoader,
   TranslateModule,
 } from '@ngx-translate/core';
+import {
+  NgbNav,
+  NgbNavContent,
+  NgbNavItem,
+  NgbNavLink,
+  NgbNavModule,
+} from '@ng-bootstrap/ng-bootstrap';
 import { of } from 'rxjs';
 
 import { AuthService } from '../../core/auth/auth.service';
@@ -80,6 +87,10 @@ describe('CrisStatisticsPageComponent', () => {
           },
         }),
         CrisStatisticsPageComponent,
+        NgbNav,
+        NgbNavItem,
+        NgbNavLink,
+        NgbNavContent,
       ],
       providers: [
         provideMockStore({ initialState }),
@@ -91,7 +102,7 @@ describe('CrisStatisticsPageComponent', () => {
       ],
       schemas: [NO_ERRORS_SCHEMA],
     })
-      .overrideComponent(CrisStatisticsPageComponent, { remove: { imports: [ThemedLoadingComponent, StatisticsMapComponent, StatisticsChartComponent] } }).compileComponents();
+      .overrideComponent(CrisStatisticsPageComponent, { remove: { imports: [ThemedLoadingComponent, StatisticsMapComponent, StatisticsChartComponent, NgbNavModule] }, add: { imports: [NgbNav, NgbNavItem, NgbNavLink, NgbNavContent] } }).compileComponents();
   });
 
   beforeEach(() => {
@@ -143,8 +154,9 @@ describe('CrisStatisticsPageComponent', () => {
       component.selectedCategory = data[0];
     });
     fixture.detectChanges();
-    const renderedCategories = fixture.debugElement.queryAll(By.css('#categories-tabs li a'));
-    expect(renderedCategories[0].nativeElement.classList.contains('active')).toBe(true);
+    const renderedLinks = fixture.debugElement.queryAll(By.css('#categories-tabs li a'));
+    expect(renderedLinks.length).toBe(2);
+    expect(renderedLinks[0].nativeElement.classList.contains('active')).toBe(true);
   });
 
   it('should set selectedReportId to the first report id if no reportType query param is present', () => {