Merge pull request DSpace#5856 from toniprieto/New-collection-menu-visibility

Make the “New collection” menu option visible for Community Admins

Author: tdonohue

src/app/shared/menu/providers/new.menu.spec.ts

@@ -38,7 +38,7 @@ describe('NewMenuProvider', () => {
       },
     },
     {
-      visible: false,
+      visible: true,
       model: {
         type: MenuItemType.ONCLICK,
         text: 'menu.section.new_collection',

src/app/shared/menu/providers/new.menu.ts

@@ -54,12 +54,11 @@ export class NewMenuProvider extends AbstractExpandableMenuProvider {
 
   public getSubSections(): Observable<PartialMenuSection[]> {
     return combineLatest([
-      this.authorizationService.isAuthorized(FeatureID.IsCollectionAdmin),
       this.authorizationService.isAuthorized(FeatureID.IsCommunityAdmin),
       this.authorizationService.isAuthorized(FeatureID.AdministratorOf),
       this.authorizationService.isAuthorized(FeatureID.CanSubmit),
       this.authorizationService.isAuthorized(FeatureID.CoarNotifyEnabled),
-    ]).pipe(map(([isCollectionAdmin, isCommunityAdmin, isSiteAdmin, canSubmit, isCoarNotifyEnabled]: [boolean, boolean, boolean, boolean, boolean]) => {
+    ]).pipe(map(([isCommunityAdmin, isSiteAdmin, canSubmit, isCoarNotifyEnabled]: [boolean, boolean, boolean, boolean]) => {
 
       return [
         {
@@ -73,7 +72,7 @@ export class NewMenuProvider extends AbstractExpandableMenuProvider {
           },
         },
         {
-          visible: isCollectionAdmin,
+          visible: isCommunityAdmin,
           model: {
             type: MenuItemType.ONCLICK,
             text: 'menu.section.new_collection',