|
| 1 | +import { PLATFORM_ID } from '@angular/core'; |
| 2 | +import { TestBed } from '@angular/core/testing'; |
| 3 | +import { Router } from '@angular/router'; |
| 4 | +import { RouterTestingModule } from '@angular/router/testing'; |
| 5 | +import { |
| 6 | + tabDetailsTest, |
| 7 | + tabFundingsTest, |
| 8 | + tabPublicationsTest, |
| 9 | +} from '@dspace/core/testing/layout-tab.mocks'; |
| 10 | +import { createPaginatedList } from '@dspace/core/testing/utils.test'; |
| 11 | +import { |
| 12 | + createSuccessfulRemoteDataObject, |
| 13 | + createSuccessfulRemoteDataObject$, |
| 14 | +} from '@dspace/core/utilities/remote-data.utils'; |
| 15 | +import { Observable } from 'rxjs'; |
| 16 | +import { take } from 'rxjs/operators'; |
| 17 | + |
| 18 | +import { ItemDataService } from '../core/data/item-data.service'; |
| 19 | +import { PaginatedList } from '../core/data/paginated-list.model'; |
| 20 | +import { RemoteData } from '../core/data/remote-data'; |
| 21 | +import { DynamicLayoutTab } from '../core/layout/models/tab.model'; |
| 22 | +import { TabDataService } from '../core/layout/tab-data.service'; |
| 23 | +import { HardRedirectService } from '../core/services/hard-redirect.service'; |
| 24 | +import { Item } from '../core/shared/item.model'; |
| 25 | +import { dynamicItemPageTabResolver } from './dynamic-item-page-tab.resolver'; |
| 26 | + |
| 27 | +describe('CrisItemPageTabResolver', () => { |
| 28 | + beforeEach(() => { |
| 29 | + TestBed.configureTestingModule({ |
| 30 | + imports: [RouterTestingModule.withRoutes([{ |
| 31 | + path: 'entities/:entity-type/:id/:tab', |
| 32 | + component: {} as any, |
| 33 | + }])], |
| 34 | + }); |
| 35 | + }); |
| 36 | + |
| 37 | + describe('dynamicItemPageTabResolver', () => { |
| 38 | + let itemService: jasmine.SpyObj<ItemDataService>; |
| 39 | + let tabService: jasmine.SpyObj<TabDataService>; |
| 40 | + let hardRedirectService: jasmine.SpyObj<HardRedirectService>; |
| 41 | + let router: Router; |
| 42 | + |
| 43 | + const uuid = '1234-65487-12354-1235'; |
| 44 | + const item = Object.assign(new Item(), { |
| 45 | + id: uuid, |
| 46 | + uuid: uuid, |
| 47 | + metadata: { |
| 48 | + 'dspace.entity.type': [{ value: 'Publication' }], |
| 49 | + }, |
| 50 | + }); |
| 51 | + |
| 52 | + const tabsRD = createSuccessfulRemoteDataObject(createPaginatedList([tabPublicationsTest, tabDetailsTest, tabFundingsTest])); |
| 53 | + const tabsRD$ = createSuccessfulRemoteDataObject$(createPaginatedList([tabPublicationsTest, tabDetailsTest, tabFundingsTest])); |
| 54 | + |
| 55 | + const noTabsRD = createSuccessfulRemoteDataObject(createPaginatedList([])); |
| 56 | + const noTabsRD$ = createSuccessfulRemoteDataObject$(createPaginatedList([])); |
| 57 | + |
| 58 | + beforeEach(() => { |
| 59 | + itemService = jasmine.createSpyObj('ItemDataService', ['findById']); |
| 60 | + tabService = jasmine.createSpyObj('TabDataService', ['findByItem']); |
| 61 | + hardRedirectService = jasmine.createSpyObj('HardRedirectService', ['redirect']); |
| 62 | + |
| 63 | + TestBed.configureTestingModule({ |
| 64 | + imports: [RouterTestingModule.withRoutes([{ path: 'entities/:entity-type/:id/:tab', component: {} as any }])], |
| 65 | + providers: [ |
| 66 | + { provide: ItemDataService, useValue: itemService }, |
| 67 | + { provide: TabDataService, useValue: tabService }, |
| 68 | + { provide: HardRedirectService, useValue: hardRedirectService }, |
| 69 | + { provide: PLATFORM_ID, useValue: 'browser' }, |
| 70 | + ], |
| 71 | + }); |
| 72 | + |
| 73 | + router = TestBed.inject(Router); |
| 74 | + }); |
| 75 | + |
| 76 | + describe('when item exists', () => { |
| 77 | + beforeEach(() => { |
| 78 | + itemService.findById.and.returnValue(createSuccessfulRemoteDataObject$(item)); |
| 79 | + }); |
| 80 | + |
| 81 | + describe('and there are tabs', () => { |
| 82 | + beforeEach(() => { |
| 83 | + tabService.findByItem.and.returnValue(tabsRD$); |
| 84 | + spyOn(router, 'navigateByUrl'); |
| 85 | + }); |
| 86 | + |
| 87 | + it('should redirect to root route if given tab is the first one', (done) => { |
| 88 | + const obs = TestBed.runInInjectionContext(() => { |
| 89 | + return dynamicItemPageTabResolver({ params: { id: uuid } } as any, { url: '/entities/publication/1234-65487-12354-1235/publications' } as any); |
| 90 | + }) as Observable<RemoteData<PaginatedList<DynamicLayoutTab>>>; |
| 91 | + |
| 92 | + obs.pipe(take(1)).subscribe((resolved) => { |
| 93 | + expect(router.navigateByUrl).toHaveBeenCalledWith('/entities/publication/1234-65487-12354-1235'); |
| 94 | + expect(hardRedirectService.redirect).not.toHaveBeenCalled(); |
| 95 | + expect(resolved).toEqual(tabsRD); |
| 96 | + done(); |
| 97 | + }); |
| 98 | + }); |
| 99 | + |
| 100 | + it('should not redirect to root route if tab different than the main one is given', (done) => { |
| 101 | + const obs = TestBed.runInInjectionContext(() => { |
| 102 | + return dynamicItemPageTabResolver({ params: { id: uuid } } as any, { url: '/entities/publication/1234-65487-12354-1235/details' } as any); |
| 103 | + }) as Observable<RemoteData<PaginatedList<DynamicLayoutTab>>>; |
| 104 | + |
| 105 | + obs.pipe(take(1)).subscribe((resolved) => { |
| 106 | + expect(router.navigateByUrl).not.toHaveBeenCalled(); |
| 107 | + expect(hardRedirectService.redirect).not.toHaveBeenCalled(); |
| 108 | + expect(resolved).toEqual(tabsRD); |
| 109 | + done(); |
| 110 | + }); |
| 111 | + }); |
| 112 | + |
| 113 | + it('should not redirect to root route if no tab is given', (done) => { |
| 114 | + const obs = TestBed.runInInjectionContext(() => { |
| 115 | + return dynamicItemPageTabResolver({ params: { id: uuid } } as any, { url: '/entities/publication/1234-65487-12354-1235' } as any); |
| 116 | + }) as Observable<RemoteData<PaginatedList<DynamicLayoutTab>>>; |
| 117 | + |
| 118 | + obs.pipe(take(1)).subscribe((resolved) => { |
| 119 | + expect(router.navigateByUrl).not.toHaveBeenCalled(); |
| 120 | + expect(hardRedirectService.redirect).not.toHaveBeenCalled(); |
| 121 | + expect(resolved).toEqual(tabsRD); |
| 122 | + done(); |
| 123 | + }); |
| 124 | + }); |
| 125 | + |
| 126 | + it('should navigate to 404 if a wrong tab is given', (done) => { |
| 127 | + const obs = TestBed.runInInjectionContext(() => { |
| 128 | + return dynamicItemPageTabResolver({ params: { id: uuid } } as any, { url: '/entities/publication/1234-65487-12354-1235/test' } as any); |
| 129 | + }) as Observable<RemoteData<PaginatedList<DynamicLayoutTab>>>; |
| 130 | + |
| 131 | + obs.pipe(take(1)).subscribe((resolved) => { |
| 132 | + expect(router.navigateByUrl).toHaveBeenCalled(); |
| 133 | + expect(hardRedirectService.redirect).not.toHaveBeenCalled(); |
| 134 | + expect(resolved).toEqual(tabsRD); |
| 135 | + done(); |
| 136 | + }); |
| 137 | + }); |
| 138 | + |
| 139 | + it('Should handle tab shortnames with "::" correctly', (done) => { |
| 140 | + const tabPageList = createPaginatedList([{ |
| 141 | + ...tabPublicationsTest, |
| 142 | + shortname: 'publication::details', |
| 143 | + }]); |
| 144 | + const tabRD = createSuccessfulRemoteDataObject(tabPageList); |
| 145 | + tabService.findByItem.and.returnValue(createSuccessfulRemoteDataObject$(tabPageList) as any); |
| 146 | + |
| 147 | + const obs = TestBed.runInInjectionContext(() => { |
| 148 | + return dynamicItemPageTabResolver({ params: { id: uuid } } as any, { url: '/entities/publication/1234-65487-12354-1235/details' } as any); |
| 149 | + }) as Observable<RemoteData<PaginatedList<DynamicLayoutTab>>>; |
| 150 | + |
| 151 | + obs.pipe(take(1)).subscribe((resolved) => { |
| 152 | + expect(router.navigateByUrl).not.toHaveBeenCalled(); |
| 153 | + expect(hardRedirectService.redirect).not.toHaveBeenCalled(); |
| 154 | + expect(resolved).toEqual(tabRD); |
| 155 | + done(); |
| 156 | + }); |
| 157 | + }); |
| 158 | + |
| 159 | + it('should NOT redirect to 404 when query params are present in the URL', (done) => { |
| 160 | + const obs = TestBed.runInInjectionContext(() => { |
| 161 | + return dynamicItemPageTabResolver({ params: { id: uuid } } as any, { url: '/entities/publication/1234-65487-12354-1235?f.subject=value&f.date=2024' } as any); |
| 162 | + }) as Observable<RemoteData<PaginatedList<DynamicLayoutTab>>>; |
| 163 | + |
| 164 | + obs.pipe(take(1)).subscribe((resolved) => { |
| 165 | + expect(router.navigateByUrl).not.toHaveBeenCalled(); |
| 166 | + expect(hardRedirectService.redirect).not.toHaveBeenCalled(); |
| 167 | + expect(resolved).toEqual(tabsRD); |
| 168 | + done(); |
| 169 | + }); |
| 170 | + }); |
| 171 | + |
| 172 | + it('should NOT redirect to 404 when query params are present with a valid tab', (done) => { |
| 173 | + const obs = TestBed.runInInjectionContext(() => { |
| 174 | + return dynamicItemPageTabResolver({ params: { id: uuid } } as any, { url: '/entities/publication/1234-65487-12354-1235/details?f.subject=value' } as any); |
| 175 | + }) as Observable<RemoteData<PaginatedList<DynamicLayoutTab>>>; |
| 176 | + |
| 177 | + obs.pipe(take(1)).subscribe((resolved) => { |
| 178 | + expect(router.navigateByUrl).not.toHaveBeenCalled(); |
| 179 | + expect(hardRedirectService.redirect).not.toHaveBeenCalled(); |
| 180 | + expect(resolved).toEqual(tabsRD); |
| 181 | + done(); |
| 182 | + }); |
| 183 | + }); |
| 184 | + }); |
| 185 | + |
| 186 | + describe('and there are no tabs', () => { |
| 187 | + beforeEach(() => { |
| 188 | + tabService.findByItem.and.returnValue(noTabsRD$); |
| 189 | + spyOn(router, 'navigateByUrl'); |
| 190 | + }); |
| 191 | + |
| 192 | + it('should not redirect nor navigate', (done) => { |
| 193 | + const obs = TestBed.runInInjectionContext(() => { |
| 194 | + return dynamicItemPageTabResolver({ params: { id: uuid } } as any, { url: '/entities/publication/1234-65487-12354-1235' } as any); |
| 195 | + }) as Observable<RemoteData<PaginatedList<DynamicLayoutTab>>>; |
| 196 | + |
| 197 | + obs.pipe(take(1)).subscribe((resolved) => { |
| 198 | + expect(router.navigateByUrl).not.toHaveBeenCalled(); |
| 199 | + expect(hardRedirectService.redirect).not.toHaveBeenCalled(); |
| 200 | + expect(resolved).toEqual(noTabsRD); |
| 201 | + done(); |
| 202 | + }); |
| 203 | + }); |
| 204 | + }); |
| 205 | + }); |
| 206 | + }); |
| 207 | +}); |
0 commit comments