BUG: Fix bug related to inclusive keyword in pandas.date_range and warning related to line_terminator keyword (#45)

Author: vegard-solum-4ss

fourinsight/engineroom/utils/_core.py

@@ -397,7 +397,10 @@ def collect(self, **results):
         current_index = self._dataframe.index[-1]
 
         try:
-            row_update = pd.DataFrame(data=results, index=[current_index],).astype(
+            row_update = pd.DataFrame(
+                data=results,
+                index=[current_index],
+            ).astype(
                 {
                     header: dtype_
                     for header, dtype_ in self._headers.items()
@@ -476,7 +479,14 @@ def push(self):
         """
         self._handler.seek(0)
         self._handler.truncate()
-        self._dataframe.to_csv(self._handler, sep=",", index=True, line_terminator="\n")
+        try:
+            self._dataframe.to_csv(
+                self._handler, sep=",", index=True, lineterminator="\n"
+            )
+        except TypeError:  # for backward compatibility (remove after 2024-06-01)
+            self._dataframe.to_csv(
+                self._handler, sep=",", index=True, line_terminator="\n"
+            )
         self._handler.push()
 
     @property

fourinsight/engineroom/utils/iter_index/_iter_index.py

@@ -6,7 +6,7 @@ def date_range(
     end=None,
     periods=None,
     freq=None,
-    inclusive=None,
+    inclusive="both",
     **kwargs,
 ):
     """
@@ -37,6 +37,9 @@ def date_range(
     if periods:
         periods += 1
 
+    if inclusive is None:
+        inclusive = "both"
+
     start_end = pd.date_range(
         start=start, end=end, periods=periods, freq=freq, inclusive=inclusive, **kwargs
     )

tests/test_core.py

@@ -287,7 +287,6 @@ def test__setitem__(self, persistent_dict):
 
     def test__setitem_jsonencode(self, persistent_dict):
         with patch.object(persistent_dict, "_jsonencoder") as mock_jsonencoder:
-
             persistent_dict["a"] = 1
             mock_jsonencoder.assert_called_once_with(1)