Skip to content

Commit 28cb2a4

Browse files
chore: Improve RAO class docstring (#48)
1 parent a7560c3 commit 28cb2a4

1 file changed

Lines changed: 25 additions & 2 deletions

File tree

src/waveresponse/_core.py

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -915,7 +915,8 @@ class RAO(Grid):
915915
1-D array of grid frequency coordinates. Positive and monotonically increasing.
916916
dirs : array-like
917917
1-D array of grid direction coordinates. Positive and monotonically increasing.
918-
Must cover the directional range [0, 360) degrees (or [0, 2 * numpy.pi) radians).
918+
Should be within the directional range [0, 360) degrees (or [0, 2*pi) radians).
919+
See Notes.
919920
vals : array-like (N, M)
920921
RAO values (complex) associated with the grid. Should be a 2-D array of shape (N, M),
921922
such that ``N=len(freq)`` and ``M=len(dirs)``.
@@ -929,6 +930,16 @@ class RAO(Grid):
929930
waves_coming_from : bool
930931
If waves are 'coming from' the given directions. If ``False``, 'going towards'
931932
convention is assumed.
933+
934+
Notes
935+
-----
936+
If the RAO is going to be used in response calculation (where the RAO is combined
937+
with a wave spectrum to form a response spectrum), it is important that the
938+
RAO covers the full directional domain, i.e., [0, 360) degrees, with a sufficient
939+
resolution. If the RAO object only partly covers the directional domain, you
940+
can consider to use the :func:`mirror` function to 'expand' the RAO with values
941+
that are folded about a symmetry plane.
942+
932943
"""
933944

934945
def __init__(
@@ -976,7 +987,8 @@ def from_amp_phase(
976987
1-D array of grid frequency coordinates. Positive and monotonically increasing.
977988
dirs : array-like
978989
1-D array of grid direction coordinates. Positive and monotonically increasing.
979-
Must cover the directional range [0, 360) degrees (or [0, 2 * numpy.pi) radians).
990+
Should be within the directional range [0, 360) degrees (or [0, 2*pi) radians).
991+
See Notes.
980992
amp : array-like (N, M)
981993
RAO amplitude values associated with the grid. Should be a 2-D array
982994
of shape (N, M), such that ``N=len(freq)`` and ``M=len(dirs)``.
@@ -998,8 +1010,19 @@ def from_amp_phase(
9981010
convention is assumed.
9991011
10001012
Returns
1013+
-------
10011014
obj :
10021015
Initialized RAO object.
1016+
1017+
Notes
1018+
-----
1019+
If the RAO is going to be used in response calculation (where the RAO is combined
1020+
with a wave spectrum to form a response spectrum), it is important that the
1021+
RAO covers the full directional domain, i.e., [0, 360) degrees, with a sufficient
1022+
resolution. If the RAO object only partly covers the directional domain, you
1023+
can consider to use the :func:`mirror` function to 'expand' the RAO with values
1024+
that are folded about a symmetry plane.
1025+
10031026
"""
10041027
rao_complex = polar_to_complex(amp, phase, phase_degrees=phase_degrees)
10051028

0 commit comments

Comments
 (0)