Skip to content

refactor: replace boost predicates with absl#4111

Merged
DSFans2014 merged 1 commit into
4paradigm:mainfrom
isotauon:refactor/replace-boost-predicates
May 14, 2026
Merged

refactor: replace boost predicates with absl#4111
DSFans2014 merged 1 commit into
4paradigm:mainfrom
isotauon:refactor/replace-boost-predicates

Conversation

@isotauon
Copy link
Copy Markdown
Contributor

Summary

  • Replace boost::starts_with with absl::StartsWith in src/nameserver/name_server_impl.cc (3 sites).
  • Replace boost::iequals with absl::EqualsIgnoreCase in src/tablet/tablet_impl.cc (1 site).
  • Matches the convention used after the boost::ends_with removal in refactor: replace boost::ends_with with absl::EndsWith #4107. No behavior change.

Test plan

  • Existing unit/integration tests pass in CI.

Replace boost::starts_with with absl::StartsWith in name_server_impl.cc
(3 sites) and boost::iequals with absl::EqualsIgnoreCase in
tablet_impl.cc (1 site), matching the convention used after the
boost::ends_with replacement in 4paradigm#4107. No behavior change.
@github-actions github-actions Bot added the storage-engine openmldb storage engine. nameserver & tablet label May 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.31%. Comparing base (1d5edd3) to head (96f3763).

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #4111    +/-   ##
==========================================
  Coverage     75.31%   75.31%            
  Complexity      711      711            
==========================================
  Files           763      763            
  Lines        143738   143738            
  Branches       1537     2074   +537     
==========================================
+ Hits         108252   108254     +2     
+ Misses        35183    35181     -2     
  Partials        303      303            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DSFans2014 DSFans2014 merged commit 3d2b644 into 4paradigm:main May 14, 2026
19 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

storage-engine openmldb storage engine. nameserver & tablet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants