refactor: replace boost::filesystem with std::filesystem in glog_wrapper#4112
Merged
DSFans2014 merged 1 commit intoMay 14, 2026
Merged
Conversation
Drop the boost/filesystem.hpp dependency from src/base/glog_wrapper.h and its test, using std::filesystem instead. std::filesystem is already the convention elsewhere in the project (e.g. src/datacollector/data_collector.h). No behavior change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4112 +/- ##
=========================================
Coverage 75.31% 75.32%
Complexity 711 711
=========================================
Files 763 763
Lines 143738 143738
Branches 1537 1480 -57
=========================================
+ Hits 108252 108266 +14
+ Misses 35183 35169 -14
Partials 303 303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DSFans2014
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boost/filesystem.hppfromsrc/base/glog_wrapper.hand usestd::filesystem::create_directoriesinstead.src/base/glog_wrapper_test.ccto aliasfs = std::filesystem.std::filesystemis already the convention in other parts of the project (e.g.src/datacollector/data_collector.h,src/cmd/sql_cmd_test.cc). No behavior change.Test plan
glog_wrapper_testpasses locally / in CI.