Skip to content

refactor: replace boost::filesystem with std::filesystem in glog_wrapper#4112

Merged
DSFans2014 merged 1 commit into
4paradigm:mainfrom
isotauon:refactor/replace-boost-filesystem-glog
May 14, 2026
Merged

refactor: replace boost::filesystem with std::filesystem in glog_wrapper#4112
DSFans2014 merged 1 commit into
4paradigm:mainfrom
isotauon:refactor/replace-boost-filesystem-glog

Conversation

@isotauon
Copy link
Copy Markdown
Contributor

Summary

  • Drop boost/filesystem.hpp from src/base/glog_wrapper.h and use std::filesystem::create_directories instead.
  • Update src/base/glog_wrapper_test.cc to alias fs = std::filesystem.
  • std::filesystem is already the convention in other parts of the project (e.g. src/datacollector/data_collector.h, src/cmd/sql_cmd_test.cc). No behavior change.

Test plan

  • glog_wrapper_test passes locally / in CI.

Drop the boost/filesystem.hpp dependency from src/base/glog_wrapper.h
and its test, using std::filesystem instead. std::filesystem is already
the convention elsewhere in the project (e.g. src/datacollector/data_collector.h).
No behavior change.
@github-actions github-actions Bot added the storage-engine openmldb storage engine. nameserver & tablet label May 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.32%. Comparing base (1d5edd3) to head (cacc656).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4112   +/-   ##
=========================================
  Coverage     75.31%   75.32%           
  Complexity      711      711           
=========================================
  Files           763      763           
  Lines        143738   143738           
  Branches       1537     1480   -57     
=========================================
+ Hits         108252   108266   +14     
+ Misses        35183    35169   -14     
  Partials        303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DSFans2014 DSFans2014 merged commit 8b3b754 into 4paradigm:main May 14, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

storage-engine openmldb storage engine. nameserver & tablet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants