Skip to content

refactor: replace boost::container::deque with std::deque#4113

Merged
DSFans2014 merged 1 commit into
4paradigm:mainfrom
isotauon:refactor/replace-boost-container-deque
May 14, 2026
Merged

refactor: replace boost::container::deque with std::deque#4113
DSFans2014 merged 1 commit into
4paradigm:mainfrom
isotauon:refactor/replace-boost-container-deque

Conversation

@isotauon
Copy link
Copy Markdown
Contributor

Summary

  • Use std::deque in src/codec/codec_test.cc and src/codec/codec_bench_test.ccboost::container::deque adds nothing over the standard one here.
  • Drop the boost/container/deque.hpp include from src/codec/row_codec.{h,cc} and src/tablet/tablet_impl.cc, where it was already unused. No behavior change.

Test plan

  • codec_test and codec_bench_test build and pass in CI.
  • tablet_impl still builds.

Use std::deque in codec_test.cc and codec_bench_test.cc; the
boost::container variant adds nothing here. Also drop the
boost/container/deque.hpp include from row_codec.{h,cc} and
tablet_impl.cc, where it was already unused. No behavior change.
@github-actions github-actions Bot added the storage-engine openmldb storage engine. nameserver & tablet label May 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.31%. Comparing base (1d5edd3) to head (50236d2).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4113   +/-   ##
=========================================
  Coverage     75.31%   75.31%           
  Complexity      711      711           
=========================================
  Files           763      763           
  Lines        143738   143738           
  Branches       1537     1480   -57     
=========================================
+ Hits         108252   108254    +2     
+ Misses        35183    35181    -2     
  Partials        303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DSFans2014 DSFans2014 merged commit ef1d2d5 into 4paradigm:main May 14, 2026
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

storage-engine openmldb storage engine. nameserver & tablet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants