refactor: replace boost::container::deque with std::deque#4113
Merged
DSFans2014 merged 1 commit intoMay 14, 2026
Merged
Conversation
Use std::deque in codec_test.cc and codec_bench_test.cc; the
boost::container variant adds nothing here. Also drop the
boost/container/deque.hpp include from row_codec.{h,cc} and
tablet_impl.cc, where it was already unused. No behavior change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4113 +/- ##
=========================================
Coverage 75.31% 75.31%
Complexity 711 711
=========================================
Files 763 763
Lines 143738 143738
Branches 1537 1480 -57
=========================================
+ Hits 108252 108254 +2
+ Misses 35183 35181 -2
Partials 303 303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DSFans2014
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::dequeinsrc/codec/codec_test.ccandsrc/codec/codec_bench_test.cc—boost::container::dequeadds nothing over the standard one here.boost/container/deque.hppinclude fromsrc/codec/row_codec.{h,cc}andsrc/tablet/tablet_impl.cc, where it was already unused. No behavior change.Test plan
codec_testandcodec_bench_testbuild and pass in CI.tablet_implstill builds.