Accessibility improvements: Other amount input, and general opt-in labels. - #88
Closed
StoneMoney wants to merge 18 commits into
Closed
Accessibility improvements: Other amount input, and general opt-in labels.#88StoneMoney wants to merge 18 commits into
StoneMoney wants to merge 18 commits into
Conversation
StoneMoney
force-pushed
the
accessibility-improvements
branch
from
June 24, 2026 15:00
10a2ace to
ca45fe6
Compare
* Universal opt-in-copy is more universal * Opt-in nudge is announced * Build from npm engrid
…+ announce country pg notice
Member
|
This PR is on the July-2026 branch, with the latest ENgrid version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge until 4site-interactive-studios/engrid#407 and engrid is updated, rebuild this
Donation page frequency and amounts:
https://cln.sh/pLHTZJLz
Colors and Contrast
https://cln.sh/GYgdlhL5 — Screen reader fix in action (at 15s is the current page behavior)
Opt-in Label Coupling
WWF has a pair of text and form blocks: General - Conservation Updates - Opt-in Text (Be a part of our community) and General - Conservation Updates Email Opt-in (Examples, but there are several pairs), which hides the first label of the form block and puts a label in the bottom of the text block. The thing about those blocks is that they’re so ubiquitous on WWF’s pages, and yet these blocks were not created with screen readers in mind. A screen reader will still see the original hidden label for the opt in (by design) in addition to the new one made in the text block. What I’ve done is added 2 additions to the client theme that specifically handle when these two blocks are on a page.
be-a-part-of-our-communityuniversal-opt-in-copyorgeneral-opt-in-copyAssigns an ID to the.labelin the text blocki#-force-hide-labelwhich setsdisplay: none;to the input’s label.a. In normal situations we use
i#-hide-labelto visually hide the label but still allow screen readers to read the label. Since we’re using a different piece of text to describe the input, we need to hide this label to screen readers completely.described-byon the input block to the ID we assigned in step 1.This accomplishes the job of accurately labeling the first radio group in the block pairing. Both blocks are edit-lock blocks, meaning we shouldn’t have any substantial manual changes required across WWF’s pages. I’ve made quiet updates to both blocks to add in labeling classes for each, that do not change anything about the content or functionality pre-deployment.
Multistep Stepper
Supporter Hub Semantics
Thank You Title
Thank You | <original title>when loading on to a Thank You pageCookie Settings Modal
Premium Gifts non-US alert