Skip to content

Use inmem check box to help determine embedded ecard visibility (resubmission)#356

Merged
fernanDOTdo merged 2 commits into
4site-interactive-studios:mainfrom
StoneMoney:inmem-ecard-visibility
Nov 10, 2025
Merged

Use inmem check box to help determine embedded ecard visibility (resubmission)#356
fernanDOTdo merged 2 commits into
4site-interactive-studios:mainfrom
StoneMoney:inmem-ecard-visibility

Conversation

@StoneMoney

@StoneMoney StoneMoney commented Oct 27, 2025

Copy link
Copy Markdown
Member

Functionality can be tested at https://donate.spcai.org/page/179187/donate/1?assets=dev-nick

This feature adds the requireInMemCheckbox option in the EngridEmbeddedEcard configuration.
It will toggle the visibility of the ecard embed based on the both the state of the radio buttons (supporter.NOT_TAGGED_11) and the transaction.inmem checkbox.

Behavior table is as follows:

requireInMemCheckbox In Mem Checked E-Card Radio Checked Visible?
Y N N N
Y Y N N
Y N Y N
Y Y Y Y
N N N N
N Y N N
N N Y Y - Problem Case!
N Y Y Y

@MichaelT372
MichaelT372 self-requested a review November 10, 2025 13:13

@MichaelT372 MichaelT372 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Noting the limitation that the setup specifically on SPCAI requires additional custom code but what is submitted here works for a scenario where we need both checkboxes checked and the ecard checkbox is only revealed after the In Mem checkbox is hidden, which works fine for this use case and does not break any BC.

@fernanDOTdo
fernanDOTdo merged commit 0cc20a1 into 4site-interactive-studios:main Nov 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants