Conditional shipping fields#365
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
ShowHideRadioCheckboxesinstance to support the Shipping Fields.Usually Shipping fields visibility is handled by EN automatically but there is recently an issue where sometimes their event listener does not fire and the fields are stuck visible, cannot be toggled and prevent form submission. This change is to give us a way to work around that.
When setting up fields this way, you must:
shipenabled-Yclass to the form block containing the Shipping fields.i-requiredclasses for handling conditional validation.Test Pages
Without this change: https://support.nwf.org/page/90456/donate/1 spam refresh to see the EN bug happen and shipping fields become untoggleable.
With this change: https://support.nwf.org/page/90456/donate/1?assets=conditional-shippng-fields we're guarded against the EN bug and everything works.