Skip to content

Accessibility Improvements - Additional a11y changes#413

Open
StoneMoney wants to merge 4 commits into
mainfrom
accessibility-misc
Open

Accessibility Improvements - Additional a11y changes#413
StoneMoney wants to merge 4 commits into
mainfrom
accessibility-misc

Conversation

@StoneMoney

Copy link
Copy Markdown
Member

Form Error Live Alerting

  • Replaces the form error alert behavior from Accessibility Improvements: Form Field Error Alerting #396 with a global error list announce element.
  • All form errors will be gathered in a 100ms "push wave" before sending to the global error element
  • Alerts will be ordered based on where they are in the DOM tree
  • Alert list will take the error message and prefix the label of the errored input unless the error message contains the label name already, strips : and *
  • Now relocates the EN error messages to be positioned below the input field in the DOM (no visual difference) for better symantics
  • Focuses the first errored input in the form on form bad validation.

Misc Other Fixes

  • Drop empty "for" attributes on radio groups (invalid IDREF)
  • removed dead ternary L48
  • modernized .engrid__sr-only with clip-path: inset(50%), margin: -1px, padding: 0, border: 0.
  • clearFieldError now only removes aria-invalid if no .en__field__error nodes remain in the field wrapper.

* modernize sr-only
* remove * : from labels in global error message
* prevent connected nodes from being marked as cleared errors (since we relocate them now)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant