[feat] enable-background-download#16
Open
GabrielSousa02 wants to merge 9 commits into
Open
Conversation
During the integration tests, on teardown/rebuild of widgets, there's a moment when there's a ~12px overflow due to how the settings page was formed by Expanded. Now there's a conditional rendering where the parent widget gets replace by a single child scroll view to prevent the overflow from happening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Enabled background update of languages.
Why?
This will facilitate the user's life in managing language updates in general
How?
Enabled functions that were already wired up. Added some others, added tests
and one extra package to check on connectivity.
Testing?
Yes. Tests are passing.
New tests were also created.
Screenshots (optional)
Anything Else?
This has been tested on Android emulator and has the permission set for Android
devices. iOS needs further testing and permissions mapping.