-
-
Notifications
You must be signed in to change notification settings - Fork 4
Expand file tree
/
Copy pathtest_intake_form_processor.py
More file actions
892 lines (766 loc) · 30.1 KB
/
Copy pathtest_intake_form_processor.py
File metadata and controls
892 lines (766 loc) · 30.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
"""Unit tests for Google Forms intake processor."""
from unittest.mock import MagicMock, Mock, patch
import pytest
from five08.resume_extractor import ResumeExtractedProfile
from five08.worker.crm import intake_form_processor as intake_module
from five08.worker.crm.intake_form_processor import (
IntakeFormProcessor,
IntakeResumeFile,
)
def test_intake_form_processor_creates_prospect_when_not_found() -> None:
"""Form submitter with no CRM match should create a new prospect contact."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
processor.api.request.side_effect = [
{"list": []},
{"id": "contact-1"},
]
result = processor.process_intake(
payload={
"email": "new@example.com",
"first_name": "New",
"last_name": "Person",
"github_username": "https://github.com/newdev",
"primary_skills_interests": "AI and systems",
"top_question_about_508": "How does it work?",
"form_id": "form-1",
}
)
assert result["success"] is True
assert result["created"] is True
assert result["contact_id"] == "contact-1"
assert processor.api.request.call_count == 2
create_call = processor.api.request.call_args_list[1]
create_payload = create_call.args[2]
assert create_payload["cGitHubUsername"] == "newdev"
def test_intake_form_processor_lowercases_email_for_lookup_and_persistence() -> None:
"""Intake processing should use lowercase email for CRM lookup and DB joins."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
processor.api.request.side_effect = [
{"list": []},
{"id": "contact-1"},
]
with patch.object(processor, "_persist_intake_submission") as mock_persist:
result = processor.process_intake(
payload={
"email": " New@Example.COM ",
"first_name": "New",
"last_name": "Person",
"form_id": "form-1",
}
)
assert result["success"] is True
lookup_params = processor.api.request.call_args_list[0].args[2]
create_payload = processor.api.request.call_args_list[1].args[2]
assert lookup_params["where[0][value]"] == "new@example.com"
assert create_payload["emailAddress"] == "new@example.com"
mock_persist.assert_called_once()
assert mock_persist.call_args.kwargs["email"] == "new@example.com"
def test_intake_form_processor_dry_run_create_does_not_write_crm_or_db() -> None:
"""Dry-run create should search CRM and return planned fields without writes."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
processor.api.request.return_value = {"list": []}
with patch.object(processor, "_persist_intake_submission") as mock_persist:
result = processor.process_intake(
payload={
"dry_run": True,
"email": "new@example.com",
"first_name": "New",
"last_name": "Person",
"github_username": "https://github.com/newdev",
"form_id": "form-1",
}
)
assert result["success"] is True
assert result["dry_run"] is True
assert result["action"] == "create_prospect"
assert result["created"] is True
assert result["contact_id"] is None
assert result["planned_updates"]["emailAddress"] == "new@example.com"
assert result["planned_updates"]["cGitHubUsername"] == "newdev"
assert processor.api.request.call_count == 1
mock_persist.assert_not_called()
def test_intake_form_processor_dry_run_create_reports_resume_upload_plan() -> None:
"""Dry-run create should report that a scanned resume would be uploaded."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
processor.api.request.return_value = {"list": []}
resume_file = IntakeResumeFile(
filename="resume.pdf",
content=b"resume-bytes",
source_url="https://tally.so/resume.pdf",
)
with (
patch.object(processor, "_prepare_resume_file", return_value=resume_file),
patch.object(processor, "_build_resume_updates", return_value={}),
patch.object(processor, "_persist_intake_submission") as mock_persist,
):
result = processor.process_intake(
payload={
"dry_run": True,
"email": "new@example.com",
"first_name": "New",
"last_name": "Person",
"resume_url": "https://tally.so/resume.pdf",
"form_id": "form-1",
}
)
assert result["success"] is True
assert result["dry_run"] is True
assert result["would_upload_resume"] is True
assert result["resume_file_name"] == "resume.pdf"
assert result["resume_file_size_bytes"] == len(b"resume-bytes")
assert processor.api.request.call_count == 1
processor.api.upload_file.assert_not_called()
mock_persist.assert_not_called()
def test_create_prospect_does_not_retry_failed_resume_prepare() -> None:
"""Create flow should not download/scan a failed resume more than once."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
processor.api.request.side_effect = [
{"list": []},
{"id": "contact-1"},
]
with (
patch.object(processor, "_prepare_resume_file", return_value=None) as prepare,
patch.object(processor, "_persist_intake_submission"),
):
result = processor.process_intake(
payload={
"email": "new@example.com",
"first_name": "New",
"last_name": "Person",
"resume_url": "https://tally.so/resume.pdf",
"form_id": "form-1",
}
)
assert result["success"] is True
prepare.assert_called_once()
def test_intake_form_processor_dry_run_update_does_not_write_crm_or_db() -> None:
"""Dry-run update should return planned updates without PUT or persistence."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
processor.api.request.return_value = {
"list": [
{
"id": "contact-1",
"type": "Prospect",
"firstName": "Existing",
"lastName": "Person",
}
]
}
with patch.object(processor, "_persist_intake_submission") as mock_persist:
result = processor.process_intake(
payload={
"dry_run": "true",
"email": "existing@example.com",
"first_name": "Existing",
"last_name": "Person",
"github_username": "existingdev",
"form_id": "form-1",
}
)
assert result["success"] is True
assert result["dry_run"] is True
assert result["action"] == "update_prospect"
assert result["created"] is False
assert result["contact_id"] == "contact-1"
assert result["planned_updates"]["cGitHubUsername"] == "existingdev"
assert processor.api.request.call_count == 1
mock_persist.assert_not_called()
def test_update_prospect_does_not_retry_failed_resume_prepare() -> None:
"""Update flow should not download/scan a failed resume more than once."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
processor.api.request.side_effect = [
{"list": [{"id": "contact-1", "type": "Prospect"}]},
{},
]
with (
patch.object(processor, "_prepare_resume_file", return_value=None) as prepare,
patch.object(processor, "_persist_intake_submission"),
):
result = processor.process_intake(
payload={
"email": "existing@example.com",
"first_name": "Existing",
"last_name": "Person",
"github_username": "existing-dev",
"resume_url": "https://tally.so/resume.pdf",
"form_id": "form-1",
}
)
assert result["success"] is True
prepare.assert_called_once()
def test_intake_form_processor_uploads_resume_after_create() -> None:
"""Created prospects should receive the downloaded Tally resume attachment."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
processor.api.request.side_effect = [
{"list": []},
{"id": "contact-1"},
{"resumeIds": ["existing-att"]},
{},
]
processor.api.upload_file.return_value = {"id": "resume-att-1"}
resume_file = IntakeResumeFile(
filename="resume.pdf",
content=b"resume-bytes",
source_url="https://tally.so/resume.pdf",
)
with (
patch.object(processor, "_prepare_resume_file", return_value=resume_file),
patch.object(processor, "_build_resume_updates", return_value={}),
patch.object(processor, "_persist_intake_submission") as mock_persist,
):
result = processor.process_intake(
payload={
"email": "new@example.com",
"first_name": "New",
"last_name": "Person",
"resume_url": "https://tally.so/resume.pdf",
"form_id": "form-1",
}
)
assert result["success"] is True
assert result["resume_uploaded"] is True
assert result["resume_attachment_id"] == "resume-att-1"
processor.api.upload_file.assert_called_once_with(
file_content=b"resume-bytes",
filename="resume.pdf",
related_type="Contact",
related_id="contact-1",
field="resume",
)
assert processor.api.request.call_args_list[2].args == ("GET", "Contact/contact-1")
assert processor.api.request.call_args_list[3].args == (
"PUT",
"Contact/contact-1",
{"resumeIds": ["existing-att", "resume-att-1"]},
)
mock_persist.assert_called_once()
def test_intake_form_processor_rejects_tally_when_allowed_forms_unset() -> None:
"""Worker-side Tally intake should fail closed if jobs bypass the webhook."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
with patch.object(intake_module.settings, "onboarding_tally_allowed_form_ids", ""):
result = processor.process_intake(
payload={
"source": "tally",
"email": "new@example.com",
"first_name": "New",
"last_name": "Person",
"form_id": "unexpected-form",
}
)
assert result == {"success": False, "error": "invalid_form_id"}
processor.api.request.assert_not_called()
def test_intake_form_processor_rejects_member_updates() -> None:
"""Existing member contacts should not be updated from intake submissions."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
processor.api.request.return_value = {
"list": [
{
"id": "contact-1",
"type": "Member",
"cDiscordRoles": "Member",
}
]
}
result = processor.process_intake(
payload={
"email": "existing@member.com",
"first_name": "Current",
"last_name": "Member",
"form_id": "form-1",
}
)
assert result["success"] is False
assert result["error"] == "Contact already exists as member"
def test_intake_form_processor_rejects_member_agreement_signed_updates() -> None:
"""Signed member agreement should block intake updates even without role marker."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
processor.api.request.return_value = {
"list": [
{
"id": "contact-1",
"type": "Person",
"cMemberAgreementSignedAt": "2026-02-25T12:00:00Z",
}
]
}
result = processor.process_intake(
payload={
"email": "existing@member.com",
"first_name": "Current",
"last_name": "Member",
"form_id": "form-1",
}
)
assert result["success"] is False
assert result["error"] == "Contact already exists as member"
def test_intake_form_processor_rejects_duplicate_contacts() -> None:
"""Multiple CRM matches should fail without mutating any record."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
processor.api.request.return_value = {
"list": [{"id": "contact-1"}, {"id": "contact-2"}],
}
result = processor.process_intake(
payload={
"email": "duplicate@example.com",
"first_name": "Dupe",
"last_name": "Entry",
"form_id": "form-1",
}
)
assert result["success"] is False
assert result["error"] == "Multiple contacts found for email"
def test_intake_form_processor_does_not_overwrite_last_name_with_placeholder() -> None:
"""Generated placeholder last names should not be written to matched CRM contacts."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
processor.api.request.side_effect = [
{
"list": [
{
"id": "contact-1",
"type": "Prospect",
"firstName": "Existing",
"lastName": "Real",
}
]
},
{},
]
with patch.object(processor, "_persist_intake_submission") as mock_persist:
result = processor.process_intake(
payload={
"email": "existing@example.com",
"first_name": "Prince",
"last_name": "Unknown",
"last_name_is_placeholder": True,
"github_username": "prince",
"form_id": "form-1",
}
)
assert result["success"] is True
update_payload = processor.api.request.call_args_list[1].args[2]
assert update_payload["firstName"] == "Prince"
assert update_payload["cGitHubUsername"] == "prince"
assert "lastName" not in update_payload
mock_persist.assert_called_once()
def test_intake_form_processor_persists_placeholder_name_without_crm_create() -> None:
"""New single-token applicants should be queued for review instead of fake CRM create."""
processor = IntakeFormProcessor()
processor.api = MagicMock()
processor.api.request.return_value = {"list": []}
with patch.object(processor, "_persist_intake_submission") as mock_persist:
result = processor.process_intake(
payload={
"email": "new@example.com",
"first_name": "Prince",
"last_name": "Unknown",
"last_name_is_placeholder": True,
"form_id": "form-1",
}
)
assert result == {
"success": True,
"created": False,
"contact_id": None,
"updated_fields": [],
"pending_review": True,
"reason": "placeholder_last_name",
}
assert processor.api.request.call_count == 1
mock_persist.assert_called_once_with(
payload={
"email": "new@example.com",
"first_name": "Prince",
"last_name": "Unknown",
"last_name_is_placeholder": True,
"form_id": "form-1",
},
contact_id=None,
email="new@example.com",
)
def test_build_intake_updates_normalizes_form_skills_to_lowercase() -> None:
"""Skill tags from form labels should be canonicalized to lowercase list values."""
processor = IntakeFormProcessor()
updates = processor._build_intake_updates(
email="new@example.com",
first_name="New",
last_name="Person",
payload={
"skill_proficiency_next_js": "5",
"skill_proficiency_project_management": "4",
"skill_proficiency_ai_ml_engineering": "1",
"github_username": "person",
},
include_email=True,
)
assert updates["skills"] == ["ai ml engineering", "next js", "project management"]
def test_build_intake_updates_normalizes_primary_role() -> None:
"""Primary role should normalize to lowercase no-space values for cRoles."""
processor = IntakeFormProcessor()
updates = processor._build_intake_updates(
email="new@example.com",
first_name="New",
last_name="Person",
payload={
"primary_role": "Developer, Data Scientist, Biz Dev, Staff Engineering"
},
include_email=True,
)
assert updates["cRoles"] == [
"developer",
"data scientist",
"biz dev",
"staff engineering",
]
def test_persist_intake_submission_uses_raw_payload_and_nullable_upsert() -> None:
"""Raw submission bodies should be persisted with the nullable-safe upsert target."""
processor = IntakeFormProcessor()
cursor = MagicMock()
cursor.__enter__.return_value = cursor
conn = MagicMock()
conn.__enter__.return_value = conn
conn.cursor.return_value = cursor
raw_payload = {"eventId": "evt-1", "data": {"submissionId": "sub-1"}}
with patch(
"five08.worker.crm.intake_form_processor.get_postgres_connection",
return_value=conn,
):
processor._persist_intake_submission(
payload={
"source": "tally",
"email": "new@example.com",
"form_id": None,
"submission_id": None,
"raw_payload": raw_payload,
"raw_tally_fields": [{"label": "Email", "value": "new@example.com"}],
},
contact_id="contact-1",
email="new@example.com",
)
sql, params = cursor.execute.call_args.args
first_generated_submission_id = params[3]
assert "(COALESCE(form_id, ''))" in sql
assert "(COALESCE(submission_id, ''))" in sql
assert first_generated_submission_id.startswith("generated:")
assert params[7].obj["email"] == "new@example.com"
assert params[7].obj["submission_id"] == first_generated_submission_id
assert "raw_payload" not in params[7].obj
assert "raw_tally_fields" not in params[7].obj
assert params[8].obj == raw_payload
with patch(
"five08.worker.crm.intake_form_processor.get_postgres_connection",
return_value=conn,
):
processor._persist_intake_submission(
payload={
"source": "tally",
"email": "new@example.com",
"form_id": None,
"submission_id": None,
"raw_payload": raw_payload,
"raw_tally_fields": [{"label": "Email", "value": "new@example.com"}],
},
contact_id="contact-1",
email="new@example.com",
)
_, retry_params = cursor.execute.call_args.args
assert retry_params[3] == first_generated_submission_id
def test_persist_intake_submission_raises_for_orphan_persistence_failure() -> None:
"""Orphan intakes have no CRM mutation, so DB persistence failures must retry."""
processor = IntakeFormProcessor()
cursor = MagicMock()
cursor.__enter__.return_value = cursor
cursor.execute.side_effect = RuntimeError("db unavailable")
conn = MagicMock()
conn.__enter__.return_value = conn
conn.cursor.return_value = cursor
with (
patch(
"five08.worker.crm.intake_form_processor.get_postgres_connection",
return_value=conn,
),
pytest.raises(RuntimeError, match="db unavailable"),
):
processor._persist_intake_submission(
payload={
"source": "tally",
"email": "new@example.com",
"form_id": "form-1",
"submission_id": "sub-1",
},
contact_id=None,
email="new@example.com",
)
def test_build_resume_updates_includes_website_links_as_url_multiple() -> None:
"""Website links extracted from resume should be set to cWebsiteLink as an array."""
processor = IntakeFormProcessor()
processor.document_processor = MagicMock()
processor.resume_extractor = MagicMock()
processor.document_processor.extract_text.return_value = "resume text"
processor.resume_extractor.extract.return_value = ResumeExtractedProfile(
email=None,
github_username=None,
linkedin_url=None,
phone=None,
website_links=[
"https://portfolio.example.com",
"https://blog.example.com/",
"https://PORTFOLIO.EXAMPLE.COM",
],
address_country=None,
confidence=0.9,
source="gpt-4o-mini",
skills=[],
skill_attrs={},
)
response = Mock()
response.status_code = 200
response.content = b"resume-bytes"
response.raise_for_status = Mock()
response.headers = {}
response.iter_content = Mock(return_value=[b"resume-bytes"])
response.__enter__ = Mock(return_value=response)
response.__exit__ = Mock(return_value=None)
with (
patch(
"five08.worker.crm.intake_form_processor.requests.get",
return_value=response,
),
patch.object(processor, "_hostname_resolves_publicly", return_value=True),
patch.object(processor, "_scan_resume_content", return_value=True),
):
updates = processor._build_resume_updates(
{
"resume_url": "https://example.com/resume.pdf",
}
)
assert updates["cWebsiteLink"] == [
"https://portfolio.example.com",
"https://blog.example.com",
]
def test_build_resume_updates_uses_extracted_profile_fields_for_form_fields() -> None:
processor = IntakeFormProcessor()
processor.document_processor = Mock()
processor.resume_extractor = Mock()
processor.document_processor.extract_text.return_value = "resume text"
processor.resume_extractor.extract.return_value = ResumeExtractedProfile(
email=None,
github_username=None,
linkedin_url=None,
phone=None,
additional_emails=["alt@example.com"],
availability="10-15 hours/week",
rate_range="$80 - $120",
referred_by="Referral Source",
address_state="California",
address_country=None,
confidence=0.95,
source="gpt-4o-mini",
skills=[],
skill_attrs={},
)
response = Mock()
response.status_code = 200
response.content = b"resume-bytes"
response.raise_for_status = Mock()
response.headers = {}
response.iter_content = Mock(return_value=[b"resume-bytes"])
response.__enter__ = Mock(return_value=response)
response.__exit__ = Mock(return_value=None)
with (
patch(
"five08.worker.crm.intake_form_processor.requests.get",
return_value=response,
),
patch.object(processor, "_hostname_resolves_publicly", return_value=True),
patch.object(processor, "_scan_resume_content", return_value=True),
):
updates = processor._build_resume_updates(
{
"resume_url": "https://example.com/resume.pdf",
}
)
assert updates["cAvailableTimes"] == "10-15 hours/week"
assert updates["cRateRange"] == "$80 - $120"
assert updates["cReferredBy"] == "Referral Source"
assert updates["addressState"] == "California"
def test_build_intake_updates_includes_form_website_and_weekly_hours() -> None:
processor = IntakeFormProcessor()
updates = processor._build_intake_updates(
email="new@example.com",
first_name="New",
last_name="Person",
payload={
"website_link": "portfolio.example.com",
"ideal_weekly_hours": "8-10",
},
include_email=True,
)
assert updates["cWebsiteLink"] == ["https://portfolio.example.com"]
assert "Ideal weekly hours: 8-10" in updates["description"]
def test_build_resume_updates_skips_parsing_when_scan_fails() -> None:
processor = IntakeFormProcessor()
processor.document_processor = Mock()
response = Mock()
response.status_code = 200
response.raise_for_status = Mock()
response.headers = {}
response.iter_content = Mock(return_value=[b"resume-bytes"])
response.__enter__ = Mock(return_value=response)
response.__exit__ = Mock(return_value=None)
with (
patch(
"five08.worker.crm.intake_form_processor.requests.get",
return_value=response,
),
patch.object(processor, "_hostname_resolves_publicly", return_value=True),
patch.object(processor, "_scan_resume_content", return_value=False),
):
updates = processor._build_resume_updates(
{
"resume_url": "https://example.com/resume.pdf",
}
)
assert updates == {}
processor.document_processor.extract_text.assert_not_called()
def test_resume_url_log_mask_strips_signed_query_parameters() -> None:
processor = IntakeFormProcessor()
masked = processor._mask_resume_url_for_log(
"https://storage.googleapis.com/tally/resume.pdf?signature=secret&token=hidden"
)
assert masked == "https://storage.googleapis.com/tally/resume.pdf"
def test_build_resume_updates_rejects_non_https_resume_url() -> None:
processor = IntakeFormProcessor()
with patch("five08.worker.crm.intake_form_processor.requests.get") as mock_get:
updates = processor._build_resume_updates(
{
"resume_url": "http://example.com/resume.pdf",
}
)
assert updates == {}
mock_get.assert_not_called()
def test_build_resume_updates_rejects_private_ip_resume_url() -> None:
processor = IntakeFormProcessor()
with patch("five08.worker.crm.intake_form_processor.requests.get") as mock_get:
updates = processor._build_resume_updates(
{
"resume_url": "https://127.0.0.1/resume.pdf",
}
)
assert updates == {}
mock_get.assert_not_called()
def test_build_resume_updates_rejects_resume_host_outside_allowlist(
monkeypatch: pytest.MonkeyPatch,
) -> None:
processor = IntakeFormProcessor()
monkeypatch.setattr(
"five08.worker.crm.intake_form_processor.settings.intake_resume_allowed_hosts",
"allowed.example",
)
with patch("five08.worker.crm.intake_form_processor.requests.get") as mock_get:
updates = processor._build_resume_updates(
{
"resume_url": "https://blocked.example/resume.pdf",
}
)
assert updates == {}
mock_get.assert_not_called()
def test_download_resume_content_follows_redirects_within_limit() -> None:
"""Resume download should follow redirects up to the configured limit."""
processor = IntakeFormProcessor()
# Mock responses: first redirect, second redirect, then final content
redirect_1 = Mock()
redirect_1.status_code = 302
redirect_1.headers = {"Location": "https://cdn.example.com/resume-v2.pdf"}
redirect_1.__enter__ = Mock(return_value=redirect_1)
redirect_1.__exit__ = Mock(return_value=None)
redirect_2 = Mock()
redirect_2.status_code = 302
redirect_2.headers = {"Location": "https://cdn.example.com/resume-final.pdf"}
redirect_2.__enter__ = Mock(return_value=redirect_2)
redirect_2.__exit__ = Mock(return_value=None)
final = Mock()
final.status_code = 200
final.raise_for_status = Mock()
final.iter_content = Mock(return_value=[b"resume", b"data"])
final.__enter__ = Mock(return_value=final)
final.__exit__ = Mock(return_value=None)
with (
patch(
"five08.worker.crm.intake_form_processor.requests.get",
side_effect=[redirect_1, redirect_2, final],
),
patch.object(processor, "_hostname_resolves_publicly", return_value=True),
):
content = processor._download_resume_content("https://example.com/resume.pdf")
assert content == b"resumedata"
def test_download_resume_content_exceeds_max_redirects() -> None:
"""Resume download should fail when exceeding max redirect limit."""
processor = IntakeFormProcessor()
# Create redirect responses
redirect = Mock()
redirect.status_code = 302
redirect.headers = {"Location": "https://example.com/redirect-1"}
redirect.__enter__ = Mock(return_value=redirect)
redirect.__exit__ = Mock(return_value=None)
with (
patch(
"five08.worker.crm.intake_form_processor.requests.get",
return_value=redirect,
),
patch.object(processor, "_hostname_resolves_publicly", return_value=True),
pytest.raises(ValueError, match="exceeded max redirect limit"),
):
processor._download_resume_content("https://example.com/resume.pdf")
def test_download_resume_content_enforces_file_size_limit() -> None:
"""Resume download should stop when file exceeds size limit."""
processor = IntakeFormProcessor()
# Mock a response that exceeds the size limit
response = Mock()
response.status_code = 200
response.raise_for_status = Mock()
response.headers = {}
response.iter_content = Mock(
return_value=[b"x" * 5 * 1024 * 1024, b"y" * 6 * 1024 * 1024] # 5MB + 6MB
)
response.__enter__ = Mock(return_value=response)
response.__exit__ = Mock(return_value=None)
with (
patch(
"five08.worker.crm.intake_form_processor.requests.get",
return_value=response,
),
patch.object(processor, "_hostname_resolves_publicly", return_value=True),
pytest.raises(ValueError, match="exceeds maximum allowed size"),
):
processor._download_resume_content("https://example.com/resume.pdf")
def test_download_resume_content_checks_content_length_header() -> None:
"""Resume download should fail early if Content-Length exceeds limit."""
processor = IntakeFormProcessor()
response = Mock()
response.status_code = 200
response.headers = {"Content-Length": str(20 * 1024 * 1024)} # 20MB
response.raise_for_status = Mock()
response.__enter__ = Mock(return_value=response)
response.__exit__ = Mock(return_value=None)
with (
patch(
"five08.worker.crm.intake_form_processor.requests.get",
return_value=response,
),
patch.object(processor, "_hostname_resolves_publicly", return_value=True),
pytest.raises(ValueError, match="exceeds maximum allowed size"),
):
processor._download_resume_content("https://example.com/resume.pdf")