Skip to content

Commit e4025d8

Browse files
authored
[codex] Add admin dashboard job lead review (#374)
* Add admin dashboard job lead review * Remove redundant job lead post reconciliation
1 parent 8b98c75 commit e4025d8

24 files changed

Lines changed: 3149 additions & 201 deletions

File tree

apps/admin_dashboard/src/dashboard-utils.test.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import {
55
displayOnboarder,
66
formatDate,
77
githubUrl,
8+
isTerminalJobStatus,
89
labelForOnboardingState,
910
linkedinUrl,
1011
onboardingStateValue,
@@ -50,4 +51,14 @@ describe("dashboard utility helpers", () => {
5051
it("includes the year in formatted timestamps", () => {
5152
expect(formatDate("2026-01-27T02:26:00Z")).toContain("2026")
5253
})
54+
55+
it("identifies terminal background job statuses", () => {
56+
expect(isTerminalJobStatus("succeeded")).toBe(true)
57+
expect(isTerminalJobStatus(" failed ")).toBe(false)
58+
expect(isTerminalJobStatus("dead")).toBe(true)
59+
expect(isTerminalJobStatus("canceled")).toBe(true)
60+
expect(isTerminalJobStatus("queued")).toBe(false)
61+
expect(isTerminalJobStatus("running")).toBe(false)
62+
expect(isTerminalJobStatus(undefined)).toBe(false)
63+
})
5364
})

apps/admin_dashboard/src/dashboard-utils.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,14 @@ export function jsonPreview(value: unknown) {
5252
return JSON.stringify(value, null, 2)
5353
}
5454

55+
export function isTerminalJobStatus(value?: string | null) {
56+
return ["succeeded", "dead", "canceled"].includes(
57+
String(value || "")
58+
.trim()
59+
.toLowerCase(),
60+
)
61+
}
62+
5563
export function onboardingStateValue(person: OnboardingStateCarrier) {
5664
return person.onboarding_state || person.onboardingState || person.cOnboardingState || ""
5765
}

0 commit comments

Comments
 (0)