Fix project account manager setup

Ensure ERPNext project creation adds the selected account manager to the project roster and contact portal user when possible, while surfacing non-fatal setup warnings.

Author: michaelmwu

apps/admin_dashboard/src/main.tsx

@@ -1131,6 +1131,8 @@ function App() {
         activity_type: { name?: string }
         cache_refresh_error?: string
         cache_refresh_message?: string
+        setup_warnings?: string[]
+        setup_warning_message?: string
       }>("/dashboard/api/projects/create", {
         method: "POST",
         headers: { "Content-Type": "application/json" },
@@ -1145,12 +1147,23 @@ function App() {
               )
             : [payload.project, ...current]
         })
-        showToast("Created ERP project setup", "ok")
+        showToast(
+          payload.setup_warnings?.length
+            ? payload.setup_warning_message ||
+                "Created ERP project setup; account manager setup needs follow-up"
+            : "Created ERP project setup",
+          payload.setup_warnings?.length ? "warning" : "ok",
+        )
         openProjectDetail(payload.project.id)
       } else {
+        const cacheRefreshMessage =
+          payload.cache_refresh_message || "Created ERP project in ERPNext; local sync is pending"
+        const setupWarningMessage = payload.setup_warnings?.length
+          ? payload.setup_warning_message || "Account manager setup needs follow-up"
+          : ""
         showToast(
-          payload.cache_refresh_message || "Created ERP project in ERPNext; local sync is pending",
-          "ok",
+          [cacheRefreshMessage, setupWarningMessage].filter(Boolean).join(" "),
+          payload.setup_warnings?.length ? "warning" : "ok",
         )
         void loadProjects()
       }

apps/api/src/five08/backend/api.py

@@ -3696,6 +3696,7 @@ def _create_erpnext_project_setup(
 
     cache_refresh_error: str | None = None
     cache_refresh_message: str | None = None
+    setup_warnings: list[str] = []
     client = _erpnext_client()
     try:
         activity_type = client.ensure_activity_type(activity_type_name)
@@ -3743,6 +3744,18 @@ def cleanup_created_customer() -> None:
         if erpnext_project_id is None:
             cleanup_created_customer()
             raise ERPNextAPIError("ERPNext Project response is missing an id")
+        if account_manager is not None:
+            try:
+                project_detail = client.add_project_user(
+                    erpnext_project_id, account_manager
+                )
+            except ERPNextAPIError:
+                logger.exception(
+                    "ERPNext Project was created but account manager roster setup failed project=%s account_manager=%s",
+                    erpnext_project_id,
+                    account_manager,
+                )
+                setup_warnings.append("account_manager_project_user_failed")
 
         address_doc: dict[str, Any] | None = None
         if has_address:
@@ -3778,6 +3791,21 @@ def cleanup_created_customer() -> None:
                 phone=_text_or_none(payload.contact_phone),
                 mobile_no=_text_or_none(payload.contact_mobile),
             )
+        if account_manager is not None and contact_doc is not None:
+            contact_doc_id = _text_or_none(contact_doc.get("name"))
+            if contact_doc_id is not None:
+                try:
+                    contact_doc = client.set_contact_portal_user(
+                        contact=contact_doc_id,
+                        portal_user=account_manager,
+                    )
+                except ERPNextAPIError:
+                    logger.exception(
+                        "ERPNext Contact was linked but portal user setup failed contact=%s account_manager=%s",
+                        contact_doc_id,
+                        account_manager,
+                    )
+                    setup_warnings.append("account_manager_contact_user_failed")
 
         primary_address = (
             _text_or_none(address_doc.get("name")) if address_doc is not None else None
@@ -3834,6 +3862,11 @@ def cleanup_created_customer() -> None:
         result["cache_refresh_error"] = cache_refresh_error
     if cache_refresh_message is not None:
         result["cache_refresh_message"] = cache_refresh_message
+    if setup_warnings:
+        result["setup_warnings"] = setup_warnings
+        result["setup_warning_message"] = (
+            "Created the project, but account manager setup needs follow-up."
+        )
     return result
 
 
@@ -4525,7 +4558,9 @@ async def dashboard_create_project_handler(request: Request) -> JSONResponse:
     actor_provider, actor_subject = _session_audit_actor(session)
     await _write_auth_audit_event(
         action="erpnext.project_setup_create",
-        result=AuditResult.SUCCESS,
+        result=AuditResult.ERROR
+        if isinstance(result.get("setup_warnings"), list)
+        else AuditResult.SUCCESS,
         actor_subject=actor_subject,
         actor_display_name=session.display_name,
         actor_provider=actor_provider,
@@ -4543,6 +4578,7 @@ async def dashboard_create_project_handler(request: Request) -> JSONResponse:
             "primary_contact": contact.get("name")
             if isinstance(contact, dict)
             else None,
+            "setup_warnings": result.get("setup_warnings"),
         },
     )
     return JSONResponse(result, status_code=201)

apps/api/src/five08/backend/static/dashboard/.vite/manifest.json

@@ -1,6 +1,6 @@
 {
   "index.html": {
-    "file": "assets/index-BA0o_Cce.js",
+    "file": "assets/index-D0EL0k11.js",
     "name": "index",
     "src": "index.html",
     "isEntry": true,

…tatic/dashboard/assets/index-BA0o_Cce.js …tatic/dashboard/assets/index-D0EL0k11.jsapps/api/src/five08/backend/static/dashboard/assets/index-BA0o_Cce.js renamed to apps/api/src/five08/backend/static/dashboard/assets/index-D0EL0k11.js apps/api/src/five08/backend/static/dashboard/assets/index-BA0o_Cce.js renamed to apps/api/src/five08/backend/static/dashboard/assets/index-D0EL0k11.js

@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>508 Operations Dashboard</title>
-    <script type="module" crossorigin src="/dashboard/assets/index-BA0o_Cce.js"></script>
+    <script type="module" crossorigin src="/dashboard/assets/index-D0EL0k11.js"></script>
     <link rel="stylesheet" crossorigin href="/dashboard/assets/index-DaV5VIHY.css">
   </head>
   <body>

apps/api/src/five08/backend/static/dashboard/index.html

@@ -447,6 +447,7 @@ def create_contact(
         email_id: str | None = None,
         phone: str | None = None,
         mobile_no: str | None = None,
+        portal_user: str | None = None,
     ) -> dict[str, Any]:
         """Create one Contact linked to a Customer."""
         normalized_customer = customer.strip()
@@ -475,13 +476,40 @@ def create_contact(
             payload.setdefault("phone_nos", []).append(
                 {"phone": normalized_mobile, "is_primary_mobile_no": 1}
             )
+        normalized_portal_user = (portal_user or "").strip()
+        if normalized_portal_user:
+            payload["user"] = normalized_portal_user
         return self.create_record("Contact", payload)
 
+    def set_contact_portal_user(
+        self,
+        *,
+        contact: str,
+        portal_user: str,
+    ) -> dict[str, Any]:
+        """Set Contact.user when the Contact does not already have one."""
+        normalized_contact = contact.strip()
+        normalized_portal_user = portal_user.strip()
+        if not normalized_contact:
+            raise ERPNextAPIError("Contact is required")
+        if not normalized_portal_user:
+            raise ERPNextAPIError("Portal user is required")
+        contact_doc = self.get_record("Contact", normalized_contact)
+        existing_user = str(contact_doc.get("user") or "").strip()
+        if existing_user:
+            return contact_doc
+        return self.update_record(
+            "Contact",
+            normalized_contact,
+            {"user": normalized_portal_user},
+        )
+
     def link_contact_to_customer(
         self,
         *,
         contact: str,
         customer: str,
+        portal_user: str | None = None,
     ) -> dict[str, Any]:
         """Ensure an existing Contact has a Customer link."""
         normalized_contact = contact.strip()
@@ -499,17 +527,22 @@ def link_contact_to_customer(
             and link.get("link_name") == normalized_customer
             for link in existing_links
         ):
+            links = existing_links
+        else:
+            links = [
+                *existing_links,
+                {"link_doctype": "Customer", "link_name": normalized_customer},
+            ]
+        updates: dict[str, Any] = {}
+        if links != existing_links:
+            updates["links"] = links
+        normalized_portal_user = (portal_user or "").strip()
+        existing_user = str(contact_doc.get("user") or "").strip()
+        if normalized_portal_user and not existing_user:
+            updates["user"] = normalized_portal_user
+        if not updates:
             return contact_doc
-        return self.update_record(
-            "Contact",
-            normalized_contact,
-            {
-                "links": [
-                    *existing_links,
-                    {"link_doctype": "Customer", "link_name": normalized_customer},
-                ]
-            },
-        )
+        return self.update_record("Contact", normalized_contact, updates)
 
     def set_customer_primary_records(
         self,