Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions apps/admin_dashboard/src/dashboard-utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
displayOnboarder,
formatDate,
githubUrl,
isTerminalJobStatus,
labelForOnboardingState,
linkedinUrl,
onboardingStateValue,
Expand Down Expand Up @@ -50,4 +51,14 @@ describe("dashboard utility helpers", () => {
it("includes the year in formatted timestamps", () => {
expect(formatDate("2026-01-27T02:26:00Z")).toContain("2026")
})

it("identifies terminal background job statuses", () => {
expect(isTerminalJobStatus("succeeded")).toBe(true)
expect(isTerminalJobStatus(" failed ")).toBe(false)
expect(isTerminalJobStatus("dead")).toBe(true)
expect(isTerminalJobStatus("canceled")).toBe(true)
expect(isTerminalJobStatus("queued")).toBe(false)
expect(isTerminalJobStatus("running")).toBe(false)
expect(isTerminalJobStatus(undefined)).toBe(false)
})
})
8 changes: 8 additions & 0 deletions apps/admin_dashboard/src/dashboard-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ export function jsonPreview(value: unknown) {
return JSON.stringify(value, null, 2)
}

export function isTerminalJobStatus(value?: string | null) {
return ["succeeded", "dead", "canceled"].includes(
String(value || "")
.trim()
.toLowerCase(),
)
}

export function onboardingStateValue(person: OnboardingStateCarrier) {
return person.onboarding_state || person.onboardingState || person.cOnboardingState || ""
}
Expand Down
Loading