[codex] Add admin job channel management#377
Conversation
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (16)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_0a07b3d5-0b9b-4716-9af8-6b4d4fa92ac3) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ff8a79549
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| UNKNOWN = "unknown" | ||
| LOST = "lost" | ||
| OUTDATED = "outdated" | ||
| DUPLICATE = "duplicate" |
There was a problem hiding this comment.
Adding this enum value makes the dashboard and Discord commands accept duplicate, but the current Alembic status constraint still only allows lead, recruiting, filled, unknown, lost, and outdated in apps/worker/src/five08/worker/migrations/versions/20260708_0100_add_lead_engagement_status.py. In a migrated Postgres database, choosing Duplicate causes update_engagement_status to run UPDATE engagements SET status = 'duplicate', which violates ck_engagements_status; the dashboard request will 500 and the Discord command will report that the status update failed. Add a migration that updates the check constraint before exposing this status.
Useful? React with 👍 / 👎.
| </Select> | ||
| <Select | ||
| aria-label="New job channel posting type" | ||
| value={selectedPostingType} |
There was a problem hiding this comment.
When this top form is pointed at an already registered channel, selectedPostingType stays at its initial or previous value instead of the selected channel's current posting_type. For example, if there are no unregistered forums left and the first registered channel is full_time, the form still shows/sends part_time, so clicking “Update channel” silently rewrites that channel to the wrong posting type. Initialize or update this state from selectedChannel.posting_type, or restrict this form to unregistered channels.
Useful? React with 👍 / 👎.
| return JSONResponse( | ||
| await _dashboard_job_channels_payload(request, include_available=True) | ||
| ) |
There was a problem hiding this comment.
When deleting a forum whose name matches DISCORD_DEFAULT_JOB_FORUM_CHANNELS (the defaults include gigs and fulltime-roles) and the bot internal endpoint is configured, this follow-up payload call asks the bot for channel metadata; JobsCog.list_registered_job_post_forums() refreshes the cache and calls _register_default_job_forum_channels(), which inserts missing default forums back into job_post_channels. The DELETE can therefore return success while the channel immediately reappears as registered, so explicit deregistration does not work for default forums.
Useful? React with 👍 / 👎.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_38587155-1905-457d-b39c-e442e2a091d4) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 960a8efb13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| try: | ||
| removed = await asyncio.to_thread( | ||
| unregister_job_post_channel, |
There was a problem hiding this comment.
When an admin deregisters a forum whose name matches DISCORD_DEFAULT_JOB_FORUM_CHANNELS, this only deletes the job_post_channels row. The bot still auto-registers those defaults during later normal channel loads/posts (list_registered_job_post_forums() with defaults enabled and _resolve_job_lead_post_channel()), so after this delete the next Gigs-page channel load or lead post recreates the row and the forum resumes receiving job leads. The fresh evidence in the current tree is that the delete response avoids immediate default registration, but this delete path still records no opt-out for the later auto-registration calls.
Useful? React with 👍 / 👎.
| created = await asyncio.to_thread( | ||
| register_job_post_channel, |
There was a problem hiding this comment.
When this dashboard path creates a new registration or changes a forum's posting type, it only writes job_post_channels and refreshes the channel list; unlike the Discord /register-jobs-channel command, it never calls the bot's _start_forum_backfill_task. If an admin registers a forum that already has posts, or changes an existing forum's posting type, those existing threads keep missing/stale dashboard engagement rows until a bot restart or a separate Discord registration triggers backfill, so the new Configure action does not fully enable matching for already-posted jobs.
Useful? React with 👍 / 👎.
| if isinstance(available_channels, list) | ||
| else channels | ||
| ) | ||
| return payload |
There was a problem hiding this comment.
When the bot is reachable, this returns the bot's live channels list as authoritative for the new management tab, but the bot skips registered IDs it can no longer fetch with 403/404. If a registered forum was deleted or the bot lost access, the row remains in job_post_channels and can still make lead posting fall through to no_registered_job_forum, yet it disappears from the dashboard so admins cannot see or deregister it without calling the API manually. Merge in the DB rows (or have the bot return unresolved registered IDs) for the configuration view.
Useful? React with 👍 / 👎.
1 participant
Summary
Adds job channel management to the admin dashboard Configure view. Admins can now inspect registered Discord job forums, register a new forum from the live Discord channel list, change posting type between part-time/full-time/both/unknown, and deregister a channel.
Also adds a
duplicategig status. Updating a gig toduplicatefrom the dashboard or Discord command marks the thread title and closes/locks the Discord forum post, matching the existing close behavior forlost.Impact
#job-channels, so refreshes preserve the selected tab.Validation
bun run typecheckbun run test -- configuration-view.test.tsxbun run biome check src/views/configuration-view.tsx src/configuration-view.test.tsx src/main.tsxuv run ruff check packages/shared/src/five08/engagements.py apps/api/src/five08/backend/api.py apps/api/src/five08/backend/routes.py apps/api/src/five08/backend/schemas.py apps/discord_bot/src/five08/discord_bot/cogs/jobs.py apps/discord_bot/src/five08/discord_bot/utils/internal_api.pyuv run python3 -m compileall packages/shared/src/five08/engagements.py apps/api/src/five08/backend/api.py apps/api/src/five08/backend/routes.py apps/api/src/five08/backend/schemas.py apps/discord_bot/src/five08/discord_bot/cogs/jobs.py apps/discord_bot/src/five08/discord_bot/utils/internal_api.pybun run buildNote
Medium Risk
New configuration-write endpoints change which Discord forums accept job posts; mistakes could misroute leads, though auditing and permission checks mitigate operator error.
Overview
Adds a Job channels tab to the admin Configuration view (hash-backed, including
#job-channels) so operators can list registered Discord job forums, pick from live guild forum channels, set posting type, register/update, and deregister channels. The dashboard loads channels withinclude_available=trueand wires PUT/DELETE on/dashboard/api/job-channels/{channel_id}throughmain.tsx.The API extends job-channel listing with optional
available_channels, stricter read permission when including available forums, andregister_defaults=falsewhen talking to the bot so registration stays explicit. Register/update/delete persist viaregister_job_post_channel/unregister_job_post_channel, return refreshed payloads, and are audited underconfiguration:writewith same-origin checks.The gigs UI treats
duplicatelikelostfor failed-style badges. Tests cover the new configuration tab and channel actions; static dashboard assets are rebuilt.Reviewed by Cursor Bugbot for commit 960a8ef. Bugbot is set up for automated code reviews on this repo. Configure here.