Improve database resource management and IPC input handling#578
Open
RohitKattimani wants to merge 1 commit into
Open
Improve database resource management and IPC input handling#578RohitKattimani wants to merge 1 commit into
RohitKattimani wants to merge 1 commit into
Conversation
Ensure agent_id defaults to 0 and close connection safely.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a potential resource leak and improves the robustness of the IPC command handling. These changes are non-breaking and maintain the existing simulation logic while improving overall stability.
Changes Made
_get_interview_resultto use afinallyblock forconn.close(). This ensures that the database connection is always released, even ifjson.loadsor a cursor operation throws an exception, preventing silent file descriptor leaks.0when retrievingagent_idinhandle_batch_interview. This standardizes behavior with the existinghandle_interviewmethod and prevents potentialNoneTypeerrors if a command is sent with a missing key.Testing