Skip to content

feat: GPU_HNSW index using faiss::gpu::GpuIndexHNSW (slim, feature-only)#5

Closed
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/gpu-hnsw-feature-only
Closed

feat: GPU_HNSW index using faiss::gpu::GpuIndexHNSW (slim, feature-only)#5
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/gpu-hnsw-feature-only

Conversation

@devin-ai-integration

Copy link
Copy Markdown

Summary

Slim, review-friendly version of the GPU_HNSW feature currently on gpu-hnsw-faiss (PR #2).

The gpu-hnsw-faiss branch mixes the feature with a full upstream sync (faiss upgrade + SINDI/sparse) via a Merge upstream/main commit, so its diff-vs-main is ~19.5k lines / 189 files. This branch rebases only the feature onto current main and squashes the noisy development history (perf experiments + their reverts) into one commit, so the diff is exactly the feature:

src/index/hnsw/faiss_hnsw.cc                       (GPU_HNSW IndexNode wiring)
include/knowhere/comp/index_param.h                (GPU_HNSW index type)
include/knowhere/index/index_table.h
cmake/libs/lib{faiss,diskann}.cmake                (faiss_gpu_hnsw target)
tests/ut/test_gpu_search.cc                        (recall / cosine / topk / serialize tests)
thirdparty/faiss/faiss/gpu/**                      (vendored GpuIndexHNSW kernel)
→ 14 files, +2559 / -2

No upstream sync, no reverted char4/dp4a experiments — just the final feature.

Relationship to other PRs:

Not build-verified locally in this session; tree is byte-identical to gpu-hnsw-faiss^1.

Link to Devin session: https://6sense.devinenterprise.com/sessions/d39aba56b8a3467cbbf231ab631a06ed

Feature-only, rebased onto current main. Squashes the GPU_HNSW development
history (perf experiments + their reverts) into a single commit and drops
the unrelated upstream sync (faiss upgrade / SINDI / sparse) that the
gpu-hnsw-faiss branch also carried, so the diff is just the GPU_HNSW feature
(14 files, +2559).

Signed-off-by: Devin AI <devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Author

Superseded: this content is now folded directly into the clean gpu-hnsw-faiss branch (rebased onto synced upstream master, dead-code/GPU_TIMING cleanups included). Closing.

@devin-ai-integration devin-ai-integration Bot deleted the devin/gpu-hnsw-feature-only branch July 9, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants