feat: GPU_HNSW index using faiss::gpu::GpuIndexHNSW (slim, feature-only)#5
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
feat: GPU_HNSW index using faiss::gpu::GpuIndexHNSW (slim, feature-only)#5devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Feature-only, rebased onto current main. Squashes the GPU_HNSW development history (perf experiments + their reverts) into a single commit and drops the unrelated upstream sync (faiss upgrade / SINDI / sparse) that the gpu-hnsw-faiss branch also carried, so the diff is just the GPU_HNSW feature (14 files, +2559). Signed-off-by: Devin AI <devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
|
Superseded: this content is now folded directly into the clean gpu-hnsw-faiss branch (rebased onto synced upstream master, dead-code/GPU_TIMING cleanups included). Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slim, review-friendly version of the GPU_HNSW feature currently on
gpu-hnsw-faiss(PR #2).The
gpu-hnsw-faissbranch mixes the feature with a full upstream sync (faiss upgrade + SINDI/sparse) via aMerge upstream/maincommit, so its diff-vs-main is ~19.5k lines / 189 files. This branch rebases only the feature onto currentmainand squashes the noisy development history (perf experiments + their reverts) into one commit, so the diff is exactly the feature:No upstream sync, no reverted
char4/dp4aexperiments — just the final feature.Relationship to other PRs:
gpu-hnsw-faiss→ main). If we prefer to keep landing viagpu-hnsw-faiss, this branch is still useful as the clean diff to review against.Not build-verified locally in this session; tree is byte-identical to
gpu-hnsw-faiss^1.Link to Devin session: https://6sense.devinenterprise.com/sessions/d39aba56b8a3467cbbf231ab631a06ed