chore: share acp legacy error adapter

Author: wangtsiao

crates/server/src/runtime/handlers/acp.rs

@@ -88,7 +88,7 @@ mod session_support;
 
 use history::acp_update_from_history_item;
 use mcp::acp_mcp_config;
-use response::legacy_error_to_acp;
+pub(super) use response::legacy_error_to_acp;
 use session_support::decode_session_list_cursor;
 use session_support::encode_session_list_cursor;
 use session_support::validate_acp_session_roots;

crates/server/src/runtime/handlers/acp/response.rs

@@ -1,6 +1,6 @@
 use super::*;
 
-pub(super) fn legacy_error_to_acp(
+pub(in crate::runtime::handlers) fn legacy_error_to_acp(
     request_id: serde_json::Value,
     legacy_response: serde_json::Value,
 ) -> serde_json::Value {

crates/server/src/runtime/handlers/acp_slash_commands.rs

@@ -2,6 +2,8 @@ use super::super::*;
 
 use std::sync::Arc;
 
+use super::acp::legacy_error_to_acp;
+
 use devo_protocol::GoalClearParams;
 use devo_protocol::GoalClearResult;
 use devo_protocol::GoalSetParams;
@@ -23,7 +25,6 @@ use crate::AcpSessionNotification;
 use crate::AcpSessionUpdate;
 use crate::AcpStopReason;
 use crate::CollaborationMode;
-use crate::ErrorResponse;
 use crate::InputItem;
 use crate::SessionCompactParams;
 use crate::SessionCompactResult;
@@ -503,21 +504,6 @@ fn acp_prompt_success_response(request_id: serde_json::Value) -> serde_json::Val
     )
 }
 
-fn legacy_error_to_acp(
-    request_id: serde_json::Value,
-    legacy_response: serde_json::Value,
-) -> serde_json::Value {
-    if let Ok(error) = serde_json::from_value::<ErrorResponse>(legacy_response) {
-        acp_error_response(request_id, AcpErrorCode::ServerError, error.error.message)
-    } else {
-        acp_error_response(
-            request_id,
-            AcpErrorCode::InternalError,
-            "failed to decode internal runtime response",
-        )
-    }
-}
-
 fn goal_summary_message(goal: &ThreadGoal) -> String {
     let status = goal_status_label(goal.status);
     let objective = &goal.objective;