fix(audio): apply playlist clip fades

Author: 808StaN

src/audio/core/useTransportScheduler.js

@@ -10,6 +10,10 @@ import { useEffect, useRef } from "react";
 import { clamp } from "../../store/utils";
 import { computeSamplePlaybackParams } from "./computeSamplePlaybackParams";
 import { createSamplePlaybackNodes } from "./createSamplePlaybackNodes";
+import {
+  applySampleGainAutomation,
+  computeSampleFadeParams,
+} from "./sampleGainAutomation";
 import {
   DEFAULT_SAMPLE_MIDI_PITCH,
   midiPitchToPlaybackRate,
@@ -323,7 +327,6 @@ export function useTransportScheduler({
           ),
         );
 
-        const fadeOutAt = time + Math.max(0, playDuration - 0.012);
         const clipGain = Math.max(
           MIN_DURATION_SEC,
           Number(channel?.volume ?? 0.75) *
@@ -336,9 +339,13 @@ export function useTransportScheduler({
 
         source.buffer = scheduledBuffer;
         source.playbackRate.setValueAtTime(playbackRate, time);
-        gain.gain.setValueAtTime(clipGain, time);
-        gain.gain.setValueAtTime(clipGain, fadeOutAt);
-        gain.gain.linearRampToValueAtTime(0.0001, time + playDuration);
+        applySampleGainAutomation(
+          gain.gain,
+          time,
+          playDuration,
+          clipGain,
+          computeSampleFadeParams(playDuration, settings),
+        );
         panner.pan.setValueAtTime(clipPan, time);
 
         source.connect(gain);

src/audio/exportProjectAudio.js

@@ -6,6 +6,10 @@ import { applyInsertSettings } from "./core/applyInsertSettings";
 import { createMixerInsertNodes } from "./core/createMixerInsertNodes";
 import { computeSamplePlaybackParams } from "./core/computeSamplePlaybackParams";
 import { createSamplePlaybackNodes } from "./core/createSamplePlaybackNodes";
+import {
+  applySampleGainAutomation,
+  computeSampleFadeParams,
+} from "./core/sampleGainAutomation";
 import { DEFAULT_SAMPLE_MIDI_PITCH, midiPitchToPlaybackRate } from "./domain/pitch";
 import { getSafeSampleSettings } from "./domain/sampleSettings";
 import { getTimeStretchProfile } from "./domain/timeStretch";
@@ -747,7 +751,6 @@ export async function renderPlaylistArrangementToFile(options) {
         playDuration * playbackRate,
       ),
     );
-    const fadeOutAt = clipStartTime + Math.max(0, playDuration - 0.012);
     const clipGain = Math.max(
       MIN_DURATION_SEC,
       Number(channel?.volume ?? 0.75) *
@@ -764,9 +767,13 @@ export async function renderPlaylistArrangementToFile(options) {
 
     source.buffer = scheduledBuffer;
     source.playbackRate.setValueAtTime(playbackRate, clipStartTime);
-    gain.gain.setValueAtTime(clipGain, clipStartTime);
-    gain.gain.setValueAtTime(clipGain, fadeOutAt);
-    gain.gain.linearRampToValueAtTime(0.0001, clipStartTime + playDuration);
+    applySampleGainAutomation(
+      gain.gain,
+      clipStartTime,
+      playDuration,
+      clipGain,
+      computeSampleFadeParams(playDuration, settings),
+    );
     panner.pan.setValueAtTime(clipPan, clipStartTime);
 
     source.connect(gain);

src/test/setup.js

@@ -11,7 +11,7 @@ globalThis.AudioContext = class AudioContext {
     return { duration: length / sampleRate, length, sampleRate, numberOfChannels: channels };
   }
   createGain() {
-    return { connect: vi.fn(), gain: { value: 1, setValueAtTime: vi.fn(), linearRampToValueAtTime: vi.fn() } };
+    return { connect: vi.fn(), gain: { value: 1, setValueAtTime: vi.fn(), linearRampToValueAtTime: vi.fn(), exponentialRampToValueAtTime: vi.fn() } };
   }
   createBufferSource() {
     return { connect: vi.fn(), start: vi.fn(), stop: vi.fn(), playbackRate: { value: 1 } };
@@ -44,7 +44,7 @@ globalThis.OfflineAudioContext = class OfflineAudioContext {
     return { connect: vi.fn(), start: vi.fn(), stop: vi.fn(), playbackRate: { value: 1 } };
   }
   createGain() {
-    return { connect: vi.fn(), gain: { value: 1 } };
+    return { connect: vi.fn(), gain: { value: 1, setValueAtTime: vi.fn(), linearRampToValueAtTime: vi.fn(), exponentialRampToValueAtTime: vi.fn() } };
   }
   createStereoPanner() {
     return { connect: vi.fn(), pan: { value: 0 } };