Replace ava with Node's built-in test runner#16
Merged
Conversation
Removes the ava -> supertap -> js-yaml@3 dependency chain. Tests now run via node:test + node:assert through tsx, with no new dependencies
There was a problem hiding this comment.
Pull request overview
This PR migrates the project’s test suite from ava to Node’s built-in node:test runner (using node:assert/strict), primarily to eliminate the ava → supertap → js-yaml@3 dependency chain and reduce the indirect dependency surface.
Changes:
- Replaced
avaassertions withnode:assert/strictacross the TypeScript tests. - Updated
npm testto run tests viatsx --test. - Removed
avafrom devDependencies and pruned its transitive dependencies frompackage-lock.json.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/test.ts |
Switched test runner and assertions for the UDP/auth integration test. |
test/message.ts |
Migrated Message unit tests from ava to node:test + assert. |
test/ipv6.ts |
Migrated IPv6 parsing unit tests from ava to node:test + assert. |
package.json |
Replaced the ava test script/config with a tsx --test invocation and removed ava devDependency. |
package-lock.json |
Removed ava and a large set of now-unneeded transitive dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
11
to
16
| await new Promise<void>((resolve, reject) => { | ||
| server.on('message', (msg) => { | ||
| t.is(msg.length, 96) | ||
| assert.equal(msg.length, 96) | ||
| server.close() | ||
| resolve() | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
this must also have been an issue before? prefer not to touch it in this PR as it's about changing the runner, nothing else
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/84codes/sparoid.js/security/dependabot/25 and the huge reduction in (indirect) dependencies is a win.
WHAT is this pull request doing?
Removes the ava -> supertap -> js-yaml@3 dependency chain.
Tests now run via node:test + node:assert through tsx, with no new dependencies
HOW was this pull request tested?
Tests