Completed todo in tests#18
Open
ThatUdeshUK wants to merge 2 commits into99x-incubator:masterfrom
ThatUdeshUK:tests
Open
Completed todo in tests#18ThatUdeshUK wants to merge 2 commits into99x-incubator:masterfrom ThatUdeshUK:tests
ThatUdeshUK wants to merge 2 commits into99x-incubator:masterfrom
ThatUdeshUK:tests
Conversation
rajitha1998
reviewed
Jan 7, 2020
| const expect = chai.expect; | ||
|
|
||
| const Validator = require("../src/"); | ||
| var Validator = require("../src"); |
There was a problem hiding this comment.
Using const makes the most sense here. Since we don't want to overwrite the Validator variable which contains the library that has been imported. Is there any reason that it has to be changed to var @UdeshUK .
Author
There was a problem hiding this comment.
Yes, that makes sense. I'll revert it back.
Author
|
@rajitha1998 Reverted the validator import to a const |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #1
Fixed the todo in test.js to test the validator