Skip to content

Refactor capabilities requester#34

Merged
leongross merged 1 commit into
buildupfrom
mgudel/fix/capabilities
Mar 12, 2026
Merged

Refactor capabilities requester#34
leongross merged 1 commit into
buildupfrom
mgudel/fix/capabilities

Conversation

@embediver
Copy link
Copy Markdown

  • Implement a correct check for cap. response flags
  • Create type aliases to clarify GET_CAPABILITIES and CAPABILITIES
  • Fix CAPABILITIES response handler

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 70 files.

Valid Invalid Ignored Fixed
0 56 14 0
Click to see the invalid file list
  • examples/platform/cert_store.rs
  • examples/platform/certs.rs
  • examples/platform/crypto.rs
  • examples/platform/evidence.rs
  • examples/platform/mod.rs
  • examples/platform/socket_transport.rs
  • examples/spdm_requester.rs
  • examples/spdm_responder.rs
  • examples/test_static_certs.rs
  • src/cert_store.rs
  • src/chunk_ctx.rs
  • src/codec.rs
  • src/commands/algorithms/mod.rs
  • src/commands/algorithms/request.rs
  • src/commands/algorithms/response.rs
  • src/commands/capabilities/mod.rs
  • src/commands/capabilities/request.rs
  • src/commands/capabilities/response.rs
  • src/commands/certificate/mod.rs
  • src/commands/certificate/request.rs
  • src/commands/certificate/response.rs
  • src/commands/challenge_auth_rsp.rs
  • src/commands/chunk_get_rsp.rs
  • src/commands/digests/mod.rs
  • src/commands/digests/request.rs
  • src/commands/digests/response.rs
  • src/commands/error_rsp.rs
  • src/commands/measurements_rsp.rs
  • src/commands/mod.rs
  • src/commands/version/mod.rs
  • src/commands/version/request.rs
  • src/commands/version/response.rs
  • src/context.rs
  • src/error.rs
  • src/lib.rs
  • src/measurements/common.rs
  • src/measurements/freeform_manifest.rs
  • src/measurements/mod.rs
  • src/platform/evidence.rs
  • src/platform/hash.rs
  • src/platform/mod.rs
  • src/platform/rng.rs
  • src/platform/transport.rs
  • src/protocol/algorithms.rs
  • src/protocol/capabilities.rs
  • src/protocol/certs.rs
  • src/protocol/common.rs
  • src/protocol/mod.rs
  • src/protocol/signature.rs
  • src/protocol/version.rs
  • src/requester.rs
  • src/state.rs
  • src/test.rs
  • src/transcript.rs
  • src/transport.rs
  • tests/spdm_validator_host.rs
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

@@ -1 +1 @@
// Licensed under the Apache-2.0 license
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2025
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// Licensed under the Apache-2.0 license

@@ -1,9 +1,13 @@
// Licensed under the Apache-2.0 license
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Licensed under the Apache-2.0 license
// Copyright 2025
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// Licensed under the Apache-2.0 license

@@ -1 +1 @@
// Licensed under the Apache-2.0 license
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2025
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// Licensed under the Apache-2.0 license

@embediver
Copy link
Copy Markdown
Author

Resolves #33 .
Also fixes the tests.

@embediver embediver requested a review from leongross February 19, 2026 08:47
@embediver embediver force-pushed the mgudel/fix/capabilities branch 2 times, most recently from 7ca4835 to cc678c2 Compare February 24, 2026 11:33
- Implement a correct check for cap. response flags
- Create type aliases to clarify GET_CAPABILITIES and CAPABILITIES
- Fix CAPABILITIES response handler
@embediver embediver force-pushed the mgudel/fix/capabilities branch from cc678c2 to c54137b Compare March 9, 2026 10:39
Copy link
Copy Markdown
Member

@leongross leongross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@leongross leongross merged commit 3abf5a2 into buildup Mar 12, 2026
4 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants