Add built-in download tool#20
Draft
ZhiXiao-Lin wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
downloadtool inspired by Surge's range probe, adaptive chunking, bounded retry, sequential fallback, and atomic finalizationweb_fetch, including DNS pinning, manual redirect validation, proxy support, credential isolation, and redacted source anchorsValidation
cargo fmt --all -- --checkcargo check -p a3s-code-corecargo clippy -p a3s-code-core --lib -- -D warningscargo test -p a3s-code-core --test test_workspace_backend custom_workspace_file_tools_do_not_touch_local_filesystem: passedagent_api::tests::test_verify_commands_builds_report_from_bash_resultsruns the Unix commandprintf okthrough the Windows PowerShell-backed BashTool and fails independently when rerun in isolation.Reference
Implementation principles were checked against Surge's probe, concurrent worker, scheduler fallback, and sync-then-rename finalization behavior.