Skip to content

Commit 2bb45a7

Browse files
RoyLinRoyLin
authored andcommitted
ci(publish-ts): align napi triples to the 3-platform matrix + token on prepublish + fix YAML
- napi.triples: 6 declared but matrix builds 3 → prepublish referenced unbuilt platform packages. Now exactly linux-x64-gnu / darwin-arm64 / win-x64. - NODE_AUTH_TOKEN at job level so napi prepublish (publishes per-platform packages) is authed too. - fixed a fragile ${{ }} expression inside YAML flow braces (block style).
1 parent a6aa175 commit 2bb45a7

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

.github/workflows/publish-ts.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ jobs:
3030
- uses: actions/setup-node@v4
3131
with: { node-version: "20" }
3232
- uses: dtolnay/rust-toolchain@stable
33-
with: { targets: ${{ matrix.settings.target }} }
33+
with:
34+
targets: ${{ matrix.settings.target }}
3435
- run: npm install
3536
- run: npm run build -- --target ${{ matrix.settings.target }}
3637
- run: npm test
@@ -42,6 +43,10 @@ jobs:
4243
publish:
4344
needs: build
4445
runs-on: ubuntu-latest
46+
# NODE_AUTH_TOKEN applies to ALL steps: `napi prepublish` publishes the per-platform packages and
47+
# `npm publish` the main one — both need the token.
48+
env:
49+
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
4550
steps:
4651
- uses: actions/checkout@v4
4752
with: { submodules: true }
@@ -56,5 +61,3 @@ jobs:
5661
- run: npx napi artifacts --dir artifacts
5762
- run: npx napi prepublish -t npm
5863
- run: npm publish --access public
59-
env:
60-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

sdk/typescript/package.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,11 @@
1212
"napi": {
1313
"name": "a3s-sentry",
1414
"triples": {
15-
"defaults": true,
15+
"defaults": false,
1616
"additional": [
1717
"x86_64-unknown-linux-gnu",
18-
"x86_64-unknown-linux-musl",
19-
"aarch64-unknown-linux-gnu",
20-
"aarch64-unknown-linux-musl",
21-
"aarch64-apple-darwin"
18+
"aarch64-apple-darwin",
19+
"x86_64-pc-windows-msvc"
2220
]
2321
}
2422
},

0 commit comments

Comments
 (0)