lint fix nil assertions

willwade · willwade · commit 1bf96918ce48 · 2025-11-18T19:48:41.000Z
diff --git a/src/processors/astericsGridProcessor.ts b/src/processors/astericsGridProcessor.ts
@@ -1197,18 +1197,18 @@ class AstericsGridProcessor extends BaseProcessor {
         imageData = Buffer.from(base64Data, 'base64');
 
         // Use detected format for filename
-      imageName = element.image.id || `image.${imageFormat}`;
-    } catch (e) {
-      // Invalid base64 data, skip image
+        imageName = element.image.id || `image.${imageFormat}`;
+      } catch (e) {
+        // Invalid base64 data, skip image
+      }
     }
-  }
 
-  return new AACButton({
-    id: element.id,
-    label: label,
-    message: label,
+    return new AACButton({
+      id: element.id,
+      label: label,
+      message: label,
 
-    targetPageId: targetPageId || undefined,
+      targetPageId: targetPageId || undefined,
 
       semanticAction: semanticAction,
       audioRecording: audioRecording,
diff --git a/test/errorHandling.test.ts b/test/errorHandling.test.ts
@@ -152,6 +152,7 @@ describe('Error Handling', () => {
       const processor = new SnapProcessor();
       const invalidData = Buffer.from('invalid sqlite data');
 
+      // eslint-disable-next-line @typescript-eslint/no-var-requires
       const tempFilesBefore = fs.readdirSync(require('os').tmpdir()).length;
 
       expect(() => {
@@ -160,6 +161,7 @@ describe('Error Handling', () => {
 
       // Give some time for cleanup
       setTimeout(() => {
+        // eslint-disable-next-line @typescript-eslint/no-var-requires
         const tempFilesAfter = fs.readdirSync(require('os').tmpdir()).length;
         expect(tempFilesAfter).toBeLessThanOrEqual(tempFilesBefore + 1); // Allow for some variance
       }, 100);
diff --git a/test/gridsetProcessor.test.ts b/test/gridsetProcessor.test.ts
@@ -25,9 +25,9 @@ describe('GridsetProcessor', () => {
 
   describe('Error Handling', () => {
     it('should throw error for non-existent file', () => {
-      const processor = new GridsetProcessor();
+      const _processor = new GridsetProcessor();
       expect(() => {
-        const nonExistentBuffer = fs.readFileSync('/non/existent/file.gridset');
+        const _nonExistentBuffer = fs.readFileSync('/non/existent/file.gridset');
       }).toThrow();
     });
 
diff --git a/test/gridsetWordlistHelpers.test.ts b/test/gridsetWordlistHelpers.test.ts
@@ -159,7 +159,11 @@ describe('Grid3 Wordlist Helpers', () => {
       expect(wordlists.size).toBe(1);
       expect(wordlists.has('Greetings')).toBe(true);
 
-      const wordlist = wordlists.get('Greetings')!;
+      const wordlist = wordlists.get('Greetings');
+      expect(wordlist).toBeDefined();
+      if (!wordlist) {
+        return;
+      }
       expect(wordlist.items).toHaveLength(2);
       expect(wordlist.items[0].text).toBe('hello');
       expect(wordlist.items[0].image).toBe('[WIDGIT]hello.emf');
@@ -205,8 +209,14 @@ describe('Grid3 Wordlist Helpers', () => {
 </Grid>`;
       };
 
-      zip.addFile('Grids/Greetings/grid.xml', Buffer.from(createGrid('Greetings', ['hello', 'hi']), 'utf8'));
-      zip.addFile('Grids/Farewells/grid.xml', Buffer.from(createGrid('Farewells', ['goodbye', 'bye']), 'utf8'));
+      zip.addFile(
+        'Grids/Greetings/grid.xml',
+        Buffer.from(createGrid('Greetings', ['hello', 'hi']), 'utf8')
+      );
+      zip.addFile(
+        'Grids/Farewells/grid.xml',
+        Buffer.from(createGrid('Farewells', ['goodbye', 'bye']), 'utf8')
+      );
 
       const wordlists = extractWordlists(zip.toBuffer());
 
@@ -243,7 +253,9 @@ describe('Grid3 Wordlist Helpers', () => {
     function createTestGridset(gridName: string, initialWordlistXml?: string): Buffer {
       const zip = new AdmZip();
 
-      const wordlistSection = initialWordlistXml || `<WordList>
+      const wordlistSection =
+        initialWordlistXml ||
+        `<WordList>
   <Items>
     <WordListItem>
       <Text><s><r>old</r></s></Text>
@@ -285,7 +297,11 @@ describe('Grid3 Wordlist Helpers', () => {
       const wordlists = extractWordlists(updated);
 
       expect(wordlists.has('Greetings')).toBe(true);
-      const wordlist = wordlists.get('Greetings')!;
+      const wordlist = wordlists.get('Greetings');
+      expect(wordlist).toBeDefined();
+      if (!wordlist) {
+        return;
+      }
       expect(wordlist.items).toHaveLength(3);
       expect(wordlist.items.map((i) => i.text)).toEqual(['hello', 'hi', 'hey']);
     });
@@ -300,7 +316,11 @@ describe('Grid3 Wordlist Helpers', () => {
       const updated = updateWordlist(gridset, 'Greetings', newWordlist);
       const wordlists = extractWordlists(updated);
 
-      const wordlist = wordlists.get('Greetings')!;
+      const wordlist = wordlists.get('Greetings');
+      expect(wordlist).toBeDefined();
+      if (!wordlist) {
+        return;
+      }
       expect(wordlist.items[0].image).toBe('[WIDGIT]hello.emf');
       expect(wordlist.items[0].partOfSpeech).toBe('Interjection');
     });
@@ -363,4 +383,3 @@ describe('Grid3 Wordlist Helpers', () => {
     });
   });
 });
-
diff --git a/test/integration.test.ts b/test/integration.test.ts
@@ -69,7 +69,7 @@ describe('Integration Tests', () => {
       const outputFile = path.join(tempDir, 'cli_output.json');
 
       try {
-        const result = execSync(`node ${cliPath} extract-texts ${dotFile} ${outputFile}`, {
+        const _result = execSync(`node ${cliPath} extract-texts ${dotFile} ${outputFile}`, {
           encoding: 'utf8',
           stdio: 'pipe',
         });
@@ -285,7 +285,7 @@ describe('Integration Tests', () => {
       if (translations.size > 0) {
         // Apply translations in DOT format
         const translatedDotPath = path.join(tempDir, 'translated.dot');
-        const translatedDotResult = dotProcessor.processTexts(
+        const _translatedDotResult = dotProcessor.processTexts(
           Buffer.from(dotContent),
           translations,
           translatedDotPath
@@ -352,7 +352,7 @@ describe('Integration Tests', () => {
 
       // Step 4: Apply translations
       const translatedPath = path.join(tempDir, 'workflow_translated.dot');
-      const translatedResult = processor.processTexts(
+      const _translatedResult = processor.processTexts(
         Buffer.from(originalContent),
         translations,
         translatedPath
diff --git a/test/memoryLeaks.test.ts b/test/memoryLeaks.test.ts
@@ -4,9 +4,6 @@ import path from 'path';
 import { performance } from 'perf_hooks';
 import { DotProcessor } from '../src/processors/dotProcessor';
 import { SnapProcessor } from '../src/processors/snapProcessor';
-import { TouchChatProcessor } from '../src/processors/touchchatProcessor';
-import { ObfProcessor } from '../src/processors/obfProcessor';
-import { GridsetProcessor } from '../src/processors/gridsetProcessor';
 import { AACTree, AACPage, AACButton } from '../src/core/treeStructure';
 
 describe('Memory Leak Detection Tests', () => {
@@ -403,6 +400,7 @@ describe('Memory Leak Detection Tests', () => {
       const processor = new SnapProcessor();
 
       const memBefore = getMemoryUsage();
+      // eslint-disable-next-line @typescript-eslint/no-var-requires
       const tempFilesBefore = fs.readdirSync(require('os').tmpdir()).length;
 
       // Perform operations that create temporary files
@@ -430,6 +428,7 @@ describe('Memory Leak Detection Tests', () => {
       // Give some time for cleanup
       setTimeout(() => {
         const memAfter = getMemoryUsage();
+        // eslint-disable-next-line @typescript-eslint/no-var-requires
         const tempFilesAfter = fs.readdirSync(require('os').tmpdir()).length;
 
         const memoryIncrease = memAfter.heapUsed - memBefore.heapUsed;
diff --git a/test/obfProcessor.roundtrip.test.ts b/test/obfProcessor.roundtrip.test.ts
@@ -2,7 +2,7 @@
 import fs from 'fs';
 import path from 'path';
 import { ObfProcessor } from '../src/processors/obfProcessor';
-import { AACTree } from '../src/core/treeStructure';
+import { AACTree, AACPage, AACButton } from '../src/core/treeStructure';
 
 describe('OBFProcessor round-trip', () => {
   const obfPath: string = path.join(__dirname, '../examples/example.obf');
@@ -73,13 +73,13 @@ describe('OBFProcessor round-trip', () => {
 
     // Create a simple tree programmatically
     const tree1 = new AACTree();
-    const page = new (require('../src/core/treeStructure').AACPage)({
+    const page = new AACPage({
       id: 'test-page',
       name: 'Test Page',
       buttons: [],
     });
 
-    const button = new (require('../src/core/treeStructure').AACButton)({
+    const button = new AACButton({
       id: 'test-button',
       label: 'Test Button',
       message: 'Hello World',
@@ -106,7 +106,7 @@ describe('OBFProcessor round-trip', () => {
     const processor = new ObfProcessor();
     const tree = new AACTree();
 
-    const page = new (require('../src/core/treeStructure').AACPage)({
+    const page = new AACPage({
       id: 'meta-page',
       name: 'Meta Page',
       grid: [
@@ -116,7 +116,7 @@ describe('OBFProcessor round-trip', () => {
       locale: 'en',
     });
 
-    const AACButtonCtor = require('../src/core/treeStructure').AACButton;
+    const AACButtonCtor = AACButton;
     const buttonA = new AACButtonCtor({
       id: 'btn-a',
       label: 'A',
diff --git a/test/obfProcessor.test.ts b/test/obfProcessor.test.ts
@@ -1,8 +1,8 @@
 // Test for OBFProcessor (Open Board Format/Zip)
-import fs from 'fs';
+// Test for OBFProcessor (Open Board Format/Zip)
 import path from 'path';
 import { ObfProcessor } from '../src/processors/obfProcessor';
-import { AACButton, AACPage, AACTree } from '../src/core/treeStructure';
+import { AACTree } from '../src/core/treeStructure';
 
 describe('OBFProcessor', () => {
   const obzPath: string = path.join(__dirname, '../examples/example.obz');
@@ -22,7 +22,8 @@ describe('OBFProcessor', () => {
     });
     expect(navFound).toBe(true);
     // Check image on button if present
-    const rootPage = tree.getPage(tree.rootId!);
+    const rootId = tree.rootId;
+    const rootPage = rootId ? tree.getPage(rootId) : undefined;
     if (rootPage) {
       const imgBtn = rootPage.buttons.find((b: any) => b.image);
       if (imgBtn) {
diff --git a/test/opmlProcessor.test.ts b/test/opmlProcessor.test.ts
@@ -13,9 +13,10 @@ describe('OPMLProcessor', () => {
     // Should have at least one page
     expect(Object.keys(tree.pages).length).toBeGreaterThan(0);
     // Super root should have a navigation button to root
-    const superRoot = tree.getPage(tree.rootId!);
+    const rootId = tree.rootId;
+    const superRoot = rootId ? tree.getPage(rootId) : undefined;
     expect(superRoot).toBeDefined();
-    expect(superRoot!.buttons.length).toBeGreaterThan(0);
+    expect(superRoot?.buttons.length).toBeGreaterThan(0);
     // There should be at least one navigation button in the tree
     let navFound = false;
     tree.traverse((page) => {
diff --git a/test/performance.memory.test.ts b/test/performance.memory.test.ts
@@ -4,7 +4,7 @@ import path from 'path';
 import { TouchChatProcessor } from '../src/processors/touchchatProcessor';
 import { SnapProcessor } from '../src/processors/snapProcessor';
 import { DotProcessor } from '../src/processors/dotProcessor';
-import { TreeFactory, PageFactory, ButtonFactory } from './utils/testFactories';
+import { TreeFactory } from './utils/testFactories';
 
 describe('Memory Performance Tests', () => {
   const tempDir = path.join(__dirname, 'temp_performance');
@@ -221,7 +221,7 @@ describe('Memory Performance Tests', () => {
     it('should maintain memory usage under 100MB for large files', () => {
       const processor = new SnapProcessor();
 
-      const { result: tree, memoryUsedMB } = measureMemoryUsage(() => {
+      const { result: tree, memoryUsedMB: _memoryUsedMB } = measureMemoryUsage(() => {
         const tree = TreeFactory.createLarge(100, 20); // 2000 buttons
 
         // Add moderate audio content
@@ -258,7 +258,7 @@ describe('Memory Performance Tests', () => {
     it('should handle very large hierarchies efficiently', () => {
       const processor = new DotProcessor();
 
-      const { result: tree, memoryUsedMB } = measureMemoryUsage(() => {
+      const { result: tree, memoryUsedMB: _memoryUsedMB } = measureMemoryUsage(() => {
         return TreeFactory.createLarge(200, 10); // 200 pages, 10 buttons each
       });
 
diff --git a/test/performance.test.ts b/test/performance.test.ts
@@ -1,15 +1,9 @@
 // Performance tests for all processors
 import fs from 'fs';
 import path from 'path';
-import os from 'os';
 import { performance } from 'perf_hooks';
 import { DotProcessor } from '../src/processors/dotProcessor';
-import { OpmlProcessor } from '../src/processors/opmlProcessor';
-import { ObfProcessor } from '../src/processors/obfProcessor';
-import { GridsetProcessor } from '../src/processors/gridsetProcessor';
 import { SnapProcessor } from '../src/processors/snapProcessor';
-import { TouchChatProcessor } from '../src/processors/touchchatProcessor';
-import { ApplePanelsProcessor } from '../src/processors/applePanelsProcessor';
 import { AACTree, AACPage, AACButton } from '../src/core/treeStructure';
 
 describe('Performance Tests', () => {
@@ -184,8 +178,8 @@ describe('Performance Tests', () => {
 
       // Perform many operations
       for (let i = 0; i < 10; i++) {
-        const tree = processor.loadIntoTree(Buffer.from(testContent));
-        const texts = processor.extractTexts(Buffer.from(testContent));
+        const _tree = processor.loadIntoTree(Buffer.from(testContent));
+        const _texts = processor.extractTexts(Buffer.from(testContent));
 
         // Force garbage collection if available
         if (global.gc) {
diff --git a/test/processTexts.test.ts b/test/processTexts.test.ts
@@ -152,13 +152,19 @@ describe('ProcessTexts functionality', () => {
       // Find the main page (might have different ID after round-trip)
       const mainPage = pages.find((p) => p.name === 'Página Principal');
       expect(mainPage).toBeDefined();
-      expect(mainPage!.name).toBe('Página Principal');
+      if (!mainPage) {
+        return;
+      }
+      expect(mainPage.name).toBe('Página Principal');
 
       // Find the hello button by label
-      const helloButton = mainPage!.buttons.find((b) => b.label === 'Hola');
+      const helloButton = mainPage.buttons.find((b) => b.label === 'Hola');
       expect(helloButton).toBeDefined();
-      expect(helloButton!.label).toBe('Hola');
-      expect(helloButton!.message).toBe('Hola Mundo');
+      if (!helloButton) {
+        return;
+      }
+      expect(helloButton.label).toBe('Hola');
+      expect(helloButton.message).toBe('Hola Mundo');
     });
 
     it('should translate OBF content', () => {
diff --git a/test/snapProcessor.audio.comprehensive.test.ts b/test/snapProcessor.audio.comprehensive.test.ts
diff --git a/test/snapProcessor.corruption.performance.test.ts b/test/snapProcessor.corruption.performance.test.ts
diff --git a/test/snapProcessor.coverage.test.ts b/test/snapProcessor.coverage.test.ts
diff --git a/test/touchchatProcessor.comprehensive.test.ts b/test/touchchatProcessor.comprehensive.test.ts
diff --git a/test/touchchatProcessor.coverage.test.ts b/test/touchchatProcessor.coverage.test.ts
diff --git a/test/utils/testHelpers.ts b/test/utils/testHelpers.ts
