Commit 2360e04
fix: Use 0-based coordinates for Grid3 image resolution
Grid3 image files are named with 0-based coordinates (e.g., 1-2-0-text-0.jpeg),
but we were passing 1-based coordinates to the image resolver (x: cellX + 1, y: cellY + 1).
This caused images to fail resolving because:
- Cell at XML position X="2" Y="3" converts to cellX=1, cellY=2 (0-based)
- We passed x=2, y=3 to resolver (adding +1)
- Resolver looked for file named "2-3-0-text-0.jpeg"
- But actual file is named "1-2-0-text-0.jpeg" (0-based naming)
Fix: Pass 0-based coordinates (cellX, cellY) directly to resolver.
This fixes broken images in aac-board-viewer when viewing Grid3 gridsets
with coordinate-prefixed image names.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>1 parent 9f5f684 commit 2360e04
51 files changed
Lines changed: 1436 additions & 2 deletions
File tree
- examples
- example-images
- Grids/Start
- Settings0
- Styles
- WebBrowser
- src/processors
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Binary file not shown.
Binary file not shown.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
0 commit comments