Skip to content

Commit 2360e04

Browse files
willwadeclaude
andcommitted
fix: Use 0-based coordinates for Grid3 image resolution
Grid3 image files are named with 0-based coordinates (e.g., 1-2-0-text-0.jpeg), but we were passing 1-based coordinates to the image resolver (x: cellX + 1, y: cellY + 1). This caused images to fail resolving because: - Cell at XML position X="2" Y="3" converts to cellX=1, cellY=2 (0-based) - We passed x=2, y=3 to resolver (adding +1) - Resolver looked for file named "2-3-0-text-0.jpeg" - But actual file is named "1-2-0-text-0.jpeg" (0-based naming) Fix: Pass 0-based coordinates (cellX, cellY) directly to resolver. This fixes broken images in aac-board-viewer when viewing Grid3 gridsets with coordinate-prefixed image names. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 9f5f684 commit 2360e04

51 files changed

Lines changed: 1436 additions & 2 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

examples/.DS_Store

6 KB
Binary file not shown.

examples/example-images.zip

235 KB
Binary file not shown.
Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
<FileMap xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
2+
<Entries>
3+
<Entry StaticFile="Grids\Start\grid.xml">
4+
<DynamicFiles>
5+
<File>Grids\Start\0-1-0-text-0.png</File>
6+
<File>Grids\Start\0-2-0-text-0.jpeg</File>
7+
<File>Grids\Start\0-3-0-text-0.jpeg</File>
8+
<File>Grids\Start\0-4-0-text-0.jpeg</File>
9+
<File>Grids\Start\0-5-0-text-0.jpeg</File>
10+
<File>Grids\Start\1-1-0-text-0.jpeg</File>
11+
<File>Grids\Start\1-2-0-text-0.jpeg</File>
12+
<File>Grids\Start\1-3-0-text-0.jpeg</File>
13+
<File>Grids\Start\1-4-0-text-0.jpeg</File>
14+
<File>Grids\Start\1-5-0-text-0.jpeg</File>
15+
<File>Grids\Start\10-3-0-text-0.jpeg</File>
16+
<File>Grids\Start\10-4-0-text-0.jpeg</File>
17+
<File>Grids\Start\11-3-0-text-0.jpeg</File>
18+
<File>Grids\Start\11-4-0-text-0.jpeg</File>
19+
<File>Grids\Start\2-1-0-text-0.jpeg</File>
20+
<File>Grids\Start\2-2-0-text-0.jpeg</File>
21+
<File>Grids\Start\2-3-0-text-0.jpeg</File>
22+
<File>Grids\Start\2-4-0-text-0.jpeg</File>
23+
<File>Grids\Start\2-5-0-text-0.jpeg</File>
24+
<File>Grids\Start\3-1-0-text-0.jpeg</File>
25+
<File>Grids\Start\3-3-0-text-0.jpeg</File>
26+
<File>Grids\Start\3-4-0-text-0.jpeg</File>
27+
<File>Grids\Start\3-5-0-text-0.jpeg</File>
28+
<File>Grids\Start\4-1-0-text-0.jpeg</File>
29+
<File>Grids\Start\4-3-0-text-0.jpeg</File>
30+
<File>Grids\Start\4-4-0-text-0.jpeg</File>
31+
<File>Grids\Start\4-5-0-text-0.jpeg</File>
32+
<File>Grids\Start\5-4-0-text-0.jpeg</File>
33+
<File>Grids\Start\5-5-0-text-0.jpeg</File>
34+
<File>Grids\Start\6-3-0-text-0.jpeg</File>
35+
<File>Grids\Start\6-4-0-text-0.jpeg</File>
36+
<File>Grids\Start\7-1-0-text-0.jpeg</File>
37+
<File>Grids\Start\7-2-0-text-0.jpeg</File>
38+
<File>Grids\Start\7-3-0-text-0.jpeg</File>
39+
<File>Grids\Start\7-4-0-text-0.jpeg</File>
40+
<File>Grids\Start\8-1-0-text-0.jpeg</File>
41+
<File>Grids\Start\8-2-0-text-0.jpeg</File>
42+
<File>Grids\Start\8-3-0-text-0.jpeg</File>
43+
<File>Grids\Start\8-4-0-text-0.jpeg</File>
44+
<File>Grids\Start\9-1.png</File>
45+
<File>Grids\Start\9-2.png</File>
46+
<File>Grids\Start\9-3-0-text-0.jpeg</File>
47+
<File>Grids\Start\9-4-0-text-0.jpeg</File>
48+
</DynamicFiles>
49+
</Entry>
50+
</Entries>
51+
</FileMap>
7.8 KB
3.48 KB
4.81 KB
3.32 KB
4.04 KB
3.2 KB
3.48 KB

0 commit comments

Comments
 (0)