fix bug

Author: willwade

src/utilities/analytics/morphology/engine.ts

@@ -21,23 +21,13 @@ export class MorphologyEngine {
   }
 
   static fromGrid3Verbs(verbForms: Grid3VerbForms): MorphologyEngine {
-    const engine = new MorphologyEngine({
-      locale: verbForms.locale,
-      version: 1,
-      irregular: {},
-      regular: {},
-    });
+    const engine = new MorphologyEngine(verbForms.locale.replace('_', '-'));
     engine.grid3Verbs = verbForms.verbs;
     return engine;
   }
 
   static fromTDSnapLexicon(lexiconData: TDSnapLexiconData): MorphologyEngine {
-    const engine = new MorphologyEngine({
-      locale: lexiconData.locale,
-      version: 1,
-      irregular: {},
-      regular: {},
-    });
+    const engine = new MorphologyEngine(lexiconData.locale.replace('_', '-'));
     engine.tdsnapLexicon = lexiconData;
     return engine;
   }

test/grammarGating.test.ts

@@ -101,29 +101,23 @@ describe('Grammar Gating', () => {
       expect(forms).toContain('having');
     });
 
-    test('returns empty for words not in the verb map when no built-in rules', () => {
+    test('returns built-in forms for words not in the verb map', () => {
       const forms = engine.inflect('walk', 'Verb');
-      expect(forms).toEqual([]);
-    });
-
-    test('returns empty for non-verb words when no built-in rules', () => {
-      const forms = engine.inflect('child', 'Noun');
-      expect(forms).toEqual([]);
-    });
-
-    test('standalone engine with built-in rules inflects walk', () => {
-      const builtin = new MorphologyEngine('en-gb');
-      const forms = builtin.inflect('walk', 'Verb');
       expect(forms).toContain('walks');
       expect(forms).toContain('walked');
       expect(forms).toContain('walking');
     });
 
-    test('standalone engine with built-in rules inflects child', () => {
-      const builtin = new MorphologyEngine('en-gb');
-      const forms = builtin.inflect('child', 'Noun');
+    test('returns built-in forms for non-verb words', () => {
+      const forms = engine.inflect('child', 'Noun');
       expect(forms).toContain('children');
     });
+
+    test('prefers verb map forms over built-in rules for map verbs', () => {
+      const forms = engine.inflect('drink', 'Verb');
+      expect(forms).toContain('drunk');
+      expect(forms).toContain('drank');
+    });
   });
 
   describe('{gerund} Placeholder Filtering', () => {