fixing more tests

Author: willwade

README.md

@@ -761,16 +761,16 @@ Inspired by the Python AACProcessors project
 
 ### 🧪 Current Test Status & Immediate Follow-Up
 
-As of the latest run (`npm test`), **45 suites pass / 8 fail (11 individual tests)**. The remaining reds are concentrated in the following areas:
+As of the latest run (`npm test`), **47 suites pass / 6 fail (10 individual tests)**. Remaining blockers are:
 
-1. **SnapProcessor coverage harness** – our in-memory fixture lacks the full Snap schema (`ElementPlacement`, `Message`, etc.), so the loader now rejects it as incomplete. Update the test database (or adjust expectations) to include Grid coordinates and message columns so audio assertions execute again.
-2. **Gridset exports** – round-trip still sheds one button and the styling suite cannot find `style.xml`. Investigate GridsetProcessor save logic to ensure button arrays and style archives are written faithfully.
-3. **Dot round-tripping** – property-based DOT tests collapse navigation for certain generated trees (buttons fall back to `SPEAK`). We need better semantic mapping when recreating `DotProcessor` buttons.
-4. **Edge-case loaders** – corrupted JSON/XML cases no longer throw; align Asterics/OPML/DOT loaders with the test expectations (either rethrow earlier or update the tests to accept soft-fail behaviour).
-5. **Advanced workflow scenario** – translated Spanish content isn’t discovered after the multi-format pipeline (likely Gridset/TMP Snap translation gaps). Trace the pipeline and ensure translated text survives each hop.
-6. **Memory comparison suite** – DOT still reports higher memory delta than TouchChat/Snap. Validate memory measurement or re-tune the processors.
+1. **Edge-case loaders** – corrupted JSON/XML fixtures still expect explicit exceptions. Decide whether to restore the old throwing behaviour (Asterics/OPML/DOT) or update the tests to accept the softer error reporting.
+2. **Gridset exports & styling** – round-trip continues to lose a button and the styling suite cannot find `style.xml`. GridsetProcessor needs to preserve button arrays and emit the styling assets Grid 3 expects.
+3. **DOT navigation semantics** – the deterministic DOT test still falls back to `SPEAK`. Improve semantic reconstruction when loading navigation edges so navigation buttons survive round-trips.
+4. **Advanced workflow scenario** – the multi-format pipeline still loses Spanish translations (likely during the Gridset ⇄ Snap steps); trace text propagation and patch the conversion chain.
+5. **Styling suite** – Grid 3 export still lacks `style.xml`; ensure the styling assets are generated alongside the gridset payload.
+6. **Memory comparison suite** – memory delta expectations are still unmet (TouchChat GC + DOT vs others). Either recalibrate the harness or tune the processors before re-enabling the assertions.
 
-Addressing these will move us much closer to a releasable state; once Snap coverage fixtures and Gridset exports are stabilised we should see a substantial drop in failing suites.
+Clearing these items will put the test matrix back in the green and unblock the release.
 
 ## More enhancements
 

test/cli.comprehensive.test.ts

@@ -15,14 +15,10 @@ describe('CLI Comprehensive Tests', () => {
       fs.mkdirSync(tempDir, { recursive: true });
     }
 
-    // Ensure CLI is built
-    try {
-      execSync('npm run build', {
-        cwd: path.join(__dirname, '..'),
-        stdio: 'pipe',
-      });
-    } catch (error) {
-      console.warn('Build failed, CLI tests may not work properly');
+    if (!fs.existsSync(cliPath)) {
+      throw new Error(
+        'dist/cli/index.js is missing – run `npm run build` before executing the CLI tests.'
+      );
     }
   });
 

test/cli/cli.dot.integration.test.js

@@ -8,11 +8,9 @@ describe("aac-processors CLI (DOT)", () => {
   beforeAll(() => {
     const cliPath = path.join(__dirname, "../../dist/cli/index.js");
     if (!fs.existsSync(cliPath)) {
-      console.log("🔨 Building project for CLI tests...");
-      execSync("npm run build", {
-        stdio: "inherit",
-        cwd: path.join(__dirname, "../.."),
-      });
+      throw new Error(
+        "dist/cli/index.js is missing – run `npm run build` before executing the CLI tests."
+      );
     }
   });
   const cliPath = path.join(__dirname, "../../dist/cli/index.js");

test/cli/cli.integration.test.js

@@ -7,11 +7,9 @@ describe("aac-processors CLI", () => {
   beforeAll(() => {
     const cliPath = path.join(__dirname, "../../dist/cli/index.js");
     if (!fs.existsSync(cliPath)) {
-      console.log("🔨 Building project for CLI tests...");
-      execSync("npm run build", {
-        stdio: "inherit",
-        cwd: path.join(__dirname, "../.."),
-      });
+      throw new Error(
+        "dist/cli/index.js is missing – run `npm run build` before executing the CLI tests."
+      );
     }
   });
   const cliPath = path.join(__dirname, "../../dist/cli/index.js");

test/cli/cli.obf.integration.test.js

@@ -8,11 +8,9 @@ describe("aac-processors CLI (OBF/OBZ)", () => {
   beforeAll(() => {
     const cliPath = path.join(__dirname, "../../dist/cli/index.js");
     if (!fs.existsSync(cliPath)) {
-      console.log("🔨 Building project for CLI tests...");
-      execSync("npm run build", {
-        stdio: "inherit",
-        cwd: path.join(__dirname, "../.."),
-      });
+      throw new Error(
+        "dist/cli/index.js is missing – run `npm run build` before executing the CLI tests."
+      );
     }
   });
   const cliPath = path.join(__dirname, "../../dist/cli/index.js");

test/cli/cli.opml.integration.test.js

@@ -8,11 +8,9 @@ describe("aac-processors CLI (OPML)", () => {
   beforeAll(() => {
     const cliPath = path.join(__dirname, "../../dist/cli/index.js");
     if (!fs.existsSync(cliPath)) {
-      console.log("🔨 Building project for CLI tests...");
-      execSync("npm run build", {
-        stdio: "inherit",
-        cwd: path.join(__dirname, "../.."),
-      });
+      throw new Error(
+        "dist/cli/index.js is missing – run `npm run build` before executing the CLI tests."
+      );
     }
   });
   const cliPath = path.join(__dirname, "../../dist/cli/index.js");

test/cli/cli.snap.integration.test.js

@@ -7,11 +7,9 @@ describe("aac-processors CLI (Snap)", () => {
   beforeAll(() => {
     const cliPath = path.join(__dirname, "../../dist/cli/index.js");
     if (!fs.existsSync(cliPath)) {
-      console.log("🔨 Building project for CLI tests...");
-      execSync("npm run build", {
-        stdio: "inherit",
-        cwd: path.join(__dirname, "../.."),
-      });
+      throw new Error(
+        "dist/cli/index.js is missing – run `npm run build` before executing the CLI tests."
+      );
     }
   });
   const cliPath = path.join(__dirname, "../../dist/cli/index.js");

test/snapProcessor.coverage.test.ts

@@ -1,5 +1,5 @@
 import { SnapProcessor } from '../src/processors/snapProcessor';
-import { AACTree, AACPage, AACButton } from '../src/core/treeStructure';
+import { TreeFactory } from './utils/testFactories';
 import path from 'path';
 import fs from 'fs';
 import Database from 'better-sqlite3';
@@ -22,34 +22,24 @@ describe('SnapProcessor Coverage', () => {
 
   describe('Audio Handling', () => {
     it('should load audio data when loadAudio is true', () => {
-      // Setup a dummy database with audio
+      const saveProcessor = new SnapProcessor();
+      const tree = TreeFactory.createSimple();
+      saveProcessor.saveFromTree(tree, tempDbPath);
+
       const db = new Database(tempDbPath);
-      db.exec(`
-        CREATE TABLE Page (Id INTEGER PRIMARY KEY, UniqueId TEXT, Name TEXT);
-        CREATE TABLE Button (Id INTEGER PRIMARY KEY, Label TEXT, MessageRecordingId INTEGER, ElementReferenceId INTEGER);
-        CREATE TABLE ElementReference (Id INTEGER PRIMARY KEY, PageId INTEGER);
-        CREATE TABLE PageSetData (Id INTEGER PRIMARY KEY, Identifier TEXT, Data BLOB);
-      `);
-      db.prepare('INSERT INTO Page (Id, UniqueId, Name) VALUES (?, ?, ?)').run(1, 'page-1', 'Home');
-      db.prepare('INSERT INTO ElementReference (Id, PageId) VALUES (?, ?)').run(1, 1);
-      db.prepare(
-        'INSERT INTO Button (Id, Label, MessageRecordingId, ElementReferenceId) VALUES (?, ?, ?, ?)'
-      ).run(1, 'Test', 1, 1);
-      db.prepare('INSERT INTO PageSetData (Id, Identifier, Data) VALUES (?, ?, ?)').run(
-        1,
-        'SND:123',
-        Buffer.from('audio data')
-      );
+      const firstButton = db.prepare('SELECT Id FROM Button ORDER BY Id LIMIT 1').get() as { Id: number };
       db.close();
 
+      const audioData = Buffer.from('audio data');
+      saveProcessor.addAudioToButton(tempDbPath, firstButton.Id, audioData, 'test.wav');
+
       const processor = new SnapProcessor(null, { loadAudio: true });
-      const tree = processor.loadIntoTree(tempDbPath);
-      const page = tree.getPage('page-1');
+      const loadedTree = processor.loadIntoTree(tempDbPath);
+      const page = Object.values(loadedTree.pages)[0];
       expect(page).toBeDefined();
-      if (page) {
-        expect(page.buttons[0].audioRecording).toBeDefined();
-        expect(page.buttons[0].audioRecording!.data).toEqual(Buffer.from('audio data'));
-      }
+      const buttonWithAudio = page?.buttons.find((button) => button.audioRecording);
+      expect(buttonWithAudio).toBeDefined();
+      expect(buttonWithAudio?.audioRecording?.data).toEqual(audioData);
     });
 
     it('should add audio to a button', () => {