Use writeBinaryToPath instead of require('fs').writeFileSync#13
Merged
Conversation
Collaborator
|
Yeah for sure - I recently did a huge refactor to deal with dual publishing (node and cjs). This is clearly something I lost... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hello! I tried to import the browser package into a React Native project, but got the following error:
I'm not familiar with the codebase, but I can see that
src/index.browser.tsimportssrc/processors/gridsetProcessor, which includesrequire('fs'). I wonder whether that should be usingwriteBinaryToPathfromsrc/utils/ioinstead, as is used elsewhere?