Skip to content

Commit 0d8eee8

Browse files
committed
Fix CI: pin to windows-2022 and enable tag-based releases
windows-latest now resolves to windows-2025-vs2026 which lacks the v143 (VS 2022) platform toolset required by the vcxproj files. Pin all Windows jobs to windows-2022 to fix MSB8020 build failures. Also re-enable the release job's tag guard and the actual GitHub release creation step that were disabled for testing.
1 parent 0b16b96 commit 0d8eee8

1 file changed

Lines changed: 6 additions & 10 deletions

File tree

.github/workflows/msbuild.yml

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ env:
2020
jobs:
2121
build-sherpa-config:
2222
name: Build SherpaOnnxConfig
23-
runs-on: windows-latest
23+
runs-on: windows-2022
2424

2525
permissions:
2626
contents: read
@@ -47,7 +47,7 @@ jobs:
4747
4848
build-utilities:
4949
name: Build submodules
50-
runs-on: windows-latest
50+
runs-on: windows-2022
5151
needs: build-sherpa-config
5252

5353
permissions:
@@ -137,7 +137,7 @@ jobs:
137137

138138
build-main:
139139
name: Build NaturalVoiceSAPIAdapter
140-
runs-on: windows-latest
140+
runs-on: windows-2022
141141

142142
permissions:
143143
contents: read
@@ -220,7 +220,7 @@ jobs:
220220

221221
build-setup:
222222
name: Build MSI setup
223-
runs-on: windows-latest
223+
runs-on: windows-2022
224224
needs: [build-sherpa-config, build-utilities, build-main]
225225

226226
permissions:
@@ -286,9 +286,7 @@ jobs:
286286
release:
287287
runs-on: ubuntu-latest
288288
needs: [build-sherpa-config, build-utilities, build-main, build-setup]
289-
# TEMPORARY: Disabled tag check for testing release ZIP creation
290-
# REVERT BEFORE MERGE: Uncomment the line below to only create releases on tags
291-
# if: github.ref_type == 'tag'
289+
if: github.ref_type == 'tag'
292290

293291
permissions:
294292
contents: write
@@ -328,9 +326,7 @@ jobs:
328326
zip -r NaturalVoiceSAPIAdapter_${ver}_release-layout.zip x86 x64 ARM64 Installer.exe InstallPlanRunner.exe setup.exe NaturalVoiceSAPIAdapter.msi branding.json -i "*.exe" "*.dll" "*.json" "*.msi"
329327
330328
- name: Create release
331-
# TEMPORARY: Disabled for testing - ZIPs will be available as artifacts only
332-
# REVERT BEFORE MERGE: Uncomment the uses: line below to create GitHub releases
333-
if: false
329+
if: github.ref_type == 'tag'
334330
uses: softprops/action-gh-release@v2
335331
with:
336332
body_path: ${{github.workspace}}/release_notes.md

0 commit comments

Comments
 (0)