Beta5 Wave I: xPNTsToken finance + KMS UnfreezeKey (KMS → 100%)#72
Merged
Conversation
… closes task #17 KMS half) PART 1 — xPNTsToken (20 fns wrapped in tokens.ts, ABI-verified, ABIs from @aastar/core): - writes: setMaxSingleTxLimit, setSpenderDailyCap, recordDebtWithOpHash, addApprovedFacilitator, removeApprovedFacilitator, renounceFactory, unsetEmergencyDisabled - reads: maxSingleTxLimit, spenderDailyCapTokens, spenderRateLimit (tuple {dailyBurnTotal, windowStart, reserved}), usedDebtHashes, emergencyDisabled, emergencyRevokedAddress, exchangeRateUpdatedAt, approvedFacilitators - constants: EXCHANGE_RATE_COOLDOWN/DELTA_BPS/MAX/MIN, MAX_SINGLE_TX_LIMIT_CAP PART 2 — KMS POST /UnfreezeKey (kms-signer.ts KmsManager.unfreezeKey): plain client.post (no x-amz-target, unlike DeleteKey), ApiKey + WebAuthn-in-body per openapi.yaml; response {KeyId, LifecycleStatus}. This is the KMS half of the long-deferred task #17. Coverage: KMS 97% → 100%, xPNTsToken gaps 20 → 0. Codex review: APPROVE, 0 findings. Tests: core 313, airaccount 489 pass.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
clestons
approved these changes
Jun 16, 2026
clestons
left a comment
clestons
left a comment
There was a problem hiding this comment.
Review: Beta5 Wave I — xPNTsToken finance + KMS UnfreezeKey
Verdict: APPROVE — 4-round (20 token-finance wrappers incl. WRITES + a KMS state-changing op; verified + Codex PK). No findings.
Verified
- All 20 xPNTsToken wrappers correct —
functionName+ arity match the ABI (mechanical, 0 mismatch), and write arg ORDER/types match exactly (Codex Q5):setMaxSingleTxLimit,setSpenderDailyCap,recordDebtWithOpHash,addApprovedFacilitator/removeApprovedFacilitator,renounceFactory(0-arg, irreversible — correctly wired, exposing it is fine),unsetEmergencyDisabled; reads incl. thespenderRateLimittuple. ✅ - KMS
UnfreezeKeymatches the OpenAPI spec (Codex Q6, verified vsopenapi.yaml):POST /UnfreezeKey, globalApiKeyheader, body{KeyId, + optional WebAuthn}, nox-amz-target(correctly different from the AWS-KMS-shaped DeleteKey), response{KeyId, LifecycleStatus}. Auth/path correct for a state-changing unfreeze. ✅ (closes the KMS half of #17.)
Clean final coverage wave. Approving.
# Conflicts: # docs/coverage-report.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final Beta5 coverage wave. KMS 97% → 100% and closes all 20
xPNTsTokengaps.PART 1 — xPNTsToken (20 fns wrapped in
tokens.ts, ABI-verified, ABIs from@aastar/core):setMaxSingleTxLimit,setSpenderDailyCap,recordDebtWithOpHash,addApprovedFacilitator,removeApprovedFacilitator,renounceFactory,unsetEmergencyDisabledmaxSingleTxLimit,spenderDailyCapTokens,spenderRateLimit(tuple{dailyBurnTotal, windowStart, reserved}),usedDebtHashes,emergencyDisabled,emergencyRevokedAddress,exchangeRateUpdatedAt,approvedFacilitatorsEXCHANGE_RATE_COOLDOWN/DELTA_BPS/MAX/MIN,MAX_SINGLE_TX_LIMIT_CAPPART 2 — KMS
POST /UnfreezeKey(kms-signer.tsKmsManager.unfreezeKey): plainclient.post(nox-amz-target, unlike DeleteKey), ApiKey + WebAuthn-in-body peropenapi.yaml, response{KeyId, LifecycleStatus}. This is the KMS half of the long-deferred task #17.Codex challenge review: APPROVE, 0 findings. Tests: core 313, airaccount 489 pass (assert functionName+args / POST path+body).
🤖 Generated with Claude Code