Feat: Allow Invoice Items to have Notes (#604)

Historically, "invoice items" were the presets that could be applied when creating an invoice. They've fell out of favor, but we still generate massively templated invoices.

This PR adds "notes" to invoice items, such that when a preset is used, the memo is autofilled. We regularly use memos like this for labor quoting and other packages.

Co-authored-by: Perry Naseck <4472083+DaAwesomeP@users.noreply.github.com>

Author: tomas-goncalves

app/controllers/invoice_items_controller.rb

@@ -45,6 +45,6 @@ def destroy
 
   private
     def ii_params
-      params.require(:invoice_item).permit(:memo, :category, :price, :line_no)
+      params.require(:invoice_item).permit(:memo, :category, :price, :notes, :line_no)
     end
 end

app/javascript/src/invoices.coffee

@@ -17,8 +17,11 @@ $ ->
 window.chooseLinePreset = (id) ->
   if $("#invoice-line-preset-" + id).val() != ""
     selected = $("#invoice-line-preset-" + id + " option:selected").first()
+    if(selected.data('notes'))
+      showNotes(id)
     $("#invoice_invoice_lines_attributes_" + id + "_category").val(selected.data('category'))
     $("#invoice_invoice_lines_attributes_" + id + "_memo").val(selected.data('memo'))
+    $("#invoice_invoice_lines_attributes_" + id + "_notes").val(selected.data('notes'))
     $("#invoice_invoice_lines_attributes_" + id + "_quantity").val("1")
     $("#invoice_invoice_lines_attributes_" + id + "_price").val(selected.data('price'))
 
@@ -32,6 +35,13 @@ window.toggleNotes = (id) ->
     note.css("display","none")
     link.html("V")
 
+window.showNotes = (id) ->
+  note = $("#notes" + id)
+  link = $("#notesToggle" + id)
+  if note.css("display") == "none"
+    note.css("display","block")
+    link.html("^")
+
 window.indexList = () ->
   $('input.index').each( (i) ->
     $(this).val(i))
@@ -46,4 +56,4 @@ $ ->
   $("a.replace_field").click ->
     new_id = new Date().getTime()
     regexp = new RegExp("new_" + $(this).data("association"), "g")
-    $("#" + $(this).data("repid")).html($(this).data("content").replace(regexp, new_id))
+    $("#" + $(this).data("repid")).html($(this).data("content").replace(regexp, new_id))

app/views/invoice_items/_form.html.erb

@@ -23,6 +23,10 @@
     <td class="subheading"><%= f.label :price %>:</td>
     <td><%= f.text_field :price %></td>
   </tr>
+  <tr>
+    <td class="subheading"><%= f.label :notes %>:</td>
+    <td><%= f.text_area :notes, :size => "35x3" %></td>
+  </tr>
   <tr>
     <td></td>
     <td><%= f.submit %></td>

app/views/invoice_items/index.html.erb

@@ -5,6 +5,7 @@
     <th>Memo</th>
     <th>Category</th>
     <th>Price</th>
+    <th>Notes</th>
     <% if can? :update, InvoiceItem %>
       <th></th>
     <% end %>
@@ -18,6 +19,7 @@
     <td><%= item.memo %></td>
     <td><%= item.category %></td>
     <td><%= number_to_currency item.price %></td>
+    <td><%= simple_format item.notes %></td>
     <% if can? :update, item %>
       <td><%= link_to 'Edit', edit_invoice_item_url(item) %></td>
     <% end %>

app/views/invoices/_invoice_line_fields.html.erb

@@ -8,7 +8,7 @@
       <option></option>
 
       <% InvoiceItem.all.each do |item| %>
-        <option data-memo="<%= item.memo %>" data-category="<%= item.category %>" data-price="<%= item.price %>"><%= item.memo %></option>
+        <option data-memo="<%= item.memo %>" data-notes="<%= item.notes %>" data-category="<%= item.category %>" data-price="<%= item.price %>"><%= item.memo %></option>
       <% end %>
     </select>
   </td>

db/migrate/20250923064313_add_notes_to_invoice_items.rb

@@ -0,0 +1,5 @@
+class AddNotesToInvoiceItems < ActiveRecord::Migration[6.1]
+  def change
+    add_column :invoice_items, :notes, :text
+  end
+end